Verify YAML syntax in gates

This patchset implements yamllint test to all *.yml
files.

Also fixes syntax errors to make jobs to pass.

Change-Id: I3186adf9835b4d0cada272d156b17d1bc9c2b799
This commit is contained in:
Eduardo Gonzalez 2018-02-25 12:02:00 +01:00
parent 7851de5c3c
commit ea1a1dee0d
50 changed files with 160 additions and 158 deletions

15
.yamllint Normal file
View File

@ -0,0 +1,15 @@
extends: default
ignore: |
.tox/
rules:
line-length: disable
truthy: disable
braces:
max-spaces-inside: 1
comments:
# Ignore first space in comment because we set default options as:
#openstack_version: "pike"
require-starting-space: true
ignore: |
etc/kolla/globals.yml

View File

@ -1,3 +1,4 @@
---
- project:
check:
jobs:

View File

@ -37,4 +37,3 @@
roles:
- { role: baremetal,
tags: baremetal }

View File

@ -49,4 +49,3 @@
with_dict: "{{ chrony_services }}"
notify:
- Restart chrony container

View File

@ -28,7 +28,7 @@ common_services:
- "/dev/:/dev/"
- "/run/:/run/:shared"
- "kolla_logs:/var/log/kolla/"
# DUMMY_ENVIRONMENT is needed because empty environment is not supported
# DUMMY_ENVIRONMENT is needed because empty environment is not supported
cron:
container_name: cron
enabled: True

View File

@ -45,4 +45,3 @@
or glance_conf.changed | bool
or policy_overwriting.changed | bool
or glance_registry_container.changed | bool

View File

@ -125,4 +125,3 @@
notify:
- Restart glance-api container
- Restart glance-registry container

View File

@ -109,4 +109,3 @@
with_dict: "{{ haproxy_services }}"
notify:
- "Restart {{ item.key }} container"

View File

@ -131,4 +131,3 @@
- horizon.enabled | bool
notify:
- Restart horizon container

View File

@ -37,4 +37,3 @@
- service.enabled | bool
- action != "config"
notify: Restart memcached container

View File

@ -86,4 +86,3 @@
group: "{{ config_owner_group }}"
when: inventory_hostname in groups['compute']
with_sequence: start=1 end={{ num_nova_fake_per_node }}

View File

@ -436,4 +436,3 @@
with_dict: "{{ neutron_services }}"
notify:
- "Restart {{ item.key }} container"

View File

@ -1,3 +1,4 @@
---
- name: Install package python-os-xenapi
package:
name: python-os-xenapi

View File

@ -203,4 +203,3 @@
with_dict: "{{ nova_services }}"
notify:
- "Restart {{ item.key }} container"

View File

@ -70,4 +70,3 @@
with_dict: "{{ openvswitch_services }}"
notify:
- "Restart {{ item.key }} container"

View File

@ -50,7 +50,7 @@ ovsdpdk_services:
####################
ovs_bridge_mappings: "{% for bridge in neutron_bridge_name.split(',') %}physnet{{ loop.index0 + 1 }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}"
ovs_port_mappings: "{% for bridge in neutron_bridge_name.split(',') %} {{ neutron_external_interface.split(',')[loop.index0] }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}"
dpdk_tunnel_interface : "{{neutron_external_interface}}"
dpdk_tunnel_interface: "{{neutron_external_interface}}"
dpdk_tunnel_interface_address: "{{ hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['address'] }}"
tunnel_interface_network: "{{ hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['network']}}/{{hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['netmask']}}"
tunnel_interface_cidr: "{{dpdk_tunnel_interface_address}}/{{ tunnel_interface_network | ipaddr('prefix') }}"

View File

@ -8,4 +8,3 @@
- item.value.enabled | bool
- item.value.host_in_groups | bool
with_dict: "{{ ovsdpdk_services }}"

View File

@ -10,10 +10,8 @@
key: "{{ config_owner_group }}"
register: getent_group
#(duonghq) it's only a basic check, should be refined later
# NOTE(duonghq): it's only a basic check, should be refined later
- name: Check if ansible user can do passwordless sudo
shell: sudo -n true
register: result
failed_when: result | failed

View File

@ -34,4 +34,3 @@ skydive_analyzer_image_full: "{{ skydive_analyzer_image }}:{{ skydive_analyzer_t
skydive_agent_image: "{{ docker_registry ~ '/' if docker_registry else '' }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-skydive-agent"
skydive_agent_tag: "{{ openstack_release }}"
skydive_agent_image_full: "{{ skydive_agent_image }}:{{ skydive_agent_tag }}"

View File

@ -41,4 +41,3 @@
- config_json.changed | bool
or skydive_conf.changed |bool
or skydive_agent_container.changed | bool

View File

@ -31,4 +31,3 @@
- container_facts['skydive_agent'] is not defined
- inventory_hostname in groups[skydive_agent.group]
- skydive_agent.enabled | bool

View File

@ -1,4 +1,3 @@
---
- name: Stopping Kolla containers
command: /tmp/kolla-stop/tools/stop-containers

View File

@ -121,8 +121,8 @@ vitrage_datasource:
enabled: "{{ enable_cinder | bool }}"
- name: "neutron.network,neutron.port"
enabled: "{{ enable_neutron | bool }}"
#TODO(egonzalez) Heat cannot be used with default policy.json due stacks:global_index=rule:deny_everybody.
# Document process to deploy vitrage+heat.
# TODO(egonzalez) Heat cannot be used with default policy.json due stacks:global_index=rule:deny_everybody.
# Document process to deploy vitrage+heat.
- name: "heat.stack"
enabled: "no"

View File

@ -179,7 +179,7 @@ vitrage_keystone_password:
memcache_secret_key:
#HMAC secret key
# HMAC secret key
osprofiler_secret:
nova_ssh_key:

View File

@ -1,5 +1,5 @@
---
features:
- Add ansible role for openstack congress project which provide
- Add ansible role for openstack congress project which provide
policy as a service across any collection of cloud services in
order to offer governance and compliance for dynamic infrastructures.

View File

@ -1,5 +1,5 @@
---
features:
features:
- Introduce OpenStack Infrastructure Optimization
service, also known as Watcher. This project makes
use of Ceilometer data to rebalance the cloud to

View File

@ -1,4 +1,4 @@
---
other:
- Congress doesn't work correctly out of the box and will
not deploy. See Bug #1634641.
not deploy. See Bug https://bugs.launchpad.net/kolla-ansible/+bug/1634641.

View File

@ -6,4 +6,3 @@ deprecations:
* /etc/kolla/config/database.conf
* /etc/kolla/config/messaging.conf

View File

@ -2,4 +2,3 @@
deprecations:
- The nova-network was deprecated, we remove it from the nova ansible
role.

View File

@ -1,3 +1,4 @@
---
- hosts: all
vars:
logs_dir: "/tmp/logs"

View File

@ -30,11 +30,15 @@ setenv = VIRTUAL_ENV={envdir}
commands = python setup.py testr --coverage --testr-args='{posargs}'
[testenv:pep8]
deps =
{[testenv]deps}
yamllint
commands =
{toxinidir}/tools/run-bashate.sh
flake8 {posargs}
python {toxinidir}/tools/validate-all-file.py
bandit -r ansible kolla_ansible tests tools
yamllint .
[testenv:bandit]
commands = bandit -r ansible kolla_ansible tests tools