kolla-ansible/ansible/library
Mark Goddard 28273411a8 Fix kolla_toolbox error handling
Backport only.

The kolla_toolbox Ansible module executes as-hoc ansible commands in the
kolla_toolbox container, and parses the output to make it look as if
ansible-playbook executed the command. Currently however, this module
sometimes fails to catch failures of the underlying command, and also
sometimes shows tasks as 'ok' when the underlying command was changed.

This change introduces a check on the status field for non-JSON output,
and assumes the module has changes on success.

NOTE: The original patch on master
(https://review.opendev.org/#/c/682340/) cannot be backported as it
relies on Ansible 2.5+ in the kolla_toolbox container.

Change-Id: Ib1e33f8e5c60d98b76a4eba9f405af89431d60bc
Closes-Bug: 1844114
2019-09-24 16:32:22 +00:00
..
bslurp.py Update hacking version 2018-12-27 04:44:49 +00:00
kolla_ceph_keyring.py ceph: fixes to deployment and upgrade 2019-08-06 14:28:03 +00:00
kolla_container_facts.py Update hacking version 2018-12-27 04:44:49 +00:00
kolla_docker.py Fix kolla-docker possible undefined variable 2019-03-10 19:13:00 +01:00
kolla_toolbox.py Fix kolla_toolbox error handling 2019-09-24 16:32:22 +00:00