openstack
/
kolla-ansible
Code Issues Proposed changes
kolla-ansible/37fdad4b14161ac1cbb7aae0946...

338 lines
10 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "743d2421_900b8429",
"filename": "ansible/group_vars/all.yml",
"patchSetId": 14
},
"lineNbr": 1133,
"author": {
"id": 22629
},
"writtenOn": "2023-02-20T07:16:01Z",
"side": 1,
"message": "and ML2/OVS users without OVN will get an OVN exporter?",
"range": {
"startLine": 1133,
"startChar": 65,
"endLine": 1133,
"endChar": 115
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "92d6f7df_74a90f2b",
"filename": "ansible/group_vars/all.yml",
"patchSetId": 14
},
"lineNbr": 1133,
"author": {
"id": 34646
},
"writtenOn": "2023-02-21T08:46:17Z",
"side": 1,
"message": "OVN Exporter is able too, to read the Open_vSwitch database. That was my intention to enable it here",
"parentUuid": "743d2421_900b8429",
"range": {
"startLine": 1133,
"startChar": 65,
"endLine": 1133,
"endChar": 115
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3037bae9_82dffe0a",
"filename": "ansible/group_vars/all.yml",
"patchSetId": 14
},
"lineNbr": 1133,
"author": {
"id": 34646
},
"writtenOn": "2023-02-21T08:47:27Z",
"side": 1,
"message": "https://github.com/greenpau/ovn_exporter",
"parentUuid": "92d6f7df_74a90f2b",
"range": {
"startLine": 1133,
"startChar": 65,
"endLine": 1133,
"endChar": 115
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "51bbb7ce_577d8ebd",
"filename": "ansible/group_vars/all.yml",
"patchSetId": 14
},
"lineNbr": 1133,
"author": {
"id": 29268
},
"writtenOn": "2023-02-22T23:41:38Z",
"side": 1,
"message": "I\u0027m looking at adding ovs_exporter in via another change, which will cover the OVS monitoring portion. I think keeping this specific for OVN though should be adequate, no?",
"parentUuid": "3037bae9_82dffe0a",
"range": {
"startLine": 1133,
"startChar": 65,
"endLine": 1133,
"endChar": 115
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "59b9ab5c_35ca874d",
"filename": "ansible/group_vars/all.yml",
"patchSetId": 14
},
"lineNbr": 1133,
"author": {
"id": 32553
},
"writtenOn": "2023-04-05T09:55:55Z",
"side": 1,
"message": "can\u0027t both exporters report their respective metrics?\nfwiw - afaik this is the mentioned ovs exporter - the ovs exporter _also_ reports ovn metrics:\n\nhttps://github.com/greenpau/ovs_exporter\n\nmaybe this could be consolidated upstream instead, as both exporters seem to overlap quite a bit.\n\nbut I see no harm if metrics are reported, when they are present?",
"parentUuid": "51bbb7ce_577d8ebd",
"range": {
"startLine": 1133,
"startChar": 65,
"endLine": 1133,
"endChar": 115
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2089a1a9_eb7f6ec1",
"filename": "ansible/group_vars/all.yml",
"patchSetId": 14
},
"lineNbr": 1133,
"author": {
"id": 32553
},
"writtenOn": "2023-04-14T08:15:24Z",
"side": 1,
"message": "I just asked upstream what they think is the best way moving forward, as both exporters seem to be from the same person:\n\nhttps://github.com/greenpau/ovs_exporter/issues/9\n\nmaybe it\u0027s planned to even merge these two in a single exporter, let\u0027s see what upstream says.",
"parentUuid": "59b9ab5c_35ca874d",
"range": {
"startLine": 1133,
"startChar": 65,
"endLine": 1133,
"endChar": 115
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f0c56103_39c110d8",
"filename": "ansible/group_vars/all.yml",
"patchSetId": 14
},
"lineNbr": 1133,
"author": {
"id": 13252
},
"writtenOn": "2023-06-02T07:34:43Z",
"side": 1,
"message": "any update on this?",
"parentUuid": "2089a1a9_eb7f6ec1",
"range": {
"startLine": 1133,
"startChar": 65,
"endLine": 1133,
"endChar": 115
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5ae428cb_e4d88d8d",
"filename": "ansible/group_vars/all.yml",
"patchSetId": 14
},
"lineNbr": 1133,
"author": {
"id": 32553
},
"writtenOn": "2023-06-02T07:41:01Z",
"side": 1,
"message": "not from upstream no.\nMy plan would be to indeed at first split this up, so ovs exporter only reports ovs metrics and ovn exporter only ovn metrics.\n\nI\u0027d then like to document, or even activate by default, ovs exporter if ovn exporter is enabled.\n\nWhat do you think?",
"parentUuid": "f0c56103_39c110d8",
"range": {
"startLine": 1133,
"startChar": 65,
"endLine": 1133,
"endChar": 115
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "13c71c34_da7137da",
"filename": "ansible/group_vars/all.yml",
"patchSetId": 14
},
"lineNbr": 1133,
"author": {
"id": 13252
},
"writtenOn": "2023-06-16T08:42:10Z",
"side": 1,
"message": "hmm, o.k., let\u0027s start with what we have and then iterate",
"parentUuid": "5ae428cb_e4d88d8d",
"range": {
"startLine": 1133,
"startChar": 65,
"endLine": 1133,
"endChar": 115
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "96903067_b2197950",
"filename": "tests/templates/globals-default.j2",
"patchSetId": 14
},
"lineNbr": 166,
"author": {
"id": 22629
},
"writtenOn": "2023-02-20T07:16:01Z",
"side": 1,
"message": "there\u0027s no OVN in this scenario",
"range": {
"startLine": 166,
"startChar": 0,
"endLine": 166,
"endChar": 37
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "87df22a0_ba5bcdd0",
"filename": "tests/templates/globals-default.j2",
"patchSetId": 14
},
"lineNbr": 166,
"author": {
"id": 29268
},
"writtenOn": "2023-02-22T23:41:38Z",
"side": 1,
"message": "This was recommended by frickler in an earlier comment. Maybe we should enable Prometheus and the exporter in the ovn test scenario?",
"parentUuid": "96903067_b2197950",
"range": {
"startLine": 166,
"startChar": 0,
"endLine": 166,
"endChar": 37
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a52db210_1248337e",
"filename": "tests/templates/globals-default.j2",
"patchSetId": 14
},
"lineNbr": 166,
"author": {
"id": 32553
},
"writtenOn": "2023-04-05T09:55:55Z",
"side": 1,
"message": "so should I remove this for now until this is enabled in the ovn test scenario?",
"parentUuid": "87df22a0_ba5bcdd0",
"range": {
"startLine": 166,
"startChar": 0,
"endLine": 166,
"endChar": 37
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "778b8b35_f3875746",
"filename": "tests/templates/globals-default.j2",
"patchSetId": 14
},
"lineNbr": 166,
"author": {
"id": 13252
},
"writtenOn": "2023-06-02T07:34:43Z",
"side": 1,
"message": "why not enable it directly?",
"parentUuid": "a52db210_1248337e",
"range": {
"startLine": 166,
"startChar": 0,
"endLine": 166,
"endChar": 37
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "53ee263e_5ee617f5",
"filename": "tests/templates/globals-default.j2",
"patchSetId": 14
},
"lineNbr": 166,
"author": {
"id": 32553
},
"writtenOn": "2023-06-02T07:41:01Z",
"side": 1,
"message": "I don\u0027t know what you mean by \"enable it directly\"?\n\nIt get\u0027s enabled in the current patch set \"directly\"? did you mean to say I should enable it in the ovn test scenario only and not globaly like the current code does?",
"parentUuid": "778b8b35_f3875746",
"range": {
"startLine": 166,
"startChar": 0,
"endLine": 166,
"endChar": 37
},
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink