d8f31e0a5e
* Reworked tox pep8 into linters job, that runs: - pep8 - bandit - bashate - doc8 - yamllint - ansible-lint (validate-all-files.py + ansible-lint) * Skip E701 - missing galaxy_info in meta and E602 see [1]. * Skip E301 and E503 - followup later in a separate change * Added ansible-role-jobs to zuul.d/project.yaml which will run openstack-tox-linters job in check queue * Fixed remaining style issue * Made tox and docs reference the new env for linters * Dropped pype environment (not supported) [1]: https://github.com/ansible/ansible-lint/issues/457 Change-Id: I494b4b151804aac8173120e6c6e42bc2fdb00234
144 lines
4.3 KiB
INI
144 lines
4.3 KiB
INI
[tox]
|
|
minversion = 3.1
|
|
skipsdist = True
|
|
envlist = py37,linters
|
|
ignore_basepython_conflict = True
|
|
|
|
[testenv]
|
|
basepython = python3
|
|
usedevelop = True
|
|
whitelist_externals = find
|
|
rm
|
|
deps = -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/requirements.txt
|
|
-r{toxinidir}/test-requirements.txt
|
|
passenv = http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY
|
|
OS_STDOUT_CAPTURE OS_STDERR_CAPTURE OS_LOG_CAPTURE OS_TEST_TIMEOUT
|
|
PYTHON OS_TEST_PATH LISTOPT IDOPTION
|
|
commands =
|
|
find . -type f -name "*.py[c|o]" -delete -o -type l -name "*.py[c|o]" -delete
|
|
find . -type d -name "__pycache__" -delete
|
|
stestr run --slowest {posargs}
|
|
|
|
[testenv:debug]
|
|
commands = oslo_debug_helper -t tests {posargs}
|
|
|
|
[testenv:cover]
|
|
setenv = VIRTUAL_ENV={envdir}
|
|
NOSE_WITH_COVERAGE=1
|
|
NOSE_COVER_BRANCHES=1
|
|
NOSE_COVER_HTML=1
|
|
NOSE_COVER_HTML_DIR={toxinidir}/cover
|
|
PYTHON=coverage run --source kolla_ansible,ansible/action_plugins,ansible/library,ansible/roles/keystone/files/ --parallel-mode
|
|
commands =
|
|
stestr run {posargs}
|
|
coverage combine
|
|
coverage html -d cover
|
|
coverage xml -o cover/coverage.xml
|
|
|
|
[testenv:venv]
|
|
deps =
|
|
-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/test-requirements.txt
|
|
-r{toxinidir}/doc/requirements.txt
|
|
commands = {posargs}
|
|
|
|
[testenv:docs]
|
|
deps =
|
|
-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/doc/requirements.txt
|
|
commands =
|
|
rm -rf doc/build
|
|
sphinx-build -W --keep-going -b html doc/source doc/build/html
|
|
|
|
[testenv:deploy-guide]
|
|
deps =
|
|
-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/doc/requirements.txt
|
|
commands =
|
|
rm -rf deploy-guide/build
|
|
sphinx-build -a -E -W -d deploy-guide/build/doctrees --keep-going -b html deploy-guide/source deploy-guide/build/html
|
|
|
|
[testenv:pdf-docs]
|
|
whitelist_externals = make
|
|
deps = {[testenv:docs]deps}
|
|
commands =
|
|
sphinx-build -W --keep-going -b latex doc/source doc/build/pdf
|
|
make -C doc/build/pdf
|
|
|
|
[testenv:releasenotes]
|
|
deps =
|
|
-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/requirements.txt
|
|
-r{toxinidir}/doc/requirements.txt
|
|
commands =
|
|
rm -rf releasenotes/build
|
|
sphinx-build -a -E -W -d releasenotes/build/doctrees --keep-going -b html releasenotes/source releasenotes/build/html
|
|
|
|
[testenv:lower-constraints]
|
|
deps =
|
|
-c{toxinidir}/lower-constraints.txt
|
|
-r{toxinidir}/test-requirements.txt
|
|
-r{toxinidir}/requirements.txt
|
|
|
|
[testenv:linters]
|
|
# Env vars and deps need to be defined in top level tox env
|
|
setenv =
|
|
ANSIBLE_LIBRARY = {toxinidir}/ansible/library
|
|
ANSIBLE_ACTION_PLUGINS = {toxinidir}/ansible/action_plugins
|
|
ANSIBLE_FILTER_PLUGINS = {toxinidir}/ansible/filter_plugins
|
|
deps =
|
|
-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/test-requirements.txt
|
|
-r{toxinidir}/doc/requirements.txt
|
|
whitelist_externals = bash
|
|
commands =
|
|
{[testenv:pep8]commands}
|
|
{[testenv:doc8]commands}
|
|
{[testenv:bandit]commands}
|
|
{[testenv:bashate]commands}
|
|
{[testenv:yamllint]commands}
|
|
{[testenv:ansible-lint]commands}
|
|
|
|
[testenv:pep8]
|
|
deps = {[testenv:linters]deps}
|
|
commands =
|
|
flake8 {posargs}
|
|
|
|
[flake8]
|
|
show-source = True
|
|
# NOTE: Default ignore list is *not* empty!
|
|
# W504 line break after binary operator
|
|
# (W503 and W504 are incompatible and we need to choose one of them.
|
|
# Existing codes follows W503, so we disable W504.):
|
|
ignore = W504
|
|
exclude = .eggs,.git,.tox,doc
|
|
|
|
[testenv:doc8]
|
|
deps = {[testenv:linters]deps}
|
|
commands =
|
|
doc8 doc/source
|
|
doc8 -e '.yaml' releasenotes/notes/
|
|
|
|
[testenv:bashate]
|
|
deps = {[testenv:linters]deps}
|
|
commands =
|
|
bash -c "{toxinidir}/tools/run-bashate.sh"
|
|
|
|
[testenv:bandit]
|
|
# B303: Use of insecure MD2, MD4, MD5, or SHA1 hash function.
|
|
deps = {[testenv:linters]deps}
|
|
commands = bandit --skip B303 -r ansible kolla_ansible tests tools
|
|
|
|
[testenv:ansible-lint]
|
|
# Lint only code in ansible/* - ignore tests/ and roles/ used by CI
|
|
setenv = {[testenv:linters]setenv}
|
|
deps = {[testenv:linters]deps}
|
|
commands =
|
|
python {toxinidir}/tools/validate-all-file.py
|
|
ansible-lint -p --exclude {toxinidir}/tests --exclude {toxinidir}/roles
|
|
|
|
[testenv:yamllint]
|
|
deps = {[testenv:linters]deps}
|
|
commands = yamllint -s .
|