kolla-ansible/a8a3d765539869b06df99ac0437b566233d5988a

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "37425bed_1651c46e",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 12
      },
      "lineNbr": 0,
      "author": {
        "id": 13252
      },
      "writtenOn": "2022-09-26T09:34:03Z",
      "side": 1,
      "message": "In the default OVS deployment, this is creating a lot of errors in the exporter log [0] and I cannot find any useful data in the metrics. Maybe this really should be enabled only for OVN?\n\nI also think you should add enabling the exporter to the `scenario \u003d\u003d \"prometheus-efk\"` block in `tests/templates/globals-default.j2` so that this code actually gets tested.\n\n[0] https://paste.opendev.org/show/bVhlSD9niemzLbp490ml/",
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "3c96db77_ccc82a15",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 12
      },
      "lineNbr": 0,
      "author": {
        "id": 29268
      },
      "writtenOn": "2023-02-22T23:41:38Z",
      "side": 1,
      "message": "\u003e In the default OVS deployment, this is creating a lot of errors in the exporter log [0] and I cannot find any useful data in the metrics. Maybe this really should be enabled only for OVN?\n\u003e \n\u003e I also think you should add enabling the exporter to the `scenario \u003d\u003d \"prometheus-efk\"` block in `tests/templates/globals-default.j2` so that this code actually gets tested.\n\u003e \n\u003e [0] https://paste.opendev.org/show/bVhlSD9niemzLbp490ml/",
      "parentUuid": "37425bed_1651c46e",
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "efa80c8b_582ce6ff",
        "filename": "ansible/group_vars/all.yml",
        "patchSetId": 12
      },
      "lineNbr": 1148,
      "author": {
        "id": 13252
      },
      "writtenOn": "2022-09-26T09:34:03Z",
      "side": 1,
      "message": "I would swap the and/or logic to make it simpler:\n\nenable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool )",
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "12bb5aeb_3553c824",
        "filename": "ansible/group_vars/all.yml",
        "patchSetId": 12
      },
      "lineNbr": 1148,
      "author": {
        "id": 29268
      },
      "writtenOn": "2023-02-22T23:41:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "efa80c8b_582ce6ff",
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "fccf6327_d3208513",
        "filename": "ansible/roles/prometheus/handlers/main.yml",
        "patchSetId": 12
      },
      "lineNbr": 185,
      "author": {
        "id": 13252
      },
      "writtenOn": "2022-09-26T09:34:03Z",
      "side": 1,
      "message": "Missing \"-exporter\", the handler name needs to match the way it is being triggered.",
      "range": {
        "startLine": 185,
        "startChar": 16,
        "endLine": 185,
        "endChar": 30
      },
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "607d687b_7f6c81e6",
        "filename": "ansible/roles/prometheus/handlers/main.yml",
        "patchSetId": 12
      },
      "lineNbr": 185,
      "author": {
        "id": 29268
      },
      "writtenOn": "2023-02-22T23:41:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "fccf6327_d3208513",
      "range": {
        "startLine": 185,
        "startChar": 16,
        "endLine": 185,
        "endChar": 30
      },
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "c373c177_dd256c0a",
        "filename": "ansible/roles/prometheus/handlers/main.yml",
        "patchSetId": 12
      },
      "lineNbr": 193,
      "author": {
        "id": 13252
      },
      "writtenOn": "2022-09-26T09:34:03Z",
      "side": 1,
      "message": "You haven\u0027t defined an enviroment, need to drop this line to avoid a failure.",
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "765b4046_0d0e0a0b",
        "filename": "ansible/roles/prometheus/handlers/main.yml",
        "patchSetId": 12
      },
      "lineNbr": 193,
      "author": {
        "id": 29268
      },
      "writtenOn": "2023-02-22T23:41:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "c373c177_dd256c0a",
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "81bb09e3_610a3b16",
        "filename": "ansible/roles/prometheus/tasks/precheck.yml",
        "patchSetId": 12
      },
      "lineNbr": 196,
      "author": {
        "id": 13252
      },
      "writtenOn": "2022-09-26T09:34:03Z",
      "side": 1,
      "message": "This variable isn\u0027t defined anywhere, causing the precheck to fail.\n\nAlso using a loop when there is only one fixed item is an anti-pattern IMO. Even if this has been copied a couple of times before, maybe we can stop doing it. Probably best by doing a patch cleaning up the other misuses before this one.",
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "5fdb4378_70e15973",
        "filename": "ansible/roles/prometheus/tasks/precheck.yml",
        "patchSetId": 12
      },
      "lineNbr": 196,
      "author": {
        "id": 29268
      },
      "writtenOn": "2023-02-22T23:41:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "81bb09e3_610a3b16",
      "revId": "a8a3d765539869b06df99ac0437b566233d5988a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}