openstack
/
kolla
Code Issues Proposed changes

validate-indentation was failing locally for me 

grep -E '^\s+[A-Z]+\s' was matching any
"  a "
"  FOO "

where this was trying to only catch " FOO " case

Change-Id: Ife64cb9f02b3f1463d5143e57629418bc478de49
This commit is contained in:
Jon Schlueter 2018-06-21 14:48:22 -04:00
parent d8c7d1b27c
commit b7c0f053b0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/validate-indentation.sh
View File

@ -3,8 +3,9 @@
RES=0
for dockerfile in "$@"; do
if grep -qE '^\s+[A-Z]+\s' "$dockerfile"; then
if grep -qE '^\s+[[:upper:]]+\s+' "$dockerfile"; then
echo "ERROR: $dockerfile has indented Dockerfile instruction" >&2
grep -E '^\s+[[:upper:]]+\s+' "$dockerfile"
RES=1
fi
done