openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(47 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 32919 \u003c32919@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32919\u003e replied on the change"}
This commit is contained in:
Gerrit User 32919 2024-02-05 11:02:59 +00:00 committed by Gerrit Code Review
parent 229d7d27b2
commit a617aa9538
3 changed files with 1104 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

846
7073bfe6e2eb52a56586b4e46ad0506d84f9e6fc
View File

File diff suppressed because it is too large Load Diff

234
7e375d234c48fb3e6c33584ea12452ec0e29ee60
View File

@ -141,6 +141,24 @@
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b24e1db8_28ae06da",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 82,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "8fd91534_eea4ff40",
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -236,6 +254,30 @@
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff8890a9_6280042c",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 168,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "8cfbec2c_53fa60e8",
"range": {
"startLine": 163,
"startChar": 2,
"endLine": 168,
"endChar": 69
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -259,6 +301,30 @@
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "009df5ee_58eccdb9",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 173,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "b737e94f_f9e08dbc",
"range": {
"startLine": 172,
"startChar": 0,
"endLine": 173,
"endChar": 38
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -306,6 +372,30 @@
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "69d6d664_7bd1c3da",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 183,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "35af1d02_a09f6561",
"range": {
"startLine": 179,
"startChar": 0,
"endLine": 183,
"endChar": 37
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -329,6 +419,30 @@
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6ff5e70f_6728d2eb",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 195,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "8965561d_c9c86070",
"range": {
"startLine": 194,
"startChar": 0,
"endLine": 195,
"endChar": 39
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -352,6 +466,30 @@
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "93561d54_5db23170",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 201,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "03856523_87f8c966",
"range": {
"startLine": 201,
"startChar": 0,
"endLine": 201,
"endChar": 45
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -399,6 +537,30 @@
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5719cf92_62ef9248",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 220,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "This will be back-end and default for now.",
"parentUuid": "1fa85d53_1aad1e83",
"range": {
"startLine": 220,
"startChar": 32,
"endLine": 220,
"endChar": 41
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -422,6 +584,30 @@
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9c271f06_1a4e8670",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 225,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "no, this means if u specify any field of encryption, you need to specify all of them. Else do not specify encryption field at all i.e. create share type without encryption",
"parentUuid": "538d576d_95d31aa4",
"range": {
"startLine": 225,
"startChar": 0,
"endLine": 225,
"endChar": 52
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -445,6 +631,30 @@
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0390efd9_5cbf5fb5",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 304,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "7ad331af_e53291ec",
"range": {
"startLine": 304,
"startChar": 0,
"endLine": 304,
"endChar": 39
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -568,6 +778,30 @@
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0602e961_b1ee25bc",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 4
},
"lineNbr": 330,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "c0f96cc2_abecd8bd",
"range": {
"startLine": 330,
"startChar": 3,
"endLine": 330,
"endChar": 35
},
"revId": "7e375d234c48fb3e6c33584ea12452ec0e29ee60",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

24
e64af4d2075bc78bbe7801856ca1bfbcafadbf5d
View File

@ -266,6 +266,30 @@
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8392caa9_b474fbb9",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 191,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "8da6cf7e_23130726",
"range": {
"startLine": 185,
"startChar": 0,
"endLine": 191,
"endChar": 48
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {