openstack/manila
Code Issues Proposed changes

Merge "[cephfs] Fix access rule update"

Browse Source
This commit is contained in:
Zuul
2025-02-14 20:28:03 +00:00
committed by Gerrit Code Review
parent 64f53692ef c153f2e73f
commit 3f049faa17
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manila/share/drivers/cephfs/driver.py
View File

@@ -819,7 +819,7 @@ class CephFSDriver(driver.ExecuteMixin, driver.GaneshaMixin,
sub_name = self._get_subvolume_name(share['id'])
return self.protocol_helper.update_access(
context, share, access_rules, add_rules, delete_rules,
share_server=share_server, sub_name=sub_name)
update_rules, share_server=share_server, sub_name=sub_name)
def get_backend_info(self, context):
return self.protocol_helper.get_backend_info(context)

5
manila/tests/share/drivers/cephfs/test_driver.py
View File

@@ -623,14 +623,15 @@ class CephFSDriverTestCase(test.TestCase):
}
add_rules = access_rules = [alice, ]
delete_rules = []
update_rules = []
self._driver.update_access(
self._context, self._share, access_rules, add_rules, delete_rules,
None)
update_rules, None)
self._driver.protocol_helper.update_access.assert_called_once_with(
self._context, self._share, access_rules, add_rules, delete_rules,
share_server=None, sub_name=self._share['id'])
update_rules, share_server=None, sub_name=self._share['id'])
def test_ensure_shares(self):
self._driver.protocol_helper.reapply_rules_while_ensuring_shares = True