openstack
/
manila
Code Issues Proposed changes

Remove unused assignments in share manager 

Also rename a variable to conform with spelling of
'suppress' so that it is easier to find.

Change-Id: I8223ad807efefe92e2d32222bac9d25b40605e70
This commit is contained in:
Tom Barron 2017-03-04 14:17:04 -05:00
parent 8c514bba76
commit 70176ccd6a
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
manila/share/manager.py
View File

@ -1372,12 +1372,12 @@ class ShareManager(manager.SchedulerDependentManager):
helper.cleanup_new_instance(dest_share_instance)
cancelled = (
task_state == constants.TASK_STATE_DATA_COPYING_CANCELLED)
supress_errors = True
suppress_errors = True
if cancelled:
supress_errors = False
suppress_errors = False
self._reset_read_only_access_rules(
context, share_ref, src_instance_id,
supress_errors=supress_errors, helper=helper)
supress_errors=suppress_errors, helper=helper)
self.db.share_instance_update(
context, src_instance_id,
{'status': constants.STATUS_AVAILABLE})
@ -3447,7 +3447,6 @@ class ShareManager(manager.SchedulerDependentManager):
'share_server_id']
status = constants.STATUS_AVAILABLE
model_update = False
share_network_id = share_group_ref.get('share_network_id')
share_server = None
@ -3545,8 +3544,6 @@ class ShareManager(manager.SchedulerDependentManager):
self.db.share_instances_get_all_by_share_group_id(
context, share_group_id))
model_update = False
# TODO(ameade): Add notification for delete.start
try: