Update patch set 10

Patch Set 10: Code-Review+2

(2 comments)

Looking good, Kiran! Thank you for your patience with this change.

Patch-set: 10
Reviewer: Gerrit User 29632 <29632@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
This commit is contained in:
Gerrit User 29632 2021-08-05 20:36:00 +00:00 committed by Gerrit Code Review
parent 3512cc22a8
commit bcc7e2c365
2 changed files with 51 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "197513c8_c4bda959",
"filename": "releasenotes/notes/bug-1900752-early-validate-mandatory-security-service-association-f48aecbbc47418cd.yaml",
"patchSetId": 10
},
"lineNbr": 7,
"author": {
"id": 29632
},
"writtenOn": "2021-08-05T20:36:00Z",
"side": 1,
"message": "From now on,",
"range": {
"startLine": 6,
"startChar": 42,
"endLine": 7,
"endChar": 8
},
"revId": "21c84b63f16ee42d9f06e0bf6b22abeeae39a7bd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}

View File

@ -94,6 +94,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "cf94bc49_bdc47318",
"filename": "manila/tests/share/test_manager.py",
"patchSetId": 8
},
"lineNbr": 2489,
"author": {
"id": 29632
},
"writtenOn": "2021-08-05T20:36:00Z",
"side": 1,
"message": "No worries, Kiran!",
"parentUuid": "49e9c60d_35a35f05",
"range": {
"startLine": 2488,
"startChar": 8,
"endLine": 2489,
"endChar": 60
},
"revId": "c949816dbf7ac92ff547d89bd5c9aad02626aea5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "aa7e6e33_beb37ff6",