Update patch set 5
Patch Set 5: Code-Review-1 (3 comments) Patch-set: 5 Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 797e88a7de7a00f72d7a8f2e4c05efd762d980e2 Attention: {"person_ident":"Gerrit User 36758 \u003c36758@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
This commit is contained in:
parent
e072d43d56
commit
f70ea67197
@ -1,5 +1,28 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e47ef4a1_0eaf9e4d",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 18,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2024-04-09T18:49:27Z",
|
||||
"side": 1,
|
||||
"message": "you still need this",
|
||||
"range": {
|
||||
"startLine": 18,
|
||||
"startChar": 0,
|
||||
"endLine": 18,
|
||||
"endChar": 53
|
||||
},
|
||||
"revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
@ -52,6 +75,24 @@
|
||||
"revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "1f96da24_c370603e",
|
||||
"filename": "manila/share/drivers/qnap/api.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 24,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2024-04-09T18:49:27Z",
|
||||
"side": 1,
|
||||
"message": "My bad; this import order conforms to our guidelines.",
|
||||
"parentUuid": "271000da_9e4b0df4",
|
||||
"revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
27
b17866e916442196c3c0b968c46a7ac2ed0ac4e8
Normal file
27
b17866e916442196c3c0b968c46a7ac2ed0ac4e8
Normal file
@ -0,0 +1,27 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "8c798c10_50a7038c",
|
||||
"filename": "manila/share/drivers/qnap/api.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 82,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2024-04-09T18:49:27Z",
|
||||
"side": 1,
|
||||
"message": "two spaces before # nosec:\n```\ncontext \u003d ssl._create_unverified_context() # nosec\n```",
|
||||
"range": {
|
||||
"startLine": 82,
|
||||
"startChar": 58,
|
||||
"endLine": 82,
|
||||
"endChar": 66
|
||||
},
|
||||
"revId": "b17866e916442196c3c0b968c46a7ac2ed0ac4e8",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user