Share instance records and their relations were missing db_retry and
so added the db_retry decorator.
Co-Authored-By: Maurice Escher <maurice.escher@sap.com>
Closes-bug: #2084529
Change-Id: Iac0bee438365ab0902859df74647f1502c619270
(cherry picked from commit b64e5a35e1067976de3c92372476582b4d99a3ac)
Ensure manila command is available in PATH when GLOBAL_VENV is True.
This is required to fix the grenade job which still used manila
commands.
Change-Id: I2445bbc3769e283aaaef76803b2b9630279def91
(cherry picked from commit 35c6ca5e208e1f5bee8aad1013c5bd401bc41aec)
This module has been removed in Python 3.13. There is no change in
functionality:
$ python3
Python 3.12.4 (main, Jun 12 2024, 19:06:53) [GCC 13.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import shlex, pipes
<stdin>:1: DeprecationWarning: 'pipes' is deprecated and slated for
removal in Python 3.13
>>> shlex.quote == pipes.quote
True
Change-Id: I4c364239163d481970f16947931b82a6a25b868e
(cherry picked from commit e28bb5905ea2cddbbef523d94d0ca1efb3550fbf)
- Updates the drivers support matrix
- Updates the CephFS drivers documentation and highlight how the
process works and what are the known limitations.
Change-Id: I2f937358e93271fc5ad63e76cc4a9c5aa0ba3017
(cherry picked from commit 4fe2b014e52d095d333e4cdb7ffb3269974bde43)
Updates to the end user, which allows them to specify metadata items
that should be passed to backend share drivers. Share driver may take
needed action from provided metadata if supported.
partially-implements: blueprint pass-resource-metadata-updates-to-backend-drivers
Change-Id: If595af5910706582165c11c30e73766c208f9b4e
(cherry picked from commit debec4378552fa991fccd4cc761299c70ed81f99)
- Deferred deletion would be regular deletion where quota is freed
before resource deletion by driver and deletion states are hidden
from end-user. Also, everything will be handled by Manila or admin
if any error occurs in deletion.
- Any error during deferred deletion will put share/snapshot in
error_deferrer_deleting state and periodic task will handle it.
- count_share_group_snapshot_members_in_share() should not return share
instances in deferred deletion states as those shares are hidden from
end-user once deferred deleted. Only actual deletion (by driver) will
make sure snapshot instance of share instance should be deleted before
share instance deletion.
partially-implements: bp/deferred-deletion
Closes-bug: #2068043
Change-Id: Ie827619d3952d1db69559206b5dfd47efb4cf7b1
(cherry picked from commit e8f086d0f58608a2ff04958af668538e0ed5f7be)
The CephFS driver used to set the "preferred"
export path by sending back an export location
model update; however, the "preferred" keyword
is expected in the export location's metadata,
not in the export location dict.
Change-Id: Id2214412fe75456cdb52edb5ff261d32b063655f
Closes-Bug: #2053100
(cherry picked from commit 17088aa57af3ae2dd5a16e2e8558ec471d2c1cc5)
This is a follow-up change to the ensure shares APIs [1]. An
additional policy check was added, but it was not needed, as it
was already being performed by the decorator, so we remove it.
[1] https://review.opendev.org/c/openstack/manila/+/924279
Change-Id: Iab25d5a6a3906dfdb1cb3473188edcc5fafc80d4
(cherry picked from commit 697c9bf3d34b4eb291158c99ae859da10a0c2c59)
Drivers can set arbitrary key=value metadata to export
paths. The share manager now checks updates to previously
set metadata when drivers update this metadata with the
"ensure_shares" routine.
Change-Id: Ia42de608ba056d71a1deae2c59bfb43a11672ab7
Partial-Bug: #2053100
(cherry picked from commit 3e9d535be1799a2f2d590537125e3b7630dc4aee)
Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.
Until the requirements repository has as stable/2024.2 branch, tests will
continue to use the upper-constraints list on master.
Change-Id: Ie0440ab04538952a0d2e857520b434951e56d242
Export locations of active share replicas was updated
but not those of the share itself.
Closes-Bug: #2017501
Change-Id: I33204657401f3eadd490fc50fedaef899dcff297
"delete" was the only lock action supported when
we introduced the API; but we now support "show"
as well for the access rules resource.
Also fix an incorrect parameter in the PUT /resource-locks
method.
Change-Id: Ie276d9c984586ad5b90581e46796d390f748ce1f
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
The NetApp ONTAP driver now supports the SnapLock feature. New
capability 'netapp_snaplock_type' has been added to the backend pool
to create and schedule shares on the required WORM-supported pool.
Extra spec, 'netapp_snaplock_type', can be used to create SnapLock
volumes. Additionally, extra specs related to the SnapLock retention
period have been introduced to set the retention period on SnapLock
volumes.
Implements: blueprint snaplock-support-for-manila-driver
Change-Id: I73c4d027852fbfbbdab59538cbe23ba1487da0de
This patch adds support for Share Export Locations in the
Metadata Controller.
Co-Authored-By: Ashley Rodriguez <ashrod98@gmail.com>
Partially-implements: bp metadata-for-share-resources
Change-Id: Icf096a5cbc650f02eca68d714c876eb854499b9b
This patch provides the support for share server migrations between
different physical networks. It is achieved by creating an inactive port
binding on the target host during share server migration, and then cut
it over to target host when migration completes. The implementation is
driver agnostic, so this feature should be not limited to specific
driver, although it is only tested against NetApp driver. The feature is
enabled by a new share service option
'server_migration_extend_neutron_network'. The support for multiple
binding Manila ports is added in Neutron's 2023.1 release.
Closes-Bug: #2002019
Change-Id: I18d0dd1847a09f28989b1a2b62fc6ff8f8155def
This change introduce a new extra spec netapp:efficiency_policy
where the user can specify a pre-created NetApp efficiency policy
from share located share-server. During share creation, User specified
efficiency policy can be applied to the FlexVol/FlexGroup volume that
corresponds to the Manila Share.
Blueprint: manila-netapp-efficiency-policy
Change-Id: I1ebc1b8ac6d70c4f525593d0fc75aa0cae2b22bf
Introduces a new API to allow OpenStack administrators to start
the share manager's ensure shares operation.
Also, introduced a new configuration option named
`update_shares_status_on_ensure`, so administrators can define
whether the shares status should be updated during the ensure
shares operation or not.
A new column was added to the services table, named `ensuring`.
Through this field, we can identify whether there is an undergoing
ensure shares operation or not.
Closes-Bug: #1996793
Partially-Implements: bp ensure-shares-api
Change-Id: If7bf059eb8581f20a3ceb7c1af93558774f4ef5e
Add the possibility to specify how the data will be displayed
while issuing the manila-manage command. This can be helpful to
automations,
Change-Id: I0af426254be886e31553275feb23b9ec90ec2cc8
- Only allow to admin user and with 'only_host' scheduler hint
In all other cases, scheduler will ignore disabled host. Please note,
'disabled' host is up/running(i.e. listening on RPC calls), but
disabled using share service set API.
Closes-bug: #2072552
Change-Id: Iaaa4e274d47cf2eaa0247234f268fdb5ff24461b
Implement manage/unmanage for shares and snapshots to the CephFS
drivers.
- Instead of providing the export locations, users will need to
provide the subvolume/subvolume snapshot name in the
export/provider location parameter.
- The size of the snapshots will follow the shares' size, as we
can not currently be sure of the real size of the snapshot. This
must be fixed after the issue is addressed within the ceph
backend [1].
- We will attempt to resize subvolumes whose size are "infinite"
to the size value provided within the driver_options parameter.
- Start storing the provider location of the snapshots after
their creation, so it can be reused later.
[1] https://tracker.ceph.com/issues/67215#change-270669
Partially-Implements: bp manage-unmanage-cephfs-shares-and-snapshots
Change-Id: I5e86d09ea5ba8e61ecf04c52b25c639dfc823737
Signed-off-by: Carlos Eduardo <ces.eduardo98@gmail.com>
For NetApp ONTAP driver, share revert to snapshot considers the largest
size between original share size and snapshot size after revert is done.
This is different from the users' and Manila's expectation where share
size is updated to snapshot size.
Closes-bug: #2064502
Change-Id: I6a1b87eabeb7bef80725a537acb6771c35b76afc
NetApp Driver- Exclude the vserver management network interface for
certain vserver account when checking the vserver Kerberos configuration
for network interfaces.
Closes-Bug: #2073766
Change-Id: I1f7a1207b8714b3fccd202526eeb92a547083537
Consider two metadata keys i.e. snapshot_policy and showmount.
Partially-implements: blueprint pass-resource-metadata-updates-to-backend-drivers
Depends-on: If4297cca3249359f72976800db2112ea9c61c06f
Change-Id: I042a2caa5884ddea09ecfa0028d01758c18af5a3