The downgrade incorrectly modifies deleted
share access rules.
Also add a missing unit test for this migration.
Co-Authored-By: Goutham Pacha Ravi <gouthampravi@gmail.com>
Change-Id: If3700e7a18cbd8ae496b8c503c95cf6723485679
Closes-Bug: #1717392
Use generic driver create share, then add user type access failed.
We can not use 'manila access-deny' to delete the user rule
in a NFS share db.
This path fix this issue.
Change-Id: I9375c4be9361d593102a382eb9c14c2d776bb1aa
Closes-Bug:#1591357
Skip route creation if user decided to configure neutron network
without a gateway.
Closes-Bug: #1777126
Change-Id: Ic54e3aa7fc8327464110fff40d02c690d8b19122
When share instances were introduced a number of fields
were moved in the database model to the underlying share instance
and proxied back to the share in order to maintain compatability
with APIs that assume these to belong to the share. A deprecation
warning was added for these. The warning spams the API log and
confuses end users because it sounds like they or their client
should make a change to get rid of them and that cannot actually
be done. The API would have to change to expose share instances
to end users rather than just administrators and that is not
something that we plan to do.
Remove these confusing warnings.
Closes-Bug: #1776947
Change-Id: I95e99b26f416bbf25cfd1c8f7295f3ba6220efb3
Adds resolving the volume name to volume id when resizing
and cleans up _resolve_volume_name calls.
Closes-Bug: #1774604
Change-Id: I37ecd611c94f9b0019b87d5186f96aed93130f88
By default, routes.mapper.Mapper.resource adds a bunch of formatted
routes that accept anything after a '.'. Our spec says only .xml
and .json are accepted so limit the formatting to those valuse.
This allows identifiers with a '.' in urls. A few tests were added
to the extensions test to prove that .xml and .json are stripped
but other values are not.
It is already modified in cinder [1].
[1] https://bugs.launchpad.net/cinder/+bug/1307956
Change-Id: I91d8aa967446b5d7ce52f1b245149304494777f3
Closes-bug: #1774353
Added new config option limit_ssh_access. If set to true the
neutron security groups are set up to block port 22 from other
subnets than service network in service instance.
Change-Id: I3c247ac2c55e5c74dbb0c8e31144bb865fd48710
Closes-bug: #1714288
After manage share, driver updates the share size.
The share size should not be updated.
Change-Id: I5f670495cd61b63d1c0669c274b502a6a691e4e2
Closes-Bug: #1773761
The cloud administrator needs to use the cephfs volume path prefix to
layout multiple cephfs driver backends. When cephfs has multiple
data pools, manila can configure `cephfs_volume_path_prefix` to store
volume data in different cephfs directories of a ceph filesystem [1]
for the different cephfs driver backends. Out of band of manila, the
admin can set the pool layouts of these cephfs directories to store
the volume data in different data pools of the ceph filesystem. This
is helpful for planning different data storage to different ceph OSDs.
[1] https://github.com/ceph/ceph/commit/d1a21b07ede#diff-8625369b924524f064e083e735bd34beR267
Change-Id: I19e3dd55f1fded339cb17222b3333c0c0f8835e9
Implements: blueprint cephfs-driver-configurable
Ensure a shares initial quota is set in the backend,
and do quota size conversion when resizing.
Closes-Bug: #1771958
Closes-Bug: #1771970
Change-Id: I64a1e591c2682bc8bb62554a95399b5651253f59
The /etc/mtab file may have mount information such as 'nfsd'
that if copied to /etc/fstab will cause the share server to
hang when rebooted.
Update /etc/fstab with exactly the newly mounted or unmounted
shares rather than simply overwriting /etc/fstab with /etc/mtab.
Change-Id: I67602bae1f928769d768008deca7bd0f2fef1ac2
Close-Bug: #1639662
In CIDR notation, the max prefix-length is typically
used to denote individual host addresses, for example:
2620:52:0:13b8::fe:e7 and 2620:52:0:13b8::fe:e7/128
are semantically the same.
Fix the access-allow API to raise 400 Bad Request if
an address by either notation already exists in the
manila database for a given share.
Change-Id: I6e790fd0edd82064a3c5cda8a919c9eeb2da85d0
Closes-Bug: 1767430
qos- APIs are unavailable to vsadmin users. Fix the
code in the delete share flow to prevent failing on
being unable to execute the qos-get-iter call.
Change-Id: If9ce7c840fc968824d53002eaaea082e28631178
Closes-Bug: 1765420
Allows to configure in which organizational unit the share ends up
APIImpact
Change-Id: I70fd4e0ea7898e85dff59a927b3cb086d5e408ac
Needed-By: I77d87c8e6f98054f2f02bc4202c14314ff321964
Partial-Bug: #1696669
Cinder, nova, neutron has deprecated some default options
since last release, so it is time to remove those options
in this version. refer to the following deprecation patch.
Ref: https://review.openstack.org/#/c/290511/
Closes-bug: #1766384
Change-Id: I595ff2c82ef40566145fedb202e549be69c45e0c
'standalone_network_plugin_ip_version' option has been
deprecated. This option has been replaced by
'network_plugin_ipv4_enabled' and
'network_plugin_ipv6_enabled' options.
Change-Id: I0251fecddac74578698bcda5d46e44ca16bd8a76
Add support for extra_specs filter search in type list API.
Change-Id: I43fbef2a32489f2064586a3674eb34329f3503c4
Implements: blueprint support-filter-search-for-share-type
This removes some custom code inherited from Cinder which was handling
the output of secret options in a bad way. This patch utilizes Oslo's
existing utilities to output the Manila configuration options securely.
Filtering will be done with the "secret=True" option flag.
Major thanks to Eric Harney for introducing this fix to Cinder.
Change-Id: I894e011680661c0b73b9592f70a6457e403f18c6
Related-Bug: #1750074
When use driver_handles_share_servers driver, the tap device will
down and the tap device mac address is changed after restart the
node, that will caused manila can not manage share that created
by this service.
This path fix this issue. When restart manila-share service,
call setup_connectivity_with_service_instances() to create host port
and check the the mac address.
Change-Id: Ibcdd4f58f15a53c69d35db06bc42283859349758
Closes-Bug:#1688155
While Huawei driver mounting CIFS filesystem, the username parameter
key passed to the mount command is by the form of "user=***", which's
compatible as "username=***" in Ubuntu. However, for some other
systems, such as Redhat, it is not valid.
This patch changes it to the more compatible form "username=***".
Change-Id: Ifa2ca7bcdceef2d47e2841a27ddf51d86f1ef63c
Closes-Bug: #1740816
Manila will display the rabbitmq password if debugging is enabled.
This patch will ensure that the rabbitmq password is no longer
displayed in the connection log for Manila when debugging is
enabled by looking for the rabbitmq key and not printing it.
There should likely be an effort to utilize Oslo's secret flag for
options to truly fix this issue for this and other sensitive options.
Change-Id: I97cc88354d9b54057350c70c4742055197540d1a
Closes-Bug: 1750074
Starting with mariadb 10.2.8, removing a column
that is part of a primary key requires that the
primary key constraint be dropped and recreated.
Change-Id: I43e4dae325dd6561a9fe0fd4ce595cea4c2ef7a6
Closes-Bug: #1749184
Recovery mode is currently used by host-assisted share
migration to bulk remove and add back rules while casting
them to read only.
Unfortunately, it is not handling IPv6 addresses when removing
the rules in this code path. This patch adds a call to a function
that handles the IPv6 addresses, adding brackets around them.
Change-Id: Icba4b22ad87ccfabcc02078648b1abc6410e5353
Closes-bug: #1746723
