Export locations of active share replicas was updated
but not those of the share itself.
Closes-Bug: #2017501
Change-Id: I33204657401f3eadd490fc50fedaef899dcff297
(cherry picked from commit 07ce64462c63c5253226a733f5686e78eb7223a1)
NeutronNetworkPlugin allows the use of external networks
as share networks. Deployers use this as a way to utilize
Neutron's IPAM capabilities. To provide IP addresses out
of a network, Neutron would need to create ports on the
network, albeit these ports are unused.
A recent change in OVN (a popular Neutron ML2 plugin) [1]
necessitates Manila to explicitly create ports as being
"DOWN" to prevent incorrect ARP responses from OVN; the
eventual, external ports must respond to the ARP requests
from clients.
Change-Id: Icd5b1a2087a4e38e9d0b65f9c0d9a85abad69f07
Closes-Bug: #2074504
(cherry picked from commit 53c8b69c016010e2bbbf3220bcf771a2e9dd8b91)
With some NetApp hardware models, driver turn on efficiency by default.
That is why Manila might see the conflicting sis operation. Retry for 5
times, in case dedupe enable/disable failed with error "Another sis
operation is currently active."
Closes-bug: #2071359
Change-Id: I6229a98063d393289e2225ceacd84145ecf320d0
(cherry picked from commit e982eae40a21da26727a4d55a17a3b03f716d046)
Bumps pylint to version 3.0.2 and fixes some issues in the code
by either ignoring or changing the way we are approaching them.
Signed-off-by: silvacarloss <ces.eduardo98@gmail.com>
Change-Id: Ifdc9ae9326f2b3d63d4b2e9ce14854f391d504a9
(cherry picked from commit 12aa2913baa4e004d2198f0a5fd3ad9ccfeb302d)
- Error messages on web pages have been corrected.
before - Share Type %(id)s already exists. (HTTP 409)
after - Share Type name already exists. (HTTP 409)
- The issue suggested a hash as a solution, but I think it is more intuitive to print the name as a string.
Closes-Bug: #2069782
Change-Id: Ie3ef6a1da24abe000b9239c3d3fb22cace4ca9fc
Signed-off-by: Youngjun <yj.yoo@okestro.com>
(cherry picked from commit 528a64448ff4216be97e249844b0dcea781c3cb5)
Fixed the issue for the NetApp driver in the ZAPI workflow where a
Vserver-scoped user failed to add rules for a share when the
Vserver LIF was not configured with Kerberos.
Closes-Bug: #2069125
Change-Id: I8544efbdac207c54d75c55ee4a039c5324433794
(cherry picked from commit 232627db3b39163cfbef00d1e625fcd9a524253a)
Added default port value for the Dell PowerFlex
NAS backend
Closes-Bug: #2066840
Change-Id: Ifda8c0b179763fe0884ef3845b6836be861ca6a8
(cherry picked from commit d7f7b6312a3529f6f23cc541114594308f85e1af)
Backup restore is failing across the ONTAP cluster for REST client.
Added the logic to use to destination vserver client for REST client
to restore the backup and modify the restore lib for cmode REST
client accordingly.
Closes-Bug: #2059399
Change-Id: Icd7f1b52a10659ee1cfeef3accbbb725d4046a13
(cherry picked from commit 080d3ba66969b243734cfc6410328bc29b3b735c)
Added the logic in resource cleanup part to delete the vserver
peering when source and destination vserver are not same.
Closes-bug: #2058642
Change-Id: I02a70642a22095ab202f5846fff04d25321c4c1c
(cherry picked from commit aa8695716afd281af32d365787b48069edb7a633)
Fix the the below issues as part of this patch
- Fix the issue when backup is created with wrong config. Due to
wrong config backup status is not changing from creating status
to failed.
- Failed the backup creation when SnapMirror relationship created
during backup creation was not healthy.
- Added few fields in snapmirror GET API to fix the REST
workflow for backup.
- Incorporated left over review comments of patch
I5a4edbf547e7886fb4fa9c1bed90110a33f9bf3b
Closes-Bug: #2058027
Change-Id: I013ff3eedea54d9895e4c0446017aeb62c6bb833
(cherry picked from commit 33dc4b767ba4ae116d6b8850a69c32f696a1bcdc)
- Manila share server deletion happens asynchronously. If deletion of
share server fails in between, share server network ports remained as
it is. So we should better delete share network ports first and then
continue share server deletion.
- It may be possible, that there are ports existing without a
corresponding manila network allocation entry in the manila db, because
port create request may have been successfully sent to neutron, but not
stored in db. So query(and delete) those from neutron after db entries
are deleted.
Closes-bug: #2067266
Change-Id: Id86dade1194494e599aea9adad06e4ca6cb119b6
(cherry picked from commit 76d032969848fa409f3b7da499cc2da3de67f6be)
Make sure that all password options is defined with secret=True so that
the given values do not appear in debug logs.
Also remove the redundant default=None .
Change-Id: I989e825ef160a65a5a72c58d6fd4e8099044bcd5
(cherry picked from commit f8a53c037a1f80880a9180b218288f1766084449)
This is unorthodox; but we want to ensure there are
no breakages.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: Ib67538ebd0f8ebbea5a700343f52655b0f7fecd4
(cherry picked from commit 2a9ac87cc412431b268aba40729e144bd34bdf32)
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
This is a squashed set of commits made
to the 2024.2/Dalmatian cycle, aimed at supporting
sqlalchemy2.0. Squashed changes:
I267e2e0fac0b4130f8836de276082788fbd8d454
I991d6127c14b5f06ca9ca8e6caccbc392e639b42
Id1b555e48106662d15e8c50567a5f3acecf6a8f1
I590f4c7f78851b20a339294b820d0c223e298f3d
I3d29b5426c5a633b5590367b56d00847215d8201
I3fa8e4e1e526d75051cb323702e3532d99008313
Ie5035546c3d640e3558446ad082510c249d0ce65
I38ae324d5edb3705b559c3706d6888f08473a633
I2a1a8b8eb933fc750ff8b3fc9d7ff1c7686625e6
Iee198a16f030f1205d38b7c232d4e3a42642c756
I1251a5c0b2f073604ae61f378992fea7df51c07d
Ie8831c04b7b4515deea27b1ceb472d07cda91ca0
I2ee07c7e41ea43c2ab24a4a095550dd0b5fe47dd
I37bbe45d6d9ce41a3c238e33d4469f9a362491ad
I155b4ce4b605720c8335d465124fd32cc973a737
I1da6d117778bbbad64b2df2dfd2f8aeef8a7084c
I9d760ebbfcca176a39b44f20fb92e16eaf6284c5
Ib67538ebd0f8ebbea5a700343f52655b0f7fecd4
Depends-On: Iaaf3c3914089ad0d27b61a524f14353cae35c4d5
Change-Id: I5907a661b630320907b13ddac0faafe236ccd596
Co-Authored-By: Stephen Finucane <stephenfin@redhat.com>
Co-Authored-By: Mike Bayer <mike_mp@zzzcomputing.com>
Closes-Bug: #2060907
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
The url to get the next share replica is broken when performing
pagination. The new API uses underscore to represent resource.
This fix resolves the broken link for share replicas by using alias.
Closes-bug: #2023754
Change-Id: I31e32c0bcfb60b53121da9a96df3b44ad2b3ac67
(cherry picked from commit c8236141f86fc609ee9901a42bbcffe60bd66e40)
Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.
Until the requirements repository has as stable/2024.1 branch, tests will
continue to use the upper-constraints list on master.
Change-Id: I0a19eef6155afbdf3d439939ca21f6f4922cf201
NetApp driver changes to accommodate human readable
share location. Export path is updated with
human frendly value if present else use share-id.
partially-implements: bp human-readable-export-locations
Depends-On: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883
Change-Id: I2f5bfdbc9d0458c7b9198a3eb94b3b095d5b5e04
- the parameter description in the parameter and annotation did not match, so this was fixed.
Change-Id: I1557b74b5a2d0b81f68aa15149490bb178a5a716
Signed-off-by: Youngjun <yj.yoo@okestro.com>
A couple of releases ago, we started supporting clustered NFS
gateways [1], and we mentioned we had clear intentions to make
this the default choice for the deployments.
In this change, we are deprecating the NFSProtocolHelper, which
will be removed in the next skip-level release.
This means that Manila will no longer support exports created over
a NFS Ganesha instance that is not managed by the Ceph Cluster.
[1] https://review.opendev.org/c/openstack/manila/+/848987
Change-Id: I062a8c552d7d94e010cef6694bec6da68d7ea180
Added new column named 'backup_type' in 'share_backups' table
and changes the share common api libs to support the dhss_true
configuration for share backup creation
Partially-implements: bp/share-backup
Change-Id: Ifb88ec096674ea8bc010c1c3f6dea1b51be3beaa
Implement the share backup feature for NetApp driver.
NetApp SnapVault technology is used to create and restore
the backup for NetApp ONTAP share. backup delete workflow
just delete the transferred snapshot from destination
backup volume.
Depends-On: Ifb88ec096674ea8bc010c1c3f6dea1b51be3beaa
Change-Id: I5a4edbf547e7886fb4fa9c1bed90110a33f9bf3b
There's a new driver mode supported since
Antelope (introduced in Zed) that supports
ceph orchestrator deployed CephFS NFS clusters.
We were missing documentation regarding this.
Also consolidate the admin/configuration references
for this driver; this deletes all the outdated
information in the existing config guide.
Partially-implements: bp use-cephadm-nfs-ganesha
Change-Id: I43952d890629e60465059a5b4242817becb198b1
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
In a replication setup, users encountered a critical
issue where they unintentionally reset the replica_state
of an active replica while attempting to resolve errors
on a non-active replica. This led to a situation with no
active replica, causing data loss. Users expected
server-side validation to prevent such actions.
This commit implements the necessary validation in the
codebase to ensure that the reset_replica_state action
cannot be applied to active replicas, addressing the
reported issue and improving data integrity in
replication setups.
Co-Authored-By: Solly <solobarine@gmail.com>
Closes-Bug: #2015328
Change-Id: I629669476e585a834673b8c8b49ad4b0270b877f
This change is a follow-up to a change that merged recently [1].
We are changing the name of the config option to make it similar
to the policy we have defined for updating some metadata that
should only be manipulated by administrators.
[1] https://review.opendev.org/c/openstack/manila/+/909175
Related-Bug: #2050010
Change-Id: I9a8a27f1181b92291f2d4ad5fd9d4483e2dacc50
Export locations are usually too difficult to memo
rize.Currently, there is no way to determine the
export location before the share is created, so
users wait until the share creation request gets
completed, and then they check the export
locations to mount the share. The generated
export locations are often not human readable
and it is hard to memorize and control them.
Implements: bp/human-readable-export-locations
Change-Id: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883