[CI] Run bashate

... and fix related issues.

Change-Id: I3283545a8994c3895b9ccbe4006bec4b4cfc8c95

devstack/plugin.sh

@@ -64,7 +64,8 @@ function create_masakari_accounts {
 
         create_service_user "$USERNAME" "admin"
 
-        local masakari_service=$(get_or_create_service "masakari" \
+        local masakari_service
+        masakari_service=$(get_or_create_service "masakari" \
             "instance-ha" "OpenStack High Availability")
         if [ "$MASAKARI_USE_MOD_WSGI" == "False" ]; then
             get_or_create_endpoint $masakari_service \

tox.ini

@@ -33,10 +33,12 @@ commands = oslopolicy-sample-generator --config-file=etc/masakari/masakari-polic
 deps =
   -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
   -r{toxinidir}/test-requirements.txt
+  {[testenv:bashate]deps}
 commands =
   {[testenv:pep8]commands}
   {[testenv:doc8]commands}
   {[testenv:yamllint]commands}
+  {[testenv:bashate]commands}
 
 [testenv:pep8]
 deps = {[testenv:linters]deps}
@@ -54,6 +56,14 @@ commands =
 deps = {[testenv:linters]deps}
 commands = yamllint -s .
 
+[testenv:bashate]
+skip_install = True
+deps =
+  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
+  bashate
+commands =
+  bashate devstack/plugin.sh -v --ignore E006 --error E005,E042,E043
+
 [testenv:venv]
 commands = {posargs}