openstack
/
mistral-dashboard
Code Issues Proposed changes

Refactor error messages 

This patch refactors error messages and
shows the detailed error message

Change-Id: I4d7fc03c9368bf20cd374097ff210e1ecb952d23
This commit is contained in:
pengyuesheng 2019-09-06 15:02:45 +08:00 committed by Renat Akhmerov
parent eba4d3acec
commit 809416b7b5
5 changed files with 19 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mistraldashboard/actions/forms.py
View File

@ -130,8 +130,8 @@ class CreateForm(forms.SelfHandlingForm):
messages.success(request, msg) messages.success(request, msg)
return True return True
except Exception: except Exception as e:
msg = _('Failed to create action.') msg = _('Failed to create action: %s') % e
redirect = reverse('horizon:mistral:actions:index') redirect = reverse('horizon:mistral:actions:index')
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)
@ -188,7 +188,7 @@ class UpdateForm(forms.SelfHandlingForm):
messages.success(request, msg) messages.success(request, msg)
return True return True
except Exception: except Exception as e:
msg = _('Failed to update action.') msg = _('Failed to update action: %s') % e
redirect = reverse('horizon:mistral:actions:index') redirect = reverse('horizon:mistral:actions:index')
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)

4
mistraldashboard/executions/forms.py
View File

@ -39,7 +39,7 @@ class UpdateDescriptionForm(forms.SelfHandlingForm):
return True return True
except Exception: except Exception as e:
msg = _('Failed to update execution description.') msg = _('Failed to update execution description: %s') % e
redirect = reverse('horizon:mistral:executions:index') redirect = reverse('horizon:mistral:executions:index')
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)

9
mistraldashboard/executions/views.py
View File

@ -113,10 +113,10 @@ class IndexView(tables.DataTableView):
reverse=True reverse=True
) )
except Exception: except Exception as e:
self._prev = False self._prev = False
self._more = False self._more = False
msg = _('Unable to retrieve executions list.') msg = _('Unable to retrieve executions list: %s') % e
exceptions.handle(self.request, msg) exceptions.handle(self.request, msg)
return executions return executions
@ -168,11 +168,12 @@ class TasksView(tables.DataTableView):
reverse=True reverse=True
) )
except Exception: except Exception as e:
self._prev = False self._prev = False
self._more = False self._more = False
msg = ( msg = (
_('Unable to retrieve executions list of the requested task.') _('Unable to retrieve executions list of '
'the requested task: %s') % e
) )
exceptions.handle(self.request, msg) exceptions.handle(self.request, msg)

8
mistraldashboard/workbooks/forms.py
View File

@ -108,8 +108,8 @@ class CreateForm(forms.SelfHandlingForm):
messages.success(request, msg) messages.success(request, msg)
return True return True
except Exception: except Exception as e:
msg = _('Failed to create workbook.') msg = _('Failed to create workbook: %s') % e
redirect = reverse('horizon:mistral:workbooks:index') redirect = reverse('horizon:mistral:workbooks:index')
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)
@ -123,7 +123,7 @@ class UpdateForm(CreateForm):
messages.success(request, msg) messages.success(request, msg)
return True return True
except Exception: except Exception as e:
msg = _('Failed to update workbook.') msg = _('Failed to update workbook: %s') % e
redirect = reverse('horizon:mistral:workbooks:index') redirect = reverse('horizon:mistral:workbooks:index')
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)

8
mistraldashboard/workflows/forms.py
View File

@ -161,8 +161,8 @@ class CreateForm(forms.SelfHandlingForm):
messages.success(request, msg) messages.success(request, msg)
return True return True
except Exception: except Exception as e:
msg = _('Failed to create workflow.') msg = _('Failed to create workflow: %s') % e
redirect = reverse('horizon:mistral:workflows:index') redirect = reverse('horizon:mistral:workflows:index')
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)
@ -176,7 +176,7 @@ class UpdateForm(CreateForm):
messages.success(request, msg) messages.success(request, msg)
return True return True
except Exception: except Exception as e:
msg = _('Failed to update workflow.') msg = _('Failed to update workflow: %s') % e
redirect = reverse('horizon:mistral:workflows:index') redirect = reverse('horizon:mistral:workflows:index')
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)