openstack
/
monasca-agent
Code Issues Proposed changes

Merge "Fix version comparison on zookeeper plugin"

This commit is contained in:
Jenkins 2017-05-30 09:34:58 +00:00 committed by Gerrit Code Review
parent c2b9008230 58a8733526
commit d2387eaa46
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
monasca_agent/collector/checks_d/zk.py
View File

@ -20,7 +20,7 @@ Mode: leader
Node count: 487 Node count: 487
``` ```
Tested with Zookeeper versions 3.0.0 to 3.4.5 Tested with Zookeeper versions 3.0.0 to 3.4.10
""" """
import re import re
@ -101,7 +101,7 @@ class Zookeeper(AgentCheck):
raise Exception("Could not parse version from stat command output: %s" % start_line) raise Exception("Could not parse version from stat command output: %s" % start_line)
else: else:
version_tuple = match.groups() version_tuple = match.groups()
has_connections_val = version_tuple >= ('3', '4', '4') has_connections_val = map(int, version_tuple) >= [3, 4, 4]
# Clients: # Clients:
buf.readline() # skip the Clients: header buf.readline() # skip the Clients: header