openstack/murano
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert

Browse Source 
Some of tests use different method of assertTrue(isinstance(A, B))
or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B)
provided by testtools

Change-Id: Id6ff634d7af3ee3b2eb4add770b0ba589bb08d1d
This commit is contained in:
LiuNanke
2016-09-30 04:26:01 +08:00
parent f121631e40
commit 1d73536020
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
murano/tests/unit/api/middleware/test_version_negotiation.py
View File

@@ -28,4 +28,4 @@ class MiddlewareVersionNegotiationTest(base.MuranoTestCase):
middleware_vn = version_negotiation.VersionNegotiationFilter(None)
request = webob.Request.blank('/environments')
result = middleware_vn.process_request(request)
self.assertTrue(isinstance(result, versions.Controller))
self.assertIsInstance(result, versions.Controller)