openstack/neutron-lib
Code Issues Proposed changes
eb7a55bdca
neutron-lib/HACKING.rst
Ihar Hrachyshka b87ecb3b8c Enforce log messages not being translated 
This is in line with discussion [1] where translators asked to stop
translating log messages, leaving translations for user visible messages
only.

This patch introduces a new N537 check, and since it is more broad than
N533 while covering all cases of the latter check, N533 is removed.

This patch also cleans up _i18n._L? translation hints since they are
internal and won't be allowed anymore.

[1] http://lists.openstack.org/pipermail/openstack-dev/2017-March/114191.html

Related-Bug: #1674569
Change-Id: I2813587824eac1a996c715b0c4bd36b0c9580d73
2017-04-12 15:57:38 -07:00

1.0 KiB
Raw Blame History

neutron-lib Style Commandments

Neutron Library Specific Commandments

  • [N521] Validate that jsonutils module is used instead of json
  • [N523] DEPRECATED. Enforce namespace-less imports for oslo libraries
  • [N524] Prevent use of deprecated contextlib.nested.
  • [N525] Python 3: Do not use xrange.
  • [N526] Python 3: do not use basestring.
  • [N527] Python 3: do not use dict.iteritems.
  • [N529] Method's default argument shouldn't be mutable
  • [N530] No importing of neutron; should be ignored in neutron itself
  • [N532] Validate that LOG.warning is used instead of LOG.warn. The latter is deprecated.
  • [N534] Exception messages should be translated
  • [N535] Usage of Python eventlet module not allowed
  • [N536] Use assertIsNone/assertIsNotNone rather than assertEqual/assertIs to check None values.
  • [N537] Don't translate logs.