openstack/neutron-specs
Code Issues Proposed changes

Update patch set 2

Browse Source 
Patch Set 2:

(3 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 11975 \u003c11975@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
This commit is contained in:
Gerrit User 16688 2022-10-27 10:54:49 +00:00 committed by Gerrit Code Review
parent be4cfc002d
commit 176d247e6d
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
0c8ccb5191a2ebb93ed7601a161461f283d85b46
View File

@ -34,6 +34,24 @@
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f320097d_320f3536",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
"patchSetId": 2
},
"lineNbr": 59,
"author": {
"id": 16688
},
"writtenOn": "2022-10-27T10:54:49Z",
"side": 1,
"message": "Ok, but it could be a problem if this configuration parameter is changed once the RP is created. In any case, I\u0027ll add a warning in the config variable description.",
"parentUuid": "03da1a37_bd9f52fe",
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +69,24 @@
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "29f6ae0a_67982845",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
"patchSetId": 2
},
"lineNbr": 129,
"author": {
"id": 16688
},
"writtenOn": "2022-10-27T10:54:49Z",
"side": 1,
"message": "Done",
"parentUuid": "06f6d33e_2041d3ee",
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -67,6 +103,24 @@
"message": "As we recently discussed internally, can You maybe elaborate more about what kind of tempest tests do You think should be added to test it? Some API tests or scenario test?",
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "56bcf600_9b4f3570",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
"patchSetId": 2
},
"lineNbr": 153,
"author": {
"id": 16688
},
"writtenOn": "2022-10-27T10:54:49Z",
"side": 1,
"message": "The API tests are already covered in tempest.\nInstead of tempest tests, what I should implement is fullstack tests, checking the mech driver agent (OVS, OVN) has correctly reported the requested BW.",
"parentUuid": "db6e1ca8_a189d10d",
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}