openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 13252 \u003c13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
This commit is contained in:
Gerrit User 13252 2023-11-20 07:04:00 +00:00 committed by Gerrit Code Review
parent 63c59e8bfa
commit 53051f1c99
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
33f1231954f739b6105ce35bca96cde10111af0c
View File

@ -133,6 +133,30 @@
"revId": "33f1231954f739b6105ce35bca96cde10111af0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4ceb4bb4_dd33064e",
"filename": "specs/2024.1/l3bgp-peer-connect-mode.rst",
"patchSetId": 1
},
"lineNbr": 46,
"author": {
"id": 13252
},
"writtenOn": "2023-11-20T07:04:00Z",
"side": 1,
"message": "This feature has been requested earlier and I think it is a valid topic, although it can be difficult to solve, in particular when there are additional networking layers involved, like the agent running in a container.\n\nThis is also somewhat related to a different common feature request asking for a possibility to query the status of a BGP session, both to verify operation and to aid in debugging.",
"parentUuid": "779ad168_61306e7b",
"range": {
"startLine": 45,
"startChar": 5,
"endLine": 46,
"endChar": 15
},
"revId": "33f1231954f739b6105ce35bca96cde10111af0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -232,6 +256,24 @@
"revId": "33f1231954f739b6105ce35bca96cde10111af0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "721d9140_e8cef325",
"filename": "specs/2024.1/l3bgp-peer-connect-mode.rst",
"patchSetId": 1
},
"lineNbr": 63,
"author": {
"id": 13252
},
"writtenOn": "2023-11-20T07:04:00Z",
"side": 1,
"message": "I think this is still a valid point, it may make sense to set this option per BGP speaker or even per peer?\n\nIf you argue that operator interaction is needed anyway, then you could say that all of the n-d-r API is not needed and should be replaced by static configuration.",
"parentUuid": "77998aa4_a837ca6f",
"revId": "33f1231954f739b6105ce35bca96cde10111af0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {