Update patch set 7

Patch Set 7:

(2 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
This commit is contained in:
Gerrit User 16688
2022-11-07 12:33:59 +00:00
committed by Gerrit Code Review
parent 3db70fc33b
commit 6e708edfdb

View File

@@ -289,6 +289,24 @@
"revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "217bf906_b20c05df",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
"patchSetId": 6
},
"lineNbr": 165,
"author": {
"id": 16688
},
"writtenOn": "2022-11-07T12:33:59Z",
"side": 1,
"message": "Nova doesn\u0027t do this for an existing port, Neutron does.",
"parentUuid": "676e4dd7_b58a9a08",
"revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@@ -305,6 +323,24 @@
"message": "i think your are mixing ups how placemnt is ment to work\n\ninventories track total avalaibel capastyity and have a reserved value.\nthe reserved value tracks capatiy that is reserved for non openstack usage.\n\nthe consumtion of the resouces i.e. the usage is compute form the allcoations against the inventoies.\n\nso how this need to work is the reshape api need to be used to reshape the allocation when this feature is enabled.\n\nthat reshape will likely need to be done by nova.\nit may be possibel to do it form neutron but we need to ensure that nova will generate the same allocations if we migrate or run the heall allcoations comand.",
"revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "11840e74_ce293de3",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
"patchSetId": 6
},
"lineNbr": 180,
"author": {
"id": 16688
},
"writtenOn": "2022-11-07T12:33:59Z",
"side": 1,
"message": "I never mentioned \"reserved\" value. I\u0027m talking about the \"used\" value. If we send a request to update the \"used\" value beyond the \"total\" value, that request will fail. This is what I\u0027ll log.\n\nWhat I\u0027m saying here is that once this feature is enabled, we\u0027ll need to recalculate the RP inventories for existing ports, and only if those ports have QoS policies with min-bw rules. In OVS this is not possible now for ports in overlay networks. OVN feature is too recent and most probably won\u0027t hit too many occurrences.\n\nWhy from Nova? Nova does not store this information. Nova is just a proxy for Placement. I don\u0027t see why Nova should handle this.",
"parentUuid": "1c7908f5_a5c4455e",
"revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}