openstack/neutron-vpnaas
Code Issues Proposed changes

Update patch set 34

Browse Source 
Patch Set 34:

(1 comment)

Patch-set: 34
Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8313\u003e replied on the change"}
This commit is contained in:
Gerrit User 8313 2023-11-09 13:53:27 +00:00 committed by Gerrit Code Review
parent bb5b8aa702
commit 084459fbfd
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
8815e6e3917e45fdfdc6077aed740da2e1c8d1f5
View File

@ -33,6 +33,23 @@
"message": "I\u0027m not VPNaaS expert but looking just at the python code it looks good for me. It also passed the gate and was already reviewed (and tested in production even AFAIK) by some operators so LGTM for me.",
"revId": "8815e6e3917e45fdfdc6077aed740da2e1c8d1f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "67e4e460_a9c0c6fb",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 34
},
"lineNbr": 0,
"author": {
"id": 8313
},
"writtenOn": "2023-11-09T13:53:27Z",
"side": 1,
"message": "I can\u0027t start it in devstack, and it fails on db migration:\nsqlalchemy.exc.ProgrammingError: (pymysql.err.ProgrammingError) (1146, \"Table \u0027neutron.cisco_csr_identifier_map\u0027 doesn\u0027t exist\")\n\nI suppose it is related to https://review.opendev.org/c/openstack/neutron/+/897472",
"revId": "8815e6e3917e45fdfdc6077aed740da2e1c8d1f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}