openstack/neutron
Code Issues Proposed changes

Python3: do not use '+' on dict_items objects

Browse Source 
In Python 3, dict.items() returns an iterator. Iterators cannot be added.

Blueprint: neutron-python3
Change-Id: I487178ebceae9946cb53dea1e847d7715f4577f3
This commit is contained in:
Cyril Roelandt 2015-06-19 13:24:34 +00:00
parent 4d35f15265
commit 4f5171d2ce
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
neutron/extensions/securitygroup.py
View File

@ -326,8 +326,8 @@ class Securitygroup(extensions.ExtensionDescriptor):
def get_extended_resources(self, version):
if version == "2.0":
return dict(EXTENDED_ATTRIBUTES_2_0.items() +
RESOURCE_ATTRIBUTE_MAP.items())
return dict(list(EXTENDED_ATTRIBUTES_2_0.items()) +
list(RESOURCE_ATTRIBUTE_MAP.items()))
else:
return {}

2
neutron/tests/unit/agent/linux/test_iptables_firewall.py
View File

@ -1672,7 +1672,7 @@ class IptablesFirewallEnhancedIpsetTestCase(BaseIptablesFirewallTestCase):
rules = self.firewall._expand_sg_rule_with_remote_ips(
rule, port, 'ingress')
self.assertEqual(list(rules),
[dict(rule.items() +
[dict(list(rule.items()) +
[('source_ip_prefix', '%s/32' % ip)])
for ip in other_ips])