fix bug lp:1025526,update iniparser.py to accept empty value.

also,this patch turn off pep8 E125 check,this for now seems to
be unnecessary,it check continuous line split.and update the
latest openstack-common https://review.openstack.org/#/c/9201
which has fix pep8 1.3 issue except for E125 check.

Change-Id: I86e6a3add56a0a2941031a1248f1696667ac56b8

quantum/openstack/common/iniparser.py

@@ -53,7 +53,8 @@ class BaseParser(object):
             key, value = line[:colon], line[colon + 1:]
 
         value = value.strip()
-        if value[0] == value[-1] and value[0] == "\"" or value[0] == "'":
+        if ((value and value[0] == value[-1]) and
+            (value[0] == "\"" or value[0] == "'")):
             value = value[1:-1]
         return key.strip(), [value]
 

quantum/openstack/common/log.py

@@ -208,9 +208,9 @@ class JSONFormatter(logging.Formatter):
     def formatException(self, ei, strip_newlines=True):
         lines = traceback.format_exception(*ei)
         if strip_newlines:
-            lines = [itertools.ifilter(lambda x: x,
-                                      line.rstrip().splitlines())
-                    for line in lines]
+            lines = [itertools.ifilter(
+                lambda x: x,
+                line.rstrip().splitlines()) for line in lines]
             lines = list(itertools.chain(*lines))
         return lines
 

quantum/openstack/common/notifier/list_notifier.py

@@ -19,7 +19,8 @@ from quantum.openstack.common import importutils
 from quantum.openstack.common import log as logging
 
 
-list_notifier_drivers_opt = cfg.MultiStrOpt('list_notifier_drivers',
+list_notifier_drivers_opt = cfg.MultiStrOpt(
+    'list_notifier_drivers',
     default=['quantum.openstack.common.notifier.no_op_notifier'],
     help='List of drivers to send notifications')
 

quantum/openstack/common/notifier/rabbit_notifier.py

@@ -22,8 +22,8 @@ from quantum.openstack.common import rpc
 
 LOG = logging.getLogger(__name__)
 
-notification_topic_opt = cfg.ListOpt('notification_topics',
-        default=['notifications', ],
+notification_topic_opt = cfg.ListOpt(
+    'notification_topics', default=['notifications', ],
     help='AMQP topic used for openstack notifications')
 
 CONF = cfg.CONF

run_tests.sh

@@ -98,13 +98,9 @@ function run_pep8 {
   echo "Running pep8 ..."
 
   PEP8_EXCLUDE="vcsversion.py,*.pyc"
-  # TODO(gongysh) we should pep8 check openstack common files. But that project does
-  # not stick to latest pep8 version. Therefore we exclude these common files here.
-  # Pep8 does not support exclude in the format quantum/openstack/common,
-  # so I have to exclude some of openstack common files one by one. This also applies
-  # to tox.ini.
-  PEP8_EXCLUDE="$PEP8_EXCLUDE,log.py,notifier,rpc"
-  PEP8_OPTIONS="--exclude=$PEP8_EXCLUDE --repeat --show-source"
+  # we now turn off pep8 1.3 E125 check to avoid make change to 
+  # openstack-common . 
+  PEP8_OPTIONS="--exclude=$PEP8_EXCLUDE --ignore=E125 --repeat --show-source"
   PEP8_INCLUDE="bin/* quantum run_tests.py setup*.py"
   ${wrapper} pep8 $PEP8_OPTIONS $PEP8_INCLUDE
 }

tox.ini

@@ -21,7 +21,7 @@ downloadcache = ~/cache/pip
 [testenv:pep8]
 deps = pep8
        setuptools_git>=0.4
-commands = pep8 --repeat --show-source --exclude=.venv,.tox,dist,doc,*egg,log.py,notifier,rpc .
+commands = pep8 --repeat --show-source --ignore=E125 --exclude=.venv,.tox,dist,doc,*egg .
 
 [testenv:cover]
 setenv = NOSE_WITH_COVERAGE=1