openstack/neutron
Code Issues Proposed changes

[FT] Add wait event for Port_Binding in Metadata tests

Browse Source 
A new "Port_Binding" event wait is added to the following tests cases:
* TestMetadataAgent.test_metadata_not_provisioned_on_foreign_additional_chassis_change
* TestMetadataAgent.test_metadata_port_binding_column_updated

Before updating again the "Port_Binding" register and check that
the ``provision_datapath`` method has not being called, the tests need
to ensure that the "Port_Binding" event has been received first.

Closes-Bug: #2122110
Signed-off-by: Rodolfo Alonso Hernandez <ralonsoh@redhat.com>
Change-Id: I882a063831933108cd38e76f9cf32ffdf91dd9ec
This commit is contained in:
Rodolfo Alonso Hernandez
2025-09-05 11:20:00 +00:00
parent 84f606a9bc
commit 660b9f80bd
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
neutron/tests/functional/agent/ovn/metadata/test_metadata_agent.py
View File

@@ -63,16 +63,12 @@ class MetadataAgentHealthEvent(event.WaitEvent):
ovn_const.OVN_AGENT_METADATA_SB_CFG_KEY, 0)) >= self.sb_cfg
class MetadataPortCreateEvent(event.WaitEvent):
event_name = 'MetadataPortCreateEvent'
def __init__(self, metadata_port, timeout=5):
class PortBindingUpdateEvent(event.WaitEvent):
def __init__(self, lsp, timeout=5):
table = 'Port_Binding'
events = (self.ROW_CREATE,)
conditions = (('logical_port', '=', metadata_port),)
super().__init__(
events, table, conditions, timeout=timeout
)
events = (self.ROW_UPDATE,)
conditions = (('logical_port', '=', lsp),)
super().__init__(events, table, conditions, timeout=timeout)
class TestMetadataAgent(base.TestOVNFunctionalBase):
@@ -494,9 +490,12 @@ class TestMetadataAgent(base.TestOVNFunctionalBase):
lswitchport_name, lswitch_name = self._create_logical_switch_port()
pb_event = PortBindingUpdateEvent(lswitchport_name)
self.agent.sb_idl.idl.notify_handler.watch_event(pb_event)
self.sb_api.lsp_bind(
lswitchport_name, agent_chassis.name).execute(
check_error=True, log_errors=True)
self.assertTrue(pb_event.wait())
pb = idlutils.row_by_value(
self.sb_api, 'Port_Binding', 'logical_port', lswitchport_name)
@@ -670,9 +669,12 @@ class TestMetadataAgent(base.TestOVNFunctionalBase):
lswitchport_name, lswitch_name = self._create_logical_switch_port()
pb_event = PortBindingUpdateEvent(lswitchport_name)
self.agent.sb_idl.idl.notify_handler.watch_event(pb_event)
self.sb_api.lsp_bind(
lswitchport_name, agent_chassis.name).execute(
check_error=True, log_errors=True)
self.assertTrue(pb_event.wait())
pb = idlutils.row_by_value(
self.sb_api, 'Port_Binding', 'logical_port', lswitchport_name)