openstack/neutron
Code Issues Proposed changes

Merge "Code review policy - add note about approving mechanical changes"

Browse Source
This commit is contained in:
Zuul 2019-10-03 08:51:33 +00:00 committed by Gerrit Code Review
commit 92f7484d2a
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
doc/source/contributor/policies/code-reviews.rst
View File

@ -95,6 +95,11 @@ In addition to that, the following rules are to follow:
ensure that correct HTTP error is returned when wrong data is provided, ensure that correct HTTP error is returned when wrong data is provided,
will be added where it is appropriate. will be added where it is appropriate.
* It is usually enough for any "mechanical" changes, like e.g. translation
imports or imports of updated CI templates, to have only one +2 Code-Review
vote to be approved. If there is any uncertainty about a specific patch, it is
better to wait for review from another core reviewer before approving the patch.
.. _spec-review-practices: .. _spec-review-practices:
Neutron Spec Review Practices Neutron Spec Review Practices