18679 Commits

Author SHA1 Message Date
Jenkins
16d16206c9 Merge "Using constants in local" 2017-06-22 07:11:43 +00:00
Jenkins
39fc8522bc Merge "Fix bug when checking duplicated subnets for router interface" 2017-06-22 07:08:29 +00:00
Jenkins
6077d778e9 Merge "dvr: Move normal/output br-int flows to table TRANSIENT" 2017-06-22 07:08:12 +00:00
Jenkins
4f8128c8bc Merge "security group: pass update value to precommit_update" 2017-06-22 06:42:31 +00:00
Jenkins
dd52e9fbb8 Merge "Revert "Change list of available qos rules"" 2017-06-22 00:21:04 +00:00
Brian Haley
bd9fc827c6 Fix some tempest deprecation warnings
Saw this recently in a tempest test run:

    DeprecationWarning: Read-only property 'manager'
    has moved to 'os_primary' in version 'Pike' and
    will be removed in version 'Queens'

Tempest BaseTestCase class credential names have changed
from manager->os_primary, admin->os_admin, and
alt_manager->os_alt, so we should start using them.

Closes-bug: #1697588
Change-Id: I44de8046fc983bf6780c310e8db174a5902c2826
2017-06-21 15:46:30 +00:00
Isaku Yamahata
154b8750bc security group: pass update value to precommit_update
This patch is follow up for [1].
When updating security group, pass updated value to precommit.
old value is passed as original_security_group and new value
is passed as security_group.
[1] https://review.openstack.org/#/c/448420/

Although argument to callbacks will be unified by EventPayload
eventually, it's necessary to unbreak decomposed modules.

Change-Id: I5a27d1d218a0be4fae6f9740559bbbf773518821
Related-bug: #1546910
2017-06-20 22:21:23 -07:00
Jenkins
05c22d6199 Merge "Fix race between create subnet and port requests" 2017-06-21 03:36:31 +00:00
Jenkins
ccd7dadec5 Merge "Updated from global requirements" 2017-06-21 03:06:42 +00:00
Jenkins
5449e44587 Merge "DVR: Add forwarding routes based on address_scopes" 2017-06-21 03:06:15 +00:00
Dongcan Ye
3b461d4402 Using constants in local
In l3_db, we had already defined DEVICE_OWNER_ROUTER_GW from
neutron_lib, we can avoid import that module again.

TrivialFix

Change-Id: I7e7339e7f8d4201d3ca50cf24d08ee965ec099a0
2017-06-21 10:07:50 +08:00
Jenkins
9d9ae5af4a Merge "functional: Don't write strings to pipe" 2017-06-21 01:47:13 +00:00
Dongcan Ye
0415f4f50c Fix bug when checking duplicated subnets for router interface
If user set gateway for router first, and gateway subnet
overlapped with tenant subnet, will cause add router interface
to fail.

Add router interface checking for duplicated subnets should
ingore the gateway network.

This patch also filters gateway network when creating gw port.

Change-Id: Idcc8be221656ace13b12b62f559e4cb9a6af4f32
Closes-Bug: #1697410
2017-06-21 09:03:26 +08:00
Jenkins
f855f209a7 Merge "OVO: Allow port queries based on security_group_ids" 2017-06-21 00:38:38 +00:00
Jenkins
ff56e45406 Merge "Add missing info about supported ingress bandwidth limit rule" 2017-06-20 23:28:06 +00:00
Jenkins
adfcf111d1 Merge "TC doesn't rise exception if device doesn't exist" 2017-06-20 21:30:36 +00:00
Jenkins
1559763663 Merge "python3: use binary mode to open file in test" 2017-06-20 21:30:21 +00:00
Sławek Kapłoński
98f4362469 Add missing info about supported ingress bandwidth limit rule
Add missing information that Openvswitch agent supports now
both ingress and egress direction for QoS bandwidth limit rule.

Support for ingress bandwidth limit was added in
I9d94e27db5d574b61061689dc99f12f095625ca0

TrivialFix

Change-Id: I70058d1d8f16c58e41dab08fc66d5d3f5fcefa4b
2017-06-20 21:07:10 +00:00
Jakub Libosvar
0c8dd7447a functional: Don't write strings to pipe
Python 3 doesn't support writing strings to descriptors. Write bytes
instead.

Change-Id: Ie732d00acc67c429d9f714bcfc116554fb523d36
2017-06-20 18:02:45 +00:00
Jenkins
c3e86bafdb Merge "Fix SG callbacks notification" 2017-06-20 17:56:31 +00:00
Bernard Cafarelli
033ab6cc17 python3: use binary mode to open file in test
With text mode, trying to write a binary string generates a TypeError in
python 3

Change-Id: I1b7d1a46d98814aacb4bf9a7f80b168c2b786e30
2017-06-20 17:20:56 +00:00
Jenkins
0962b6e76e Merge "use six.u rather than unicode for py3 compat" 2017-06-20 17:03:29 +00:00
Jenkins
ef1e24e05d Merge "tempest: Make _create_router_with_client obey enable_snat=False" 2017-06-20 16:18:01 +00:00
Jenkins
9f3a4c9de2 Merge "Clean up test cases in test_iptables_firewall.py" 2017-06-20 14:52:41 +00:00
Jakub Libosvar
ce8a0b2b7d dvr: Move normal/output br-int flows to table TRANSIENT
DVR flows are not compatible with OVS firewall flows as firewall flows
have higher priority. As a consequence, rules for DVR were never match
as firewall uses output directly.

This patch replaces flows using normal or output actions and resends
packets to TRANSIENT table instead. This transient table then uses
either those normal or output action rules. With this split, we will be
able to match egress/ingress flows in TRANSIENT table instead of
LOCAL_SWITCHING putting DVR pipeline in front of OVS firewall pipeline.

Change-Id: I9f738047f131b42d11a90f539435006d16ea7883
Closes-bug: #1696983
2017-06-20 14:23:49 +00:00
Jenkins
92f9c21d03 Merge "Fix linuxbridge ebtables locking" 2017-06-20 12:23:35 +00:00
OpenStack Proposal Bot
8856a761a2 Updated from global requirements
Change-Id: I218dbc85d829e96fb94cf840c910980c764ed454
2017-06-20 11:47:04 +00:00
Kevin Benton
1db5ace55e OVO: Allow port queries based on security_group_ids
This is needed to retrieve all ports in a given set of
security groups.

Partially-Implements: blueprint push-notifications
Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
Change-Id: Iffa1bd341d9d20277ec153aa1dac6f61f05ec5bd
2017-06-20 08:33:22 +00:00
Jenkins
8c8ae29082 Merge "DHCP Agent: Separate local from non-local subnets" 2017-06-20 06:52:27 +00:00
Jenkins
97b97739fe Merge "DHCP RPC: Separate local from non-local subnets" 2017-06-20 06:37:12 +00:00
Cao Xuan Hoang
ee20757720 Clean up test cases in test_iptables_firewall.py
The protocol arg is called but never used.

Change-Id: Idff3ff67ed21c9bf36b0b01b098ad4411e12fdd7
2017-06-20 11:53:07 +07:00
YAMAMOTO Takashi
bd998d111e tempest: Make _create_router_with_client obey enable_snat=False
Found while working on I4452d61ee6e9d21add3d37ec39301efcbd3bd66d

Closes-Bug: #1699006
Change-Id: Ideb3e57b068dce150e333fde66f7ad488c2b515d
2017-06-20 12:50:27 +09:00
YAMAMOTO Takashi
05293965f1 Fix SG callbacks notification
Fix a regression from the recent change. [1]

[1] I6f49f25eb2ad16221357024f45a6bb6175d5cd55

Closes-Bug: #1698812
Change-Id: Ifef2561ef4ff2a44068fc008475b216fdabe7095
2017-06-20 11:39:52 +09:00
Jenkins
c4fd0317a3 Merge "Linuxbridge agent: detect existing IP on bridge" 2017-06-19 21:54:56 +00:00
Jenkins
6af12de193 Merge "Store segmentation_id during segment create" 2017-06-19 21:53:32 +00:00
Jenkins
e54b2e4a3e Merge "Stop binding attempts when network has no segments" 2017-06-19 21:42:57 +00:00
Miguel Lavalle
802cf11942 Fix race between create subnet and port requests
When creating an IPv6 auto-address subnet for a network, ports can be
created or updated concurrently in the same network, before the subnet
creation concludes. In such a situation, an IpAddressAlreadyAllocated
exception may be raised, because the subnet create request attempts to
allocate auto addresses to the concurrently created or updated ports,
which have been already allocated by the port requests.

This patchset adds code to the IPAM to skip the attempt to assign the
auto address to ports if they already have received them.

Change-Id: If1eb4046865f43b15ba97c52e2d0b9343dc72c19
Closes-Bug: #1655567
2017-06-19 14:03:48 -05:00
Boden R
01aab63fc3 use six.u rather than unicode for py3 compat
In Python 3 str is unicode by default and hence there is no unicode
global function. This switches our use of it to to six.u() which handles
the py2/py3 difference under the covers.

Change-Id: I3cfff2fe8e07e2a9ed8b89c93d24351b1f440b00
2017-06-19 11:24:18 -06:00
Harald Jensas
d2b82168cd DHCP Agent: Separate local from non-local subnets
In order to allow the DHCP agent to service other subnets on the
network in other segments via DHCP relay, we need to use the
'non_local_subnets' network attribute returned by rpc to set up dhcp
for off-link subnets.

Change-Id: I88e1c574bc429dc599ad7c956c03fa0688338186
Closes-Bug: 1692486
2017-06-19 16:11:48 +00:00
Kevin Benton
4dc81f0a53 DHCP RPC: Separate local from non-local subnets
In order to allow the DHCP agent to service other subnets
on the network in other segments via DHCP relay, we need to
return all subnets regardless of segment association.

However, this behavior will break older DHCP agents that
then try to get IPs on the subnets belonging to other segments.
This patch adds a new subnet attribute, 'non_local_subnets'
that will be returned in the DHCP RPC calls, so that agents
that can deal with off-link subnets can handle them
accordingly.

Change-Id: I9cce7b8a19c1201435df0c6baac7be57c57847e6
Partial-Bug: #1692486
2017-06-19 12:06:58 -04:00
Jenkins
c9a9b5d41a Merge "Fixes import_modules_recursively for Windows" 2017-06-19 13:56:28 +00:00
Jenkins
7cb56a1628 Merge "Pass the complete info in sg/rules db into PRECOMMIT_XXX callback" 2017-06-19 08:24:09 +00:00
Miguel Lavalle
323c29fd05 Store segmentation_id during segment create
The segmentation_id of a new segment is assigned by the
_handle_segment_change callback in the ML2 plugin, which is executed
after the segment was created, before commiting it to the DB. This
patchset adds code to update the newly created segment with the
segmentation_id assigned by the callback.

Change-Id: I493278a0bf5a3a0aadad10e5bee546d83b949fdc
Closes-Bug: #1698596
2017-06-18 17:47:00 -05:00
Jenkins
ab0dba40d1 Merge "docs: Fix indent level" 2017-06-17 10:11:01 +00:00
Jenkins
baa4ac9151 Merge "docs: reorganize developer reference for new theme" 2017-06-17 10:10:45 +00:00
Jenkins
f89a2467d8 Merge "docs: switch to openstackdocstheme" 2017-06-17 10:10:30 +00:00
Jenkins
2cdb1fc1fd Merge "Add a missing _LW()" 2017-06-17 09:22:53 +00:00
Jenkins
37e9999c8f Merge "Remove unreachable code in OVS mech driver" 2017-06-17 09:17:50 +00:00
Jenkins
1f27539c04 Merge "Add "default" behaviour to QoS policies documentation" 2017-06-17 08:03:53 +00:00
Kevin Benton
781b8f4149 Stop binding attempts when network has no segments
There is no point in retrying binding if the network has no
segments to bind to. This occurs during normal operations when
a network is being quickly created/deleted and the DHCP port
gets created during the network deletion.

By skipping binding we avoid misleading error messages and
wasted CPU cycles.

Closes-Bug: #1696010
Change-Id: I0b987ab7c3f65c1d860064a1b437b92a1dc1cb81
2017-06-17 00:15:22 -07:00