21141 Commits

Author SHA1 Message Date
Matt Riedemann
a98766d758 Revert "Add openstack/placement as a required project for neutron-grenade*"
This reverts commit 0014c0c3734e8d344e4a45e127fbd0c86dcfaf3c.

This is handled generically now with this change and its dependency:

  https://review.openstack.org/#/c/606853/

Change-Id: I360211cf60afb5611fb9e77fe6332fa59159708f
2018-10-24 08:46:21 -04:00
Zuul
83dffac498 Merge "use payloads for SUBNET BEFORE_DELETE events" 2018-10-24 10:16:15 +00:00
Zuul
0fdec013de Merge "supported_vnic_type configurable for ovs" 2018-10-24 04:00:36 +00:00
Slawek Kaplonski
fb068f089c Increase tempest jobs timeout
For jobs like:
- neutron-tempest-iptables_hybrid
- neutron-tempest-linuxbridge
- neutron-tempest-dvr

Sometimes we hit timeouts which aren't related
directly to Neutron.

As was decided on Neutron CI meeting [1], lets try
to increase jobs' timeout to 3h and check if that
will help to stabilize those jobs.

[1] http://eavesdrop.openstack.org/meetings/neutron_ci/2018/neutron_ci.2018-10-23-16.00.log.html#l-121

Change-Id: I24d694ba57aa3ff49f8c118486265925f1b4a611
2018-10-23 23:23:45 +02:00
Zuul
aa0540a87b Merge "Fix flake8 N534 untranslated exception message" 2018-10-23 16:20:52 +00:00
Zuul
671b45516f Merge "Add a request validator for SNAT logging" 2018-10-23 07:39:29 +00:00
Rodolfo Alonso Hernandez
ea63c6ae40 Use NetworkRBAC OVO in neutron/db/external_net_db.py
Migrate to use NetworkRBAC OVO in External_net_db_mixin.

Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
Change-Id: I083a611d73bb82d0e28b4d2b2cf8a667670a850b
2018-10-23 06:52:48 +01:00
Rodolfo Alonso Hernandez
00c816de01 Use NetworkRBAC OVO in neutron/db/db_base_plugin_v2.py
Migrate to use NetworkRBAC OVO in NeutronDBPluginV2.

Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
Change-Id: I202318b4a4b91d03177d5e9792565e9daa44f9fb
2018-10-23 06:50:24 +01:00
Zuul
66f0a4d189 Merge "Make port binding attempt after agent is revived" 2018-10-23 01:37:23 +00:00
Zuul
e03f2d95ae Merge "Add both directions for minimum bw rule in doc" 2018-10-22 23:34:54 +00:00
Zuul
696fcfe89a Merge "Introduce L3 agent extension for SNAT logging" 2018-10-22 23:16:14 +00:00
Zuul
191b3705f5 Merge "neutron.conf needs lock_path set for router to operate This change is adding required configuration in neutron.conf to set the lock_path parameter, which was missing in compute-install-ubuntu.rst" 2018-10-22 22:53:46 +00:00
Slawek Kaplonski
c39afbd5fc [Functional] Increase test_timeout for db migration tests
Patch [1] increased timeouts for test_walk_version functional tests
for MySQL backend to 300 seconds to avoid failures due to timeouts.

Unfortunately it looks that on nodes from some cloud providers used
in the gate and with number of migration scripts which we have in
Neutron those tests can take sometimes even around 400 seconds.

So lets increase this to 600 seconds to avoid such failures of
functional tests job.

[1] https://review.openstack.org/#/c/610003/

Change-Id: I9d129f0e90a072ec980aadabb2c6b812c08e1618
Closes-Bug: #1687027
2018-10-22 22:58:48 +02:00
Zuul
5273f85eec Merge "ovs-agent: Report resource info in heartbeat" 2018-10-22 20:03:06 +00:00
Slawek Kaplonski
f787f12aa3 Make port binding attempt after agent is revived
In some cases it may happen that port is "binding_failed"
because L2 agent running on destination host was down but
this is "temporary" issue.
It is like that for example in case when using L3 HA and when
master and backup network nodes were e.g. rebooted.
L3 agent might start running before L2 agent on host in such case
and if it's new master node, router ports will have "binding_failed"
state.

When agent sends heartbeat and is getting back to live,
ML2 plugin will try to bind all ports with "binding_failed"
from this host.

Change-Id: I3bedb7c22312884cc28aa78aa0f8fbe418f97090
Closes-Bug: #1794809
2018-10-22 18:43:33 +02:00
Boden R
a69d92e0e8 use payloads for SUBNET BEFORE_DELETE events
This patch switches over to the payload style of callbacks for the
BEFORE_DELETE events of SUBNET resources.

NeutronLibImpact

Change-Id: I08998302319f433b5f210e7c9db359d3142dcb67
2018-10-22 08:25:15 -06:00
Zuul
cf4992cab7 Merge "use payloads for NETWORK BEFORE_DELETE events" 2018-10-22 12:41:57 +00:00
Zuul
bc4145ed50 Merge "Introduce Port resource request extension" 2018-10-22 12:25:28 +00:00
Zuul
b9df2d068d Merge "Enable ingress direction for min_bw rule" 2018-10-22 12:08:28 +00:00
Zuul
a35bbeea52 Merge "Fix dvr ha router gateway goes wrong host" 2018-10-22 10:29:24 +00:00
SapanaJadhav
f4d438019e neutron.conf needs lock_path set for router to operate
This change is adding required configuration in neutron.conf
to set the lock_path parameter, which was missing in
compute-install-ubuntu.rst

Change-Id: If090bdf060dfe21d11b1a5dfd010dc8167d9e45e
Closes-Bug: #1796976
2018-10-21 22:00:50 +05:30
Zuul
8790832da1 Merge "Allow update request with current segment_id" 2018-10-20 02:07:18 +00:00
Zuul
84d8949da3 Merge "use ovo for L3HARouterAgentPortBinding in l3_hamode." 2018-10-19 23:10:21 +00:00
Brian Haley
fc95db987d Fix flake8 N534 untranslated exception message
Fix N534 untranslated exception message warnings and
enable enforcement.

Trivialfix

Change-Id: I9e2b51c768cbb6fcf5588070d1b9e9835775b374
2018-10-19 15:46:04 -04:00
Zuul
bd4ab0a631 Merge "Add Network RBAC functional tests for External_net_db_mixin" 2018-10-19 08:34:37 +00:00
LIU Yulong
1973a037c2 Fix dvr ha router gateway goes wrong host
During L3 agent restart, the dvr ha router gateway port
binding host may change because the multiple ha router
scheduled hosts.

After this patch, we return the 'master' ha binding host
directly during the gateway port create. And do not let
the original 'master' (current is backup) host override
the gateway port binding host.

Closes-Bug: #1793529
Change-Id: Icb2112c7f0bd42c4f4b1cf32d6b83b6d97f85ef7
2018-10-19 12:12:54 +08:00
Zuul
f253d676b8 Merge "DVR-HA: Configure extra routes on router namespace in dvr_snat node" 2018-10-18 17:47:57 +00:00
Rodolfo Alonso Hernandez
975953f69e Add Network RBAC functional tests for External_net_db_mixin
These tests will ensure the code quality during the migration to
NetworkRBAC OVO in External_net_db_mixin.

Change-Id: I8c7390e31709c25345d96bfe49795ac0f66d9b4d
Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
2018-10-18 07:23:43 +00:00
Nguyen Phuong An
50c75e9e51 Add a request validator for SNAT logging
A log request for SNAT resource should specify resource_type='snat'
and resource_id=router_id. So this patch adds a validation method for
the incoming log request.

Co-Authored-By: Kim Bao Long <longkb@vn.fujitsu.com>
Change-Id: I4fff5a9c8877d192aab780eed9be90452711fb3d
Partial-Bug: #1752290
2018-10-18 10:43:38 +07:00
Zuul
591cbff803 Merge "Fix enable_distributed_routing option section in docs" 2018-10-18 01:16:58 +00:00
Zuul
5f36615700 Merge "use retry_if_session_inactive from neutron-lib" 2018-10-17 19:50:51 +00:00
Zuul
ee5fb8744c Merge "[Functional] Increase test_timeout for db migration tests" 2018-10-17 14:58:45 +00:00
Lajos Katona
eb4221e6f0 Introduce Port resource request extension
The resources needed by a port are expressed to nova via
resource_request extending the port.
If the port requested by nova boot has resource_request attribute, that
means that placement must enforce the minimum bandwidth requirements.

Change-Id: I82afa56fa784fc43fefd1ce494bff649f51ad1c8
Depends-On: https://review.openstack.org/584903
Partial-Bug: #1578989
See-Also: https://review.openstack.org/502306 (nova spec)
See-Also: https://review.openstack.org/508149 (neutron spec)
2018-10-17 07:34:36 +00:00
Lajos Katona
4df02ee93c Enable ingress direction for min_bw rule
Enable QoS minimum-bandwidth rule for ovs and sriov backends for both
ingress and egress directions.
Add qos-bw-limit-direction as supported extension to qos-plugin, and
add create/delete/update_minimum_bandwidth and
delete_minimum_bandwidth_ingress empty methods to sriov/ovs/linuxbridge
extension drivers.

Change-Id: I6eb21ccf0400ea9adae90ff0bf97e08cdb09b8eb
Depends-On: https://review.openstack.org/609368
Partial-Bug: #1578989
See-Also: https://review.openstack.org/502306 (nova spec)
See-Also: https://review.openstack.org/508149 (neutron spec)
2018-10-17 09:27:18 +02:00
junbo
b62ae3d522 Fix enable_distributed_routing option section in docs
The enable_distributed_routing option in the OVS-HA-DVR doc
is shown in the [DEFAULT] section in the openvswitch_agent.ini
file, but it is actually in the [agent] section.

Change-Id: Ic81a6da71f1935e863ec698c98441b64b41bbfa3
2018-10-17 13:13:38 +08:00
Nguyen Phuong An
6352b944a4 Introduce L3 agent extension for SNAT logging
This patch introduces SNAT logging extension for Neutron Packet Logging
framework.

Co-Authored-By: Kim Bao Long <longkb@vn.fujitsu.com>
Partial-Bug: #1752290
Change-Id: I882b8e75525f51ef8b5b032fc89843ae904844e7
2018-10-17 10:25:55 +07:00
Zuul
70d207d2fb Merge "Add permanent ARP entries for DVR fip/qrouter veth pair" 2018-10-16 17:30:19 +00:00
Boden R
c094da83cb use payloads for NETWORK BEFORE_DELETE events
This patch switches callbacks to use payloads for BEFORE_DELETE events
of NETWORK resources. To do so the DBEventPayload payload class is used
to encapsulate event data and the respective callback handles are
updated to use the payload kwarg.

NeutronLibImpact

Change-Id: I4843073799d4a2478a2583664d972c52457c695c
2018-10-16 06:58:32 -06:00
Zuul
94a5026fb5 Merge "Use l3plugin property in neutron/db/l3_dvr_db.py module" 2018-10-16 00:08:47 +00:00
Zuul
4cb7532160 Merge "Use tempest-pg-full" 2018-10-15 22:45:10 +00:00
Lajos Katona
a85c5ed3fb supported_vnic_type configurable for ovs
Now supported_vnic_types is hardcoded to the mechanism drivers, but that
can depend on several factors, like type of the NIC, admin decision,
etc.
With this patch we put the right to decide which vnic types are
supported for ovs agent into the hands of the admin, by allowing
blacklisting items from the mechanism driver specific list.
Background: http://eavesdrop.openstack.org/meetings/neutron_qos/2018/
neutron_qos.2018-07-31-15.00.log.html#l-58

Change-Id: I63e562e2eccc5b02c1c767d6a2c28cb803131e99
Partial-Bug: #1578989
See-Also: https://review.openstack.org/502306 (nova spec)
See-Also: https://review.openstack.org/508149 (neutron spec)
2018-10-15 20:35:49 +02:00
Slawek Kaplonski
2e43aae370 Use l3plugin property in neutron/db/l3_dvr_db.py module
Class DVRResourceOperationHandler has got property called
l3plugin which returns directory.get_plugin(plugin_constants.L3)
so there is no need to use directory.get_plugin(plugin_constants.L3)
in other places in this class.

TrivialFix

Change-Id: I6cc0fb4cd5edb798569dabe8f9c8696020e79008
2018-10-15 14:09:41 +02:00
Harald Jensås
3b5373b4ef Allow update request with current segment_id
If the segment_id in the update request equals the segment_id
already associated with the subnet being updated, there is no
need for further update related segment validations.

Closes-Bug: #1793391
Change-Id: I65cd5b92b219c14dd07ae72457af243756c4ed02
2018-10-13 17:14:59 +02:00
Zuul
c232f3686c Merge "Remove deprecated vsctl ovsdb_interface api" 2018-10-13 00:23:38 +00:00
Zuul
a2740beee1 Merge "Introduce functional testing for Network RBAC policies" 2018-10-12 23:36:18 +00:00
Slawek Kaplonski
c2c37272bf [Functional] Increase test_timeout for db migration tests
In Neutron we hit quite often same issue as Manila, see [1] for
details.
It looks that solution for this problem may be increase timeout
for test_walk_version functional tests.
Higher timeout will be applied for tests for both pgsql and mysql
backends but it is mostly needed for mysql because 'pymysql' works
much slower on slow nodes than 'psycopg2'

This patch adds also new decorator to set individual timeout for
tests.

[1] https://bugs.launchpad.net/manila/+bug/1501272

Change-Id: I5f344af6dc3e5a6ee5f52c250b6c719e1b43e02d
Closes-Bug: #1687027
2018-10-13 00:09:24 +02:00
Zuul
1697bc2c34 Merge "Ingress direction for min bandwidth rule" 2018-10-12 21:59:44 +00:00
Zuul
0f16c94c2b Merge "Delete tempest config module" 2018-10-12 21:48:19 +00:00
Boden R
6d9f1c662f use retry_if_session_inactive from neutron-lib
The retry_if_session_inactive decorator was rehomed into neutron-lib
[1]. This patch consumes it by removing the function from neutron and
using neutron-libs version where appropriate.

NeutronLibImpact

[1] https://review.openstack.org/#/c/557040/

Change-Id: I3e3289f33e62d45933d0fbf165bb4b25078f22d5
2018-10-12 14:47:35 -06:00
Sean McGinnis
ad50a7a453 Increment versioning with pbr instruction
With moving away from required milestone releases, the version numbers
calculated by PBR on the master branch will not work for those testing
upgrades from the last stable release. More details can be found in the
mailing list post here:

    http://lists.openstack.org/pipermail/openstack-dev/2018-October/135706.html

This is an empty commit that will cause PBR to increment its calculated
version to get around this.

PBR will see the following which will cause it to increment the version:

Sem-Ver: feature

Please merge this patch as soon as possible to support those testing
upgrades.

Change-Id: Iafb8b8b7ad80040d7aacd06cd2a66055f0337069
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2018-10-12 13:10:12 -05:00