21141 Commits

Author SHA1 Message Date
Zuul
9fe694dc16 Merge "Allow Ipv6 addresses for nova_metadata_host" 2018-10-12 17:45:51 +00:00
Swaminathan Vasudevan
81652cd939 DVR-HA: Configure extra routes on router namespace in dvr_snat node
Extra routes are not configured on Router namespaces in dvr_snat
node with DVR-HA configuration.
This patch fixes the problem.

Change-Id: If620b23564479042aa6f58640bcd6705e5eb52cf
Closes-Bug: #1797037
2018-10-12 11:00:35 -04:00
Rodolfo Alonso Hernandez
7df684df0f Introduce functional testing for Network RBAC policies
These tests will ensure the quality of the code during the migration
to NetworkRBAC OVO in NeutronDBPluginV2.

Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
Change-Id: I4506421de487141de98deef0042fd0f9283321f1
2018-10-12 11:49:51 +01:00
Andreas Jaeger
ea2103d6db Use tempest-pg-full
The legacy job legacy-tempest-dsvm-neutron-pg-full is now named
tempest-pg-full - using the new tempest and Zuul v3 frameworks.

Change experimental job to use new job.

Change-Id: I40c93dbb863497173b097ba9112cbaf107d8232c
Depends-On: https://review.openstack.org/609530
2018-10-12 10:07:00 +02:00
Zuul
57a0181c35 Merge "Make grenade-multinode-dvr job voting again" 2018-10-12 05:56:53 +00:00
Zuul
a666c8ca30 Merge "Exclude fallback tunnel devices from netns cleanup" 2018-10-12 05:54:25 +00:00
Zuul
7dc80a9305 Merge "Modify the QoS doc in Neutron" 2018-10-12 01:49:18 +00:00
Zuul
a0bb528599 Merge "Replace openSUSE experimental check with newer version" 2018-10-12 01:49:15 +00:00
Manjeet Singh Bhatia
f3dfb82fe9 use ovo for L3HARouterAgentPortBinding in l3_hamode.
Change-Id: Ia212eba8c42d66289aa4b1e6988f410d5041e094
Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
2018-10-11 22:37:33 +00:00
Zuul
ccb8b43aa5 Merge "Make binding statement singular." 2018-10-11 22:10:04 +00:00
Brian Haley
cf37563c83 Remove deprecated vsctl ovsdb_interface api
This was deprecated in https://review.openstack.org/#/c/503070/
so remove all the vsctl-related code, leaving just the native
ovsdb api.

Also removed renamed ovs_vsctl_timeout value, which was changed
to ovsdb_timeout in https://review.openstack.org/#/c/518391/

Change-Id: I50dfcea3deb41df1bd01fd06b76522453a6ba50b
2018-10-11 14:59:34 -04:00
Slawek Kaplonski
9174e6d3d1 Delete tempest config module
Those config options are now defined in neutron_tempest_plugin
repo.

Change-Id: I3fe45820f0ab9d9ae1f010f6fecf1f71d0cb1749
2018-10-11 17:43:37 +02:00
Brian Haley
ac5815a110 Add permanent ARP entries for DVR fip/qrouter veth pair
Since we know the IP and MAC addresses of both sides of the
fip/qrouter namespace veth pair device, just add permanent
ARP entries for them.

Change-Id: I6193b00681dfb79222eedfd00c89620321ac1b4f
Related-Bug: #1791989
2018-10-11 13:44:26 +00:00
Zuul
20be9e74d6 Merge "netns_cleanup: Remove unused parameter from unplug_devices()" 2018-10-11 11:06:44 +00:00
Lajos Katona
277c1e77b2 ovs-agent: fullstack test resource info report
Change-Id: Ia36b05c835339fea8913103dffad1422a9aacaed
Partial-Bug: #1578989
See-Also: https://review.openstack.org/502306 (nova spec)
See-Also: https://review.openstack.org/508149 (neutron spec)
2018-10-11 09:17:28 +00:00
Bence Romsics
d7d433f729 sriov-agent: Report resource info in heartbeat
Example config for sriov-agent:

sriov_agent.ini:
[sriov_nic]
physical_device_mappings = physnet0:ens5,physnet0:ens6
resource_provider_bandwidths = ens5:100000:100000,ens6:100000:100000

Agent configurations now includes 'resource_provider_bandwidths' and
'resource_provider_inventory_defaults'.

Change-Id: I1af798d404ed94cd30da3f92734bea911bbc3ac7
Co-Authored-By: Lajos Katona <lajos.katona@ericsson.com>
Depends-On: https://review.openstack.org/577220
Partial-Bug: #1578989
See-Also: https://review.openstack.org/502306 (nova spec)
See-Also: https://review.openstack.org/508149 (neutron spec)
2018-10-11 11:15:06 +02:00
Bence Romsics
f352f9faaa ovs-agent: Report resource info in heartbeat
Example config for ovs-agent:

ml2_conf.ini:
[ovs]
bridge_mappings = physnet0:br-test
resource_provider_bandwidths = br-test:100000:100000

Agent configurations now includes 'resource_provider_bandwidths' and
'resource_provider_inventory_defaults'.

Change-Id: Ib197573e5cdb60ef0db4e7a771c3179bf9d5bb95
Co-Authored-By: Lajos Katona <lajos.katona@ericsson.com>
Depends-On: https://review.openstack.org/577220
Partial-Bug: #1578989
See-Also: https://review.openstack.org/502306 (nova spec)
See-Also: https://review.openstack.org/508149 (neutron spec)
2018-10-11 11:08:07 +02:00
Zuul
c9444141b6 Merge "Install centralized floating IP nat rules to all ha nodes" 2018-10-11 02:33:04 +00:00
aojeagarcia
85588ad38e Allow Ipv6 addresses for nova_metadata_host
Current logic didn't check if the nova_metadata_host is an IPv6 address
causing the proxy request to fail with an exception because the url is
not valid.

This patchs check if the nova_metadata_host is an IPv6 address and
create a valid url enclosing the IPv6 address with brackets

Closes-Bug: #1796593

Change-Id: Ibfebffcec2c8860237a1f151084de978a7863bd8
Signed-off-by: aojeagarcia <aojeagarcia@suse.com>
2018-10-11 02:07:05 +00:00
Zuul
647c329a56 Merge "Trigger router update only when gateway port IP changed" 2018-10-11 01:52:12 +00:00
yanpuqing
b785199010 Modify the QoS doc in Neutron
We need to accent that only different types rules can be combined
in QoS policy Edit.

Change-Id: Ib40124127aea5d374548fb9161674975b6b906e8
Closes-Bug: 1779052
2018-10-10 19:23:31 +00:00
Andreas Jaeger
97fdc0f50d Replace openSUSE experimental check with newer version
We're migrating now to openSUSE 15.0 (yes, 15.0 is newer than 42.3),
remove legacy job and replace with native Zuul v3 job running python3.

Change-Id: I40ac09e26deff2043aa2a903ac858685c4257318
Depends-On: https://review.openstack.org/609359
2018-10-10 17:59:53 +02:00
Slawek Kaplonski
f44e5bcfb2 Make grenade-multinode-dvr job voting again
This job was set to be non-voting and was removed from
gate queue in [1]
It looks that patch [2] which was merged to stable/rocky
recently fixed this issue and this job is working fine again,
so lets make it voting and gating again.

[1] https://review.openstack.org/#/c/602097/
[2] https://review.openstack.org/#/c/595490/

Change-Id: Ied3b7c439056134388b16742448cd1da7ece04cf
Related-Bug: #1791989
2018-10-10 16:50:55 +02:00
Lajos Katona
f849eba286 Add both directions for minimum bw rule in doc
Changed QoS backend/rule support table in devref documentation to show
that Minimum Bandwidth rule can support both Egress and Ingress
directions in case of placement based enforcement.
Added a new table to show which directions are supported for Minimum
Bandwidth rule by the network backends, and how that depends on the
enforcement type (dataplane or placement).

Change-Id: I97ab4815d134d306917a84a7b308b734d6db2dd2
Depends-On: https://review.openstack.org/580387
Partial-Bug: #1578989
See-Also: https://review.openstack.org/502306 (nova spec)
See-Also: https://review.openstack.org/508149 (neutron spec)
2018-10-10 16:39:28 +02:00
Daniel Alvarez
8e60531d11 Exclude fallback tunnel devices from netns cleanup
When a namespace gets created, if the fb_tunnels_only_for_init_net
sysctl configuration is set to 0, the fallback tunnels will be
automatically created if the corresponding tunnel is present
in the initial network namespace. Source [0].

This is being observed in some systems where namespaces are not
getting cleaned up due to the presence of such devices as
ip_lib.namespace_is_empty() is returning False.

This patch is adding such devices as per the kernel documentation
to the list of excluded devices by default.

[0] https://www.kernel.org/doc/Documentation/sysctl/net.txt

Closes-Bug: #1797084
Change-Id: I94415a0da5367e2d98d792a5eb4ba3919b838326
Signed-off-by: Daniel Alvarez <dalvarez@redhat.com>
2018-10-10 15:01:49 +02:00
Daniel Alvarez
f30fc92adf netns_cleanup: Remove unused parameter from unplug_devices()
A conf object was passed in to the unplug_devices method
which was not used. This patch is removing it and adapting the
tests to the new prototype.

Also, there's apparently no callers outside neutron that could
get broken as per codesearch.openstack.org.

Change-Id: Ie19b8e4056b1f27be3cae51e74759ebfed41074e
Signed-off-by: Daniel Alvarez <dalvarez@redhat.com>
2018-10-10 11:15:59 +02:00
Zuul
6918f4a237 Merge "doc: OpenVSwitch firewall internal design, improvements (+ newline fix)" 2018-10-10 01:37:49 +00:00
Zuul
7b6754e9d4 Merge "Fix ADMIN output examples" 2018-10-09 10:28:41 +00:00
Lajos Katona
360fde9f88 Ingress direction for min bandwidth rule
Add API extension for QoS minimum bw rule ingress direction.

Change-Id: I6747652df0372ab2ee480a97758501edba0f5b3f
Depends-On: https://review.openstack.org/580387
Partial-Bug: #1578989
See-Also: https://review.openstack.org/502306 (nova spec)
See-Also: https://review.openstack.org/508149 (neutron spec)
2018-10-09 08:08:05 +00:00
Zuul
8c05cd31ef Merge "Fix flake8 H404 errors" 2018-10-09 07:00:33 +00:00
tianhui
e1943d9711 Fix ADMIN output examples
Update the response of openstack server list

Change-Id: I08b1476b07c4623982f3faef972f89bc7c51a1f3
2018-10-08 06:11:20 +00:00
Zuul
f719d1f087 Merge "Remove population of is_filter keyword" 2018-10-06 15:33:56 +00:00
Zuul
5fc8bb59c5 Merge "fix tox python3 overrides" 2018-10-05 23:55:55 +00:00
Zuul
1663414a6b Merge "use payloads for AGENT BEFORE_DELETE callbacks" 2018-10-05 23:55:52 +00:00
Brian Haley
2b57f08576 Fix flake8 H404 errors
Fix H404 error and start enforcing it.

Trivialfix

Change-Id: Iaa6fb4f1f07dee32a944259ab65204360d9db7ea
2018-10-05 21:48:41 +00:00
LIU Yulong
ee7660f593 Install centralized floating IP nat rules to all ha nodes
For L3 DVR HA router, the centralized floating IP nat rules are not
installed in every HA node snat namespace. So, install the rules to
all the router snat-namespace on every scheduled HA router host.

Closes-Bug: #1793527
Change-Id: I08132510b3ed374a3f85146498f3624a103873d7
2018-10-06 02:40:52 +08:00
Zuul
3e579256a3 Merge "Upgrade pylint to a version that works with python3" 2018-10-05 17:14:15 +00:00
Zuul
41f6560dd6 Merge "Update tests neutron.conf to use transport_url" 2018-10-05 15:01:07 +00:00
Zuul
688914a247 Merge "Add argument to get ports by SG to allow excluding owners" 2018-10-05 06:11:34 +00:00
Zuul
5e104965a3 Merge "remove trailing comma for linter" 2018-10-05 00:53:46 +00:00
Zuul
22e8228dd4 Merge "Fix best_match() deprecation warning" 2018-10-04 23:33:23 +00:00
LIU Yulong
452b282412 Trigger router update only when gateway port IP changed
During the ha router state change event, the gateway port only
changed the L2 binding host. So l3 agent has the entire gateway
port information. It is not necessary to send a router_update
message to l3 agent again.

Closes-Bug: #1795127
Change-Id: Ia332421aff995f42e7a6e6e96b74be1338d54fe1
2018-10-05 04:16:34 +08:00
Doug Hellmann
1307cb7587 fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: I9530cd2433e0e34f05667d33bd6469b2592f8738
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-10-04 18:04:02 +00:00
Doug Hellmann
2530ccff8f Upgrade pylint to a version that works with python3
Also fixed some six.moves errors as well.

Change-Id: I9783ee588de1ec4b91a665b9dc89fdba3e2d90df
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-10-04 18:03:25 +00:00
Zuul
8056f2b386 Merge "Optimize OVS DVR CSNAT port code a little" 2018-10-04 16:52:33 +00:00
Zuul
875c55a66a Merge "Fix corner case in failure assigning MAC to SR-IOV NIC" 2018-10-04 16:52:30 +00:00
Hongbin Lu
4e3fb31919 Introduce floating IP pool resource
Add support for listing floating ip pools (subnets).
A new API resource ``floatingip-pools`` is introduced.
This API endpoint can return a list floating ip pools
which are essentially mappings between network UUIDs and
subnet CIDRs. Users can use this API to find out the pool
to create the floating IPs.

Related patches:
* neutron-lib: https://review.openstack.org/#/c/556674/
* tempest-plugin: https://review.openstack.org/#/c/562038/

APIImpact add floatingip pools api
Change-Id: Iaa995630645042520df67d95271e14f11ffcff8c
Partial-Bug: #1653932
2018-10-04 15:53:53 +00:00
Doug Hellmann
ebfed6090b remove trailing comma for linter
The linter sees the trailing comma after the function call as building
a tuple without wrapping it in parens. That doesn't seem to be the
intent (it looks like a typo), so remove the comma.

Change-Id: Ie3e051c43d68d09716fc0a4506ed111908730280
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-10-04 13:11:08 +00:00
Zuul
c4b16aa492 Merge "Add openstack/placement as a required project for neutron-grenade*" 2018-10-04 12:58:36 +00:00
Zuul
d8b09c576e Merge "Fix pep8 F402 import shadowing" 2018-10-04 12:58:34 +00:00