In test_dscp_marking_packets, sender vm is sending ICMP packets to the
receiver_vm.
Before this patch even if first ICMP packet wasn't send properly, test
failed due to exception raised in execute method.
It can happend sometimes that first packet will fail to be send as there
can be e.g. some configuration on agent's side not done yet. So we
should try to ping receiver_vm for 60 seconds instead of failing on
first attempt.
This patch changes that behaviour in test.
Change-Id: Ic84e1ef507f017516d47a6b66e646e7e7b5ded8d
Closes-Bug: #1852724
In check queue there were 2 iptables_hybrid jobs. One was run on Ubuntu
and one on Fedora.
During the Shanghai PTG we agreed to remove one of those jobs and left
only one of them to be run in both check and gate queues.
This commit removes iptables_hybrid job based on Fedora image.
Change-Id: If0adb7ca4e254f5b19375b471679bcc18e0c7790
During Shanghai PTG Akihiro talked with Dharmendra, who is the Tacker
PTL that Dharmendra can be maintainer of networking-sfc project for now
as Tacker is using this project.
So lets say that officially in our documentation now.
Change-Id: Iea9fbf997130e95252fcd1063fd7a28ad84dd369
In the openstackdocstheme, one page should have a single title heading
(the highest level). If we have multiple title headings, only the first
one is shown at the top of the page and the remaining one(s) are not
shown in the main contents. (They are shown only in "Page Contents"
of the left TOC.) It is confusing a bit.
As far as I checked, this happens in two files in the current neutron doc.
contributor/policies/neutron-teams.rst:
It looks better to introduce a page title and keep the existing
titles as subsections.
contributor/internals/layer3.rst:
There is no need to include a page on the L3 agent
as it is a separate page.
Change-Id: I354182b900bdd04b4fcd64dcf2adbe00d7f8df5a
_find_available_ips tried to find available ips based on the given
subnet's cidr field, which can be misleading if random selection goes
out-of allocation-pool. This patch changes this behaviour to use
cidr's allocation_pool field.
Closes-Bug: #1850292
Change-Id: Ied2ffb5ed58007789b0f5157731687dc2e0b9bb1
Commit 614b95c83759f6476841f405b08806601a3c89a0 changed
the return value type of funcion firewall_refresh_needed
unexpectedly. This one fixes it.
Change-Id: I92dbdb02742af55534e16b87be551bae101262a1
This reverts commits:
9a022e7d7b85b7c21cf26698fe59c818c4577194
d7604169988726d121cdc9727accfeb6e29f4aed
As the issue is relevant only for old kernels and almost 4 years
have passed since this fix was introduced, it is safe to undo the
workaround to use ip link show command for determining whether or not
a VF is assigned with macvtap(and followup patch that fixed excessive
use of ip link show commans).
reverting this commit will benefit the agent by reducing the amount of
ip link calls.
While it is possible to perform a revert-per-commit, this change should
really go in as one commit for clarity and avoid introducing a
performance degradation in case one is merged without the other.
Conflicts:
neutron/plugins/ml2/drivers/mech_sriov/agent/eswitch_manager.py
neutron/plugins/ml2/drivers/mech_sriov/agent/pci_lib.py
neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_eswitch_manager.py
neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_pci_lib.py
Conflicts details:
In eswitch_manager: merge tool was unable to properly revert
is_assigned_vf() due to changes in later patches.
In pci_lib: conflicts with later changes to is_macvtap_assigned()
and link_show() that are no longer required and revert
of IPCommandDeviceError definition.
In unit tests: conflicts due to newly added tests and reverting the
IPCommandDeviceError exception definition.
Sorting out mocks as link_show() method was removed
Related-bug: #1523083
Change-Id: I04ea8eb63de07a6e1e51c2790c5920b086b8542c
Increate waiting time in "test_reschedule_network_on_new_agent", when
the network is being rescheduled from a dead DHCP agent to an running
one.
According to [1], 120 seconds could be a convervative and enough value
to wait for this transition.
[1] https://bugs.launchpad.net/neutron/+bug/1799555/comments/23
Change-Id: I2fec6015b56fd1b5d21b75f7432c40b2110fe6bc
Related-Bug: #1799555
During the namespace PID listing, if a process is stopped, it will
disappear from "/proc/<pid>". When "os.stat(path)" is executed on
an unexistent path, returns "FileNotFoundError". This exception
should be catched and ignored.
Change-Id: Icde5e15bd97578f5ec8273f22ef8384502be1850
Related-Bug: #1841753
Neutron-ovs-agent can now enable IGMP snooping in integration bridge
if config option "igmp_snooping_enable" in OVS section in config will
be set to True.
It will also set mcast-snooping-disable-flood-unregistered=true
so flooding of multicast packets to all unregistered ports will be
disabled also.
Both changes are applied on integration bridge.
Change-Id: I12f4030a35d10d1715d3b4bfb3ed5efb9aa28f2b
Closes-Bug: #1840136
This config option was added by [1] and deprecated to
be removed in Mitaka cycle. As we are now in Ussuri, it's
time to finally get rid of it.
[1] https://review.opendev.org/#/c/197210/
Change-Id: Ibd16a0587c88e2dbee1b7938e52140f68821eec6
The max_header_size config option only applies to the
Geneve header itself, not the underlying IP/IPv6 header,
whose size is calculated separately. Remove a misleading
sentence and correct the help text to say '30'.
Trivialfix
Change-Id: If856bba4e61a6f1326138fc3a7ab29ce87c3ad04
This patch proposes a decorator to be used to profile code with
cProfile. Config options are added to control whether the code is
profiled or not. The default is no profiling performed.
The decorator is then used in the Neutron API base and Pecan controllers
for the index, show, create, delete and update operations. The rpc_loop
method of the OVS agent is also decorated.
Finally, profiling is enabled for neutron-rally-task.
Change-Id: I5c847a255b4b973add7fce5a38a2594912c491ac
Set a big timeout for rootwrap daemon in functional and fullstack
tests. The value defined in 7800, the same as the Zuul jobs
timeout.
This timeout increase will prevent the daemon to close when
executing a test root command, as described in the bug. An
unexpected rootwrap daemon closure is not considered as a normal
event during the test execution.
The default value set in the configuration file is 600 seconds, the
same as daemon default value. This timeout is increased only when
OS_SUDO_TESTING=1, that means functional and fullstack tests, when
using the script "tools/deploy_rootwrap.sh".
Change-Id: I691300a4e9a7cccd8887bc8f95ba9cea32988bac
Closes-Bug: #1850558
Avoid the following when test_create_net_port_security_default
hits an exception before variable network is set:
UnboundLocalError: local variable 'network' referenced before assignment
Related changes:
- https://review.opendev.org/#/c/188209/
- https://review.opendev.org/#/c/679399/
Change-Id: I494916567a4df2bef410e8dc54505c289bd55a61
In the reported bug, a regression was introduced in [1] when limiting
the time to have a "dnsmasq" process enabled. It has been reported, as
documented in the bug, that in older versions (Queens), using Python 2
[2] and older versions of "ip_lib" (not implementing most of the
commands using Pyroute2), that the time needed to spawn a "dnsmasq"
process exceeds the default 60 seconds defined in
"common_utils.wait_until_true".
This patch increases this time by a reasonable 300 seconds.
[1] https://review.opendev.org/#/c/643732
[2] https://bugs.python.org/issue35757
Change-Id: I2d8693145da72825876b951f2d10afe9ca28ff6e
Closes-Bug: #1849676
Config option "ovsdb_interface" was removed from neutron with [1]
but some small leftovers were still in description of other config
options.
So this patch cleans them.
TrivialFix
[1] https://review.opendev.org/#/c/570259/
Change-Id: I82b91153e697cd78bf7d7212bb842ea733d0ca66
Port deletion triggers disassociate_floatingips. This patch ensures
that method not only clears the port association for a Floating IP,
but also removes any DNS record associated with it.
Change-Id: Ia6202610c09811f240af35e2523126447bf02ca5
Closes-Bug: #1812168
This patch sets the MTU attribute to non-nullable, the code
that get the MTU and update the network in some methods can
be removed. If the MTU is empty before the pike version, it
is set to the default value of 1500.
Change-Id: Id4d738dde7fa4b7caccabad0aac542b82b4d7af1
Closes-Bug: #1842261
