16640 Commits

Author SHA1 Message Date
Jenkins
f46cba17f0 Merge "Truncate IPDevice's name to interface max size" 2016-11-11 21:22:33 +00:00
Jenkins
0e6aea1553 Merge "Make OVO exception NeutronDbObjectDuplicateEntry retriable" 2016-11-11 17:04:41 +00:00
Jenkins
b062683737 Merge "Move OVO exceptions to neutron/objects/exceptions" 2016-11-11 17:04:06 +00:00
Jenkins
bdb4c92004 Merge "l3-ha: Send gratuitous ARP when new floating IP is added" 2016-11-11 13:55:07 +00:00
Jenkins
1020c515c9 Merge "Removed dispose_pool() from db/api" 2016-11-11 04:12:55 +00:00
Jenkins
bef90aadd8 Merge "Removed paginate_query and sqlalchemyutils module" 2016-11-10 20:33:21 +00:00
Jakub Libosvar
4fdd89e94f l3-ha: Send gratuitous ARP when new floating IP is added
We rely on keepalived to send gratuitous ARPs when floating IP is added.
Older versions of keepalived up to 1.2.20 (exclusive) contain bug [1] where
keepalived does not send GARP on receiving SIGHUP. Unfortunately, newer
versions containing the fix are not packaged yet for some distributions
like RHEL or CentOS or Ubuntu Xenial, so this patch adds a workaround for
such distributions until new packages are available.

The patch also sets net.ipv4.ip_nonlocal_bind kernel parameter to 0 for
Snat and HA router namespaces in order to avoid sending gratuitous ARPs
for IP addresses that are not bound to the interface anymore - possibly
because of failover or removal. Note that kernel < 3.19 contain a bug
where this knob is missing. In case it attempts to set the parameter and
it's missing on the system, it doesn't set the knob in root
namespace like it's done for fip namespaces, but only issues a warning
message.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1391553

Change-Id: Ieab53624dc34dc687a0e8eebd84778f7fc95dd77
Closes-bug: 1639315
2016-11-10 15:27:21 -05:00
Jenkins
7775beaa43 Merge "Removed deprecated function import_modules_recursively" 2016-11-10 18:45:20 +00:00
Mohit Malik
17ecc54493 Make OVO exception NeutronDbObjectDuplicateEntry retriable
OVO object create() raises exception NeutronDbObjectDuplicateEntry
on seeing duplicate entries which should be handled by retrying the
transaction.

Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
Closes-Bug: #1627811

Change-Id: I2b311326c2caa7500aa9318d0b5bf753cf0eb543
2016-11-10 10:25:06 -07:00
John Perkins
0a27cf7fd6 Move OVO exceptions to neutron/objects/exceptions
Change-Id: Ibf424b4e317e910e33c29fb9ec150452caa06a89
Partial-Bug: #1614920
2016-11-10 10:25:06 -07:00
Jenkins
0f8fa89432 Merge "Add OVO for dns Objects" 2016-11-10 16:46:21 +00:00
Jenkins
2f7856092a Merge "Retire deprecations for constants, exceptions, attributes" 2016-11-10 15:54:16 +00:00
Jenkins
a36dfabd25 Merge "Introduce context in methods for Router Extra Attributes OVO usage." 2016-11-10 13:03:29 +00:00
Jenkins
584e6a518c Merge "Add rally hook to neutron devstack plugin" 2016-11-10 11:23:31 +00:00
Jenkins
dc4394e0ba Merge "DHCP: Add missing path for marking ports as ready" 2016-11-10 10:54:16 +00:00
Jenkins
f562750d6b Merge "Removed get_engine() from db/api" 2016-11-10 08:40:06 +00:00
Armando Migliaccio
f5e30abcc5 Add rally hook to neutron devstack plugin
This allows us to configure neutron when running the rally job in
the gate. This effort stems from patch [1]. Blame Kevin for not
wanting to squash the two together.

[1] I12aaf6121b677e9696131601b3539a7091e2858c
Change-Id: I006957784ac7900021bcfee57cbc83b5a6c533c4
2016-11-10 07:44:28 +00:00
Henry Gessau
b0e56ac646 Retire deprecations for constants, exceptions, attributes
Subprojects have had enough time to switch to neutron-lib for
the deprecated items from these modules.

Change-Id: Ib2f4acf7e0153667389c57a52f2db33a23758b24
2016-11-09 23:43:38 -05:00
Jenkins
efe87156c5 Merge "Change IPAM DB API to use context instead of session object." 2016-11-09 20:18:33 +00:00
Omer Anson
0140a183dc Truncate IPDevice's name to interface max size
An interface's name is limited to INTERFACE_MAX_SIZE. In some cases, IP
utils truncate this name automatically. In Ubuntu Xenial, ip link
returns an error instead of this behaviour.

This change truncates the device's name upon read (The full name is
still stored on the object). This way, the code does not rely on IP
utils to do the truncation. This solves the error in the test.

Change-Id: I41b226e4b52239b861e2b6e806296025502b9b60
Closes-Bug: 1637993
2016-11-09 19:58:41 +00:00
Jenkins
e62a670e70 Merge "Switch to new hacking 0.12" 2016-11-09 15:05:01 +00:00
Jenkins
c4c3fbdb5e Merge "Don't pass config object to send_ip_addr_adv_notif()" 2016-11-09 12:40:49 +00:00
Jenkins
640fd9d2fd Merge "fullstack: test for IPv6 north-south traffic" 2016-11-09 12:02:45 +00:00
Kevin Benton
9f1057bfd9 DHCP: Add missing path for marking ports as ready
'refresh_dhcp_helper', which is called after subnet update/create
notifications in the DHCP agent, can end up retrieving ports that
the agent hadn't yet seen. It will then configure those ports but
not notify the server that they are ready.

Unless the port is subsequently updated on the server afterwards to
generate a new port update notification, the DHCP agent won't ever tell
the server that the port has had DHCP provisioned. This led to the
bug this closes. Another patch[1] that removed excessive DHCP ready
notifications uncovered this bug.

This patch just adjusts refresh_dhcp_helper to ensure that all ports
are marked as ready after configuring them all.

1. Ie7686837b18ff251baa315ef95dc511cda475672

Change-Id: I1fed60c1835c2ebed7c050c6fa114f89beec3190
Closes-Bug: #1639806
2016-11-09 03:20:11 +00:00
Jenkins
04bee5befc Merge "Removed deprecation warning for converters and validators" 2016-11-08 20:19:54 +00:00
Jenkins
7c59522790 Merge "Removed deprecation warning for waiting_until_true" 2016-11-08 20:16:40 +00:00
Jakub Libosvar
79ad8492d7 Don't pass config object to send_ip_addr_adv_notif()
Previously, the function consumed a config object and picked only a
single option send_arp_for_ha from that object. This patch replaces the
config object with count itself in order to be able to send gratuitous
ARPs not relying on a single config option.

As per http://codesearch.openstack.org, this function is not called in
any other stadium project. The send_arp_for_ha option is deprecated as
for Ocata.

Related-bug: 1639315

Change-Id: I6efc539a969bebb4fd969e1648a787bf7dc9cd0b
2016-11-08 19:32:00 +00:00
Jenkins
475241834d Merge "Update metadata proxy when subnet add/delete" 2016-11-08 18:00:39 +00:00
Jenkins
76dd63801b Merge "L3-HA: remove unused deprecated code" 2016-11-08 15:21:59 +00:00
Jenkins
3596a387c1 Merge "neutron-lib: use replace_file from neutron lib" 2016-11-08 06:30:35 +00:00
Jenkins
e55bad8256 Merge "Deprecate send_arp_for_ha option" 2016-11-08 05:10:06 +00:00
Jenkins
8d781eb4b7 Merge "Remove unused configuration variable" 2016-11-08 04:44:54 +00:00
Dariusz Smigiel
e43eb80ac2 Removed deprecation warning for waiting_until_true
wait_until_true is moved to neutron.common.utils
It was marked for removal in Ib8b0e51dbd9edaa58391774d428a737836dfdf77

Change-Id: I9efbbc237acbcebbb36ff239ec234b25abacccae
2016-11-08 03:49:21 +00:00
Dariusz Smigiel
6bb12ef128 Removed deprecated function import_modules_recursively
Change Ia8d91a1704c894bc1f6cf14e6cdd971fab255b62 moved function
import_modules_recursively from neutron.tests.tools to
neutron.common.utils
Please use appropriate function path.

Change-Id: I7a178ceff5bbc4b6f45cfc040232148090bce135
Related-Bug: #1612959
2016-11-08 03:41:11 +00:00
Ihar Hrachyshka
4e25ba840a Switch to new hacking 0.12
The release includes its own check for delayed string interpolation for
log messages, so we can now remove our own check for the same thing. The
check is off-by-default, so we need to explicitly enable it. Sadly,
select= directive in tox.ini is broken [1] so we need to enable the
check with flake8 argument instead.

[1] https://github.com/PyCQA/pycodestyle/issues/390

Change-Id: Idc6b8e5b1cb594e130d4cc0cbcfffd362f9ab86a
2016-11-08 03:36:00 +00:00
Jenkins
70462de005 Merge "ipv6_utils: delete get_ipv6_addr_by_EUI64" 2016-11-07 23:51:05 +00:00
Shashank Kumar Shankar
f5a721e0c2 Introduce context in methods for Router Extra Attributes OVO usage.
This patch introduces context in methods where it is needed for
object operations done during the integration of Router Extra
Attributes OVO.

Used in integration patch: https://review.openstack.org/#/c/381209/

Change-Id: I4dea67207220a19abf5d3cc754f02150b3621550
Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
2016-11-07 22:20:26 +00:00
Dariusz Smigiel
eca4acea83 Removed dispose_pool() from db/api
Change I6f0d108fc00cc7fcfaac1bd8f1b0468fcfbaa0dd deprecated
dispose_pool(). Instead of this context_manager.dispose_pool() can be
used.

Change-Id: I532e37b42f399ab6ca536f360772b1ccbcfb818a
2016-11-07 20:40:25 +00:00
Dariusz Smigiel
6d85a51e2a Removed deprecation warning for converters and validators
Converters and Validators were moved to neutron_lib in change
I6b9079e9e703c6fd75adbed3846e7257685433e8

Change-Id: I37c1e2ee1634a7fb72c401caee9122dadd669a64
2016-11-07 20:25:14 +00:00
Dariusz Smigiel
7d17f8c7c3 Removed get_engine() from db/api
This function was deprecated in change
Id38c06aee428200a061c59a984b59b81b24056e3
get_engine() can be called directly with
context_manager.get_legacy_facade().get_engine()

Change-Id: I7ef45c7ced65a3a3746e616c7b796a34b3551d3c
Related-bug: #1520719
2016-11-07 20:25:07 +00:00
Dariusz Smigiel
5189cbceeb Removed paginate_query and sqlalchemyutils module
Function paginate_query was deprecated in change
Ie7da16b94fa2023c9c3d84d96d55f33d0f76903f
Use paginate_query from oslo.db but note that the arguments differ.

Change-Id: I00ac065758f0819f98fc52e0cd1e66aaf814aa57
2016-11-07 20:24:59 +00:00
Ihar Hrachyshka
6b59cc72a4 Deprecate send_arp_for_ha option
It puzzles me why we would want to have it configurable. Having it = 0
is just plain bad (it breaks a floating IP roaming around HA routers),
having it = 1 may be unsafe if clients miss the update, having it more
than 3 (the default) is probably wasteful. That makes me think that
maybe we should not have it in the first place.

The patch that introduced the option also introduced the feature itself,
and does not provide any clue around why we would need it:
I125dbc57b90027dc5e99ff0a5d6877843a0b02a5

Maybe the option is in the tree because, in Assaf Muller's words, "we're
a bunch of lazy developers that like to shift the responsibility to our
poor users that have to deal with thousands of configuration options".

I suggest we just move with deprecation and removal here.

Change-Id: I9d12b8f4c25ddf91312153f236915c0c14302e2d
Related-Bug: #1639879
2016-11-07 19:51:58 +00:00
Mohit Malik
cc861ad30f Change IPAM DB API to use context instead of session object.
This code is not being used outside neutron tree so it's
safe to change the api to use context instead of session.
This change is required for implementing Ipam OVO and is
consistent with rest of the DB API code in neutron.

Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598
Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
2016-11-07 18:18:53 +00:00
Jenkins
dc8ad65838 Merge "Add fullstack test for check DSCP marks outbounds" 2016-11-07 15:47:35 +00:00
Jenkins
6226afc562 Merge "Reduce rally executions of create_and_list_ports" 2016-11-07 15:44:20 +00:00
Sławek Kapłoński
ea7b51655f Add fullstack test for check DSCP marks outbounds
New fullstack test is added to check if packets which
should be sent from port with DSCP mark set are really
sent to another port with this DSCP mark.

This test uses IPv4 only.

Change-Id: I4b26c3c644eb6f2f7813658c99d16fbc3cc61e06
Closes-Bug: #1625570
2016-11-07 12:15:20 +00:00
Gary Kotton
0e8b32b03b L3-HA: remove unused deprecated code
Commit 2823c2e569776b023f889af8d2bd22c2453950f1 added the
deprecation warning but no one uses the code. So the unused code is
deleted.

Change-Id: I22d96182a7c88f725d19559c25f1820a8fb176f2
2016-11-07 01:34:20 -08:00
Gary Kotton
3d68a51eac neutron-lib: use replace_file from neutron lib
Make use of the file utility replace_file from neutron-lib.
The utility replace_file in neutron is marked as deprecated.

Change-Id: I7e3ed10a22012be9511e43e4dc3bf73076b2954e
2016-11-07 09:18:41 +00:00
Jenkins
29669c04dd Merge "Migrate to neutron-lib released API definition for trunk APIs" 2016-11-07 04:29:57 +00:00
Jenkins
e3f10bf187 Merge "Updated from global requirements" 2016-11-06 21:39:33 +00:00