openstack
/
neutron
Code Issues Proposed changes
neutron/neutron
History
Viktor Varga c4d65601ed Replaced assertTrue(False) with fail() 
In some unit and functional tests self.assertTrue(False) was used
instead of self.fail(), which might be against readability.

Using assertTrue(False) gives the following message on fail:

  File "C:\Python361\lib\unittest\case.py", line 678, in assertTrue
    raise self.failureException(msg)
    AssertionError: False is not true

After replacing assertTrue(False) with fail():

  File "C:\Python361\lib\unittest\case.py", line 666, in fail
    raise self.failureException(msg)
    AssertionError: None

Although the results are the same (both tests failed), the
message 'False is not true' is unnecessary, and can be omitted
from the log by using fail().

Change-Id: I81e21040fd6a2f9713889912fafd2b19bd056b5a
 		2017-06-22 19:31:00 +02:00
..
agent Merge "DVR: Add forwarding routes based on address_scopes" 2017-06-21 03:06:15 +00:00
api Merge "DHCP RPC: Separate local from non-local subnets" 2017-06-20 06:37:12 +00:00
callbacks Merge "service: add callback AFTER_SPAWN" 2017-05-20 09:09:12 +00:00
cmd Merge "Adds an option to skip ports on ovs_cleanup" 2017-05-17 09:15:33 +00:00
common Merge "Fixes import_modules_recursively for Windows" 2017-06-19 13:56:28 +00:00
conf Merge "VXLAN multicast groups in linuxbridge" 2017-05-30 00:55:21 +00:00
core_extensions Add "default" behaviour to QoS policies 2017-05-26 23:31:36 +00:00
db Merge "Using constants in local" 2017-06-22 07:11:43 +00:00
debug use neutron_lib's portbindings api-def 2017-03-31 09:16:22 -06:00
extensions use extra_dhcp_opt api-def from neutron-lib 2017-05-31 15:06:35 +00:00
hacking Switch to neutron-lib hacking factory 2017-04-13 07:41:25 -07:00
ipam Don't log ipam driver on every IP allocation 2017-06-14 02:11:17 -07:00
locale Imported Translations from Zanata 2016-08-19 07:27:43 +00:00
notifiers Merge "Send port ID in network-changed event to Nova" 2017-06-15 17:22:36 +00:00
objects OVO: Allow port queries based on security_group_ids 2017-06-20 08:33:22 +00:00
pecan_wsgi Don't log about no notification on GET requests 2017-06-12 20:19:40 -07:00
plugins Merge "Add revises_on_change to Binding DB models" 2017-06-22 09:36:57 +00:00
privileged Do not raise an error deleting neighbour entry 2017-01-26 16:22:20 -05:00
quota Use new enginefacade for quota and provisioning blocks 2017-03-29 14:31:03 +00:00
scheduler [OVO] Integration of RouterL3AgentBinding 2017-05-26 13:17:58 -07:00
server Switch to start_all_workers in RPC server 2017-06-13 02:20:35 -07:00
services Merge "Correct the config group in check_trunk_dependencies" 2017-06-22 09:37:20 +00:00
tests Replaced assertTrue(False) with fail() 2017-06-22 19:31:00 +02:00
__init__.py Hacking rule to check i18n usage 2016-03-30 21:28:37 -04:00
_i18n.py Move i18n to _i18n, as per oslo_i18n guidelines 2015-12-01 19:29:10 -07:00
auth.py Use oslo.context class method to construct context object 2017-03-23 09:02:46 +00:00
manager.py Use is_loaded in manager.init 2017-03-30 14:53:20 +00:00
neutron_plugin_base_v2.py replace WorkerSupportServiceMixin with neutron-lib's WorkerBase 2017-06-14 06:56:48 -06:00
opts.py Remove deprecated support for QoS notification_drivers 2017-04-17 06:32:01 -07:00
policy.py Merge "Neutron server was not compatible with member actions" 2017-04-21 06:28:39 +00:00
service.py Merge "use worker from neutron-lib" 2017-05-25 07:53:44 +00:00
version.py
…
worker.py replace WorkerSupportServiceMixin with neutron-lib's WorkerBase 2017-06-14 06:56:48 -06:00
wsgi.py use worker from neutron-lib 2017-05-16 07:44:08 -06:00