This change refactors the rule-specific methods in qos_plugin.py in order to facilitate implementation of additional QoS rule types. Further, with the recent merge of https://review.openstack.org/#/c/292488/, which prevents primary keys in Neutron's oslo.versioned objects from being updated, the QoS plugin needed additional refactoring. This change implements a generic method in Neutron's base objects to handle object updates without updating the primary key. This method is then used in the QoS plugin. Co-Authored-By: Slawek Kaplonski <slawek@kaplonski.pl> Change-Id: I863f063a0cfbb464cedd00bddc15dd853cbb6389 Partial-Bug: #1468353
4.6 KiB
Neutron public API
Neutron main tree serves as a library for multiple subprojects that rely on different modules from neutron.* namespace to accommodate their needs. Specifically, advanced service repositories and open source or vendor plugin/driver repositories do it.
Neutron modules differ in their API stability a lot, and there is no part of it that is explicitly marked to be consumed by other projects.
That said, there are modules that other projects should definitely avoid relying on.
Specifically, no external repository should use anything located under neutron.openstack.common.* import path. This code belongs to oslo-incubator modules and is not meant to work for consumers other than neutron main tree itself. (The only exception is made for advanced service repositories that are tightly controlled by neutron community.) Long story short, if your repository uses those modules, please switch to corresponding oslo libraries or use your own copy of oslo-incubator files.
Breakages
Neutron API is not very stable, and there are cases when a desired change in neutron tree is expected to trigger breakage for one or more external repositories under the neutron tent. Below you can find a list of known incompatible changes that could or are known to trigger those breakages. The changes are listed in reverse chronological order (newer at the top).
- change: QoS plugin refactor
- commit: I863f063a0cfbb464cedd00bddc15dd853cbb6389
- solution: implement the new abstract methods in
-
neutron.extensions.qos.QoSPluginBase.
- severity: Low (some out-of-tree plugins might be affected).
- change: Consume ConfigurableMiddleware from oslo_middleware.
- commit: If7360608f94625b7d0972267b763f3e7d7624fee
- solution: switch to oslo_middleware.base.ConfigurableMiddleware;
-
stop using neutron.wsgi.Middleware and neutron.wsgi.Debug.
- severity: Low (some out-of-tree plugins might be affected).
- change: Consume sslutils and wsgi modules from oslo.service.
- commit: Ibfdf07e665fcfcd093a0e31274e1a6116706aec2
- solution: switch using oslo_service.wsgi.Router; stop using neutron.wsgi.Router.
- severity: Low (some out-of-tree plugins might be affected).
- change: oslo.service adopted.
- commit:
6e693fc91d
- solution: switch using oslo_service.* namespace; stop using ANY neutron.openstack.* contents.
- severity: low (plugins must not rely on that subtree).
- commit:
- change: oslo.utils.fileutils adopted.
- commit: I933d02aa48260069149d16caed02b020296b943a
- solution: switch using oslo_utils.fileutils module; stop using neutron.openstack.fileutils module.
- severity: low (plugins must not rely on that subtree).
- change: Reuse caller's session in DB methods.
- commit:
47dd65cf98
- solution: Add context to args and reuse.
- severity: High (mostly undetected, because 3rd party CI run Tempest tests only).
- commit:
- change: switches to oslo.log, removes neutron.openstack.common.log.
- commit:
22328baf1f
- solution: a) switch to oslo.log; b) copy log module into your tree and use it (may not work due to conflicts between the module and oslo.log configuration options).
- severity: High (most CI systems are affected).
- commit:
- change: Implements reorganize-unit-test-tree spec.
- commit:
1105782e39
- solution: Code affected need to update existing unit tests to reflect new locations.
- severity: High (mostly undetected, because 3rd party CI run Tempest tests only).
- commit:
- change: drop linux/ovs_lib compat layer.
- commit:
3bbf473b49
- solution: switch to using neutron/agent/common/ovs_lib.py.
- severity: High (most CI systems are affected).
- commit: