openstack/nova-powervm
Code Issues Proposed changes
e11290cb01
nova-powervm/HACKING.rst
kairoaraujo e5749bec65 hacking: check for deprecated os.open() 
Add hacking check for deprecated library function os.popen().
This bug was reported https://bugs.launchpad.net/tempest/+bug/1529836
and this hacking prevents new os.popen() in the code.

Change-Id: I124b9f86ffc6eba268c99ad9834686f55fd857c3
2016-02-17 14:43:31 -02:00

911 B
Raw Blame History

Nova-PowerVM Style Commandments

Nova-PowerVM Specific Commandments

  • Follow the Nova HACKING.rst
  • [P301] LOG.warn() is not allowed. Use LOG.warning()
  • [P302] Deprecated library function os.popen()

Creating Unit Tests

For every new feature, unit tests should be created that both test and (implicitly) document the usage of said feature. If submitting a patch for a bug that had no unit test, a new passing unit test should be added. If a submitted bug fix does have a unit test, be sure to add a new one that fails without the patch and passes with the patch.

For more information on creating unit tests and utilizing the testing infrastructure in OpenStack Nova, please read nova/tests/README.rst.