Update patch set 2
Patch Set 2: Code-Review+1 (4 comments) Patch-set: 2 Reviewer: Gerrit User 11604 <11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1, 78b07ea1d8276abe1c8096cba2fbcdf586275fb5 Attention: {"person_ident":"Gerrit User 11604 \u003c11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
This commit is contained in:
parent
04d8247c20
commit
42049d8527
|
@ -0,0 +1,72 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"unresolved": false,
|
||||||
|
"key": {
|
||||||
|
"uuid": "859a1a6e_b8f3beec",
|
||||||
|
"filename": "/PATCHSET_LEVEL",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 0,
|
||||||
|
"author": {
|
||||||
|
"id": 11604
|
||||||
|
},
|
||||||
|
"writtenOn": "2023-05-29T11:08:52Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "some minor issues inline but overall this looks good.",
|
||||||
|
"revId": "8a928a40e11c3131d4fd9c3e71dc958014e2408b",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "83fdc53e_e0e73314",
|
||||||
|
"filename": "specs/2023.2/approved/track-sriov-nics-in-placement.rst",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 170,
|
||||||
|
"author": {
|
||||||
|
"id": 11604
|
||||||
|
},
|
||||||
|
"writtenOn": "2023-05-29T11:08:52Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "we should clarify that this only applies to addtional resouce requestr on the port and only if pci in palcement is enabled.",
|
||||||
|
"revId": "8a928a40e11c3131d4fd9c3e71dc958014e2408b",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "c4612549_c765567e",
|
||||||
|
"filename": "specs/2023.2/approved/track-sriov-nics-in-placement.rst",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 173,
|
||||||
|
"author": {
|
||||||
|
"id": 11604
|
||||||
|
},
|
||||||
|
"writtenOn": "2023-05-29T11:08:52Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "we should also add\n\nphysical_network as a trait to the RP i.e. CUSTOM_PHYSNET_\u003cphysical_network\u003e",
|
||||||
|
"revId": "8a928a40e11c3131d4fd9c3e71dc958014e2408b",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "5f821dba_e6d3674c",
|
||||||
|
"filename": "specs/2023.2/approved/track-sriov-nics-in-placement.rst",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 293,
|
||||||
|
"author": {
|
||||||
|
"id": 11604
|
||||||
|
},
|
||||||
|
"writtenOn": "2023-05-29T11:08:52Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "the former already exists as https://docs.openstack.org/nova/latest/configuration/config.html#filter_scheduler.pci_in_placement and the latter is https://docs.openstack.org/nova/latest/configuration/config.html#pci.report_in_placement\n\nno new config options are requried but they will have to opt into this behviaor by setting the existing options.",
|
||||||
|
"revId": "8a928a40e11c3131d4fd9c3e71dc958014e2408b",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue