openstack/nova
Code Issues Proposed changes

Remove get_network from nova.network.rpcapi

Browse Source 
Remove the get_network() method from nova.network.rpcapi.  It's not
actually used, so help make that clear by removing it from the client
rpc class.

This also helps us clarify what changes we have to be careful about with
respect to rpc versioning.

Related to nova-network-objects

Change-Id: Ibfcc90499fb6c20b7f14597ea360ed55bb34e058
This commit is contained in:
Russell Bryant
2014-01-16 18:31:59 -05:00
parent 64b5e874ae
commit 02e0413a8d
2 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
nova/network/rpcapi.py
View File

@@ -70,6 +70,7 @@ class NetworkAPI(rpcclient.RpcProxy):
NOTE: remove unused method get_vifs_by_instance() NOTE: remove unused method get_vifs_by_instance()
NOTE: remove unused method get_vif_by_mac_address() NOTE: remove unused method get_vif_by_mac_address()
NOTE: remove unused method get_network()
''' '''
# #
@@ -100,10 +101,6 @@ class NetworkAPI(rpcclient.RpcProxy):
def get_all_networks(self, ctxt): def get_all_networks(self, ctxt):
return self.client.call(ctxt, 'get_all_networks') return self.client.call(ctxt, 'get_all_networks')
def get_network(self, ctxt, network_uuid):
return self.client.call(ctxt, 'get_network',
network_uuid=network_uuid)
# TODO(russellb): Convert this to named arguments. It's a pretty large # TODO(russellb): Convert this to named arguments. It's a pretty large
# list, so unwinding it all is probably best done in its own patch so it's # list, so unwinding it all is probably best done in its own patch so it's
# easier to review. # easier to review.

4
nova/tests/network/test_rpcapi.py
View File

@@ -101,10 +101,6 @@ class NetworkRpcAPITestCase(test.NoDBTestCase):
def test_get_all_networks(self): def test_get_all_networks(self):
self._test_network_api('get_all_networks', rpc_method='call') self._test_network_api('get_all_networks', rpc_method='call')
def test_get_network(self):
self._test_network_api('get_network', rpc_method='call',
network_uuid='fake_uuid')
def test_create_networks(self): def test_create_networks(self):
self._test_network_api('create_networks', rpc_method='call', self._test_network_api('create_networks', rpc_method='call',
arg1='arg', arg2='arg') arg1='arg', arg2='arg')