openstack/nova
Code Issues Proposed changes

Remove unused _vlan_is_disabled test flag

Browse Source 
The FakeNetworkAPI was setting the _vlan_is_disabled class member to
False and there was no override of that member anywhere else in the
code. It was checked in one place to determine whether or not to raise a
NotImplementedError. But since it was never True that was never raised.

Change-Id: I830bf1e5c62ec842701fed48b6ecc9ddf7deb2ba
This commit is contained in:
Andrew Laski 2016-05-31 11:14:46 -04:00
parent dbf9bf0703
commit 4d4824772d
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/tests/unit/api/openstack/compute/test_networks.py
View File

@ -117,7 +117,6 @@ NEW_NETWORK = {
class FakeNetworkAPI(object):
_sentinel = object()
_vlan_is_disabled = False
def __init__(self, skip_policy_check=False):
self.networks = copy.deepcopy(FAKE_NETWORKS)
@ -153,8 +152,6 @@ class FakeNetworkAPI(object):
def add_network_to_project(self, context,
project_id, network_uuid=None):
if self._vlan_is_disabled:
raise NotImplementedError()
if network_uuid:
for network in self.networks:
if network.get('project_id', None) is None: