openstack/nova
Code Issues Proposed changes

Merge "Deprecate [api] use_forwarded_for"

Browse Source
This commit is contained in:
Zuul 2022-04-25 19:39:53 +00:00 committed by Gerrit Code Review
commit 56b5aed08c
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
etc/nova/api-paste.ini
View File

@ -6,7 +6,7 @@ use = egg:Paste#urlmap
/: meta
[pipeline:meta]
pipeline = cors metaapp
pipeline = cors http_proxy_to_wsgi metaapp
[app:metaapp]
paste.app_factory = nova.api.metadata.handler:MetadataRequestHandler.factory

4
nova/conf/api.py
View File

@ -42,7 +42,11 @@ Determine the strategy to use for authentication.
"""),
cfg.BoolOpt("use_forwarded_for",
default=False,
deprecated_for_removal=True,
deprecated_reason='This feature is duplicate of the HTTPProxyToWSGI '
'middleware in oslo.middleware',
deprecated_group="DEFAULT",
deprecated_since='26.0.0',
help="""
When True, the 'X-Forwarded-For' header is treated as the canonical remote
address. When False (the default), the 'remote_address' header is used.

12
releasenotes/notes/deprecate-use_forwarded_for-f7b24eaf130782b9.yaml Normal file
View File

@ -0,0 +1,12 @@
---
upgrade:
- |
The default ``api-paste.ini`` file has been updated and now the Metadata
API pipeline includes the ``HTTPProxyToWSGI`` middleware.
deprecations:
- |
The ``[api] use_forwarded_for`` parameter has been deprecated. Instead of
using this parameter, add the ``HTTPProxyToWSGI`` middleware to api
pipelines, and ``[oslo_middleware] enable_proxy_headers_parsing = True``
to nova.conf.