openstack/nova
Code Issues Proposed changes

Improve logging when python-guestfs/libguestfs isn't working

Browse Source 
Bumped from debug to warn level, as most often refers to
missing python-guestfs package or other libguestfs misconfiguration,
and the fallback path is usually not desired.

Closes-bug: 1240339
Change-Id: I5d90a3ea109e79fe17221c001f94d49d599048ba
This commit is contained in:
Jon Grimm
2014-07-30 00:46:57 +00:00
parent 8daa38afa9
commit 5be2e456c0
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nova/virt/disk/vfs/api.py
View File

@@ -12,6 +12,7 @@
# License for the specific language governing permissions and limitations
# under the License.
from nova.i18n import _LW
from nova.openstack.common import importutils
from nova.openstack.common import log as logging
@@ -40,7 +41,8 @@ class VFS(object):
"nova.virt.disk.vfs.guestfs.VFSGuestFS",
imgfile, imgfmt, partition)
else:
LOG.debug("Falling back to VFSLocalFS")
LOG.warn(_LW("Unable to import guestfs, "
"falling back to VFSLocalFS"))
return importutils.import_object(
"nova.virt.disk.vfs.localfs.VFSLocalFS",
imgfile, imgfmt, partition)