openstack/nova
Code Issues Proposed changes

Change force_dhcp_release default to True

Browse Source 
Historically it was was false because it requires the dnsmasq binary
'dhcp_release' which was not present in all distros.

Related to bug 970893

DocImpact

Change-Id: I4975d85a66fb930d6a56900dd569cec2a1874439
This commit is contained in:
Joe Gordon 2013-07-11 10:31:51 +01:00
parent b14f9cd142
commit 8c5d132f2f
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
etc/nova/nova.conf.sample
View File

@ -1181,7 +1181,7 @@
# If True, send a dhcp release on instance termination
# (boolean value)
#force_dhcp_release=false
#force_dhcp_release=true
# If True in multi_host mode, all compute hosts share the same
# dhcp address. (boolean value)

2
nova/network/manager.py
View File

@ -148,7 +148,7 @@ network_opts = [
'deleted in VLAN network mode with multi hosted '
'networks'),
cfg.BoolOpt('force_dhcp_release',
default=False,
default=True,
help='If True, send a dhcp release on instance termination'),
cfg.BoolOpt('share_dhcp_address',
default=False,

1
nova/test.py
View File

@ -250,6 +250,7 @@ class TestCase(testtools.TestCase):
self.policy = self.useFixture(policy_fixture.PolicyFixture())
CONF.set_override('fatal_exception_format_errors', True)
CONF.set_override('enabled', True, 'osapi_v3')
CONF.set_override('force_dhcp_release', False)
def _restore_obj_registry(self):
objects_base.NovaObject._obj_classes = self._base_test_obj_backup