openstack/nova
Code Issues Proposed changes

Revert "libvirt: Wrap un-proxied listDevices() and listAllDevices()"

Browse Source 
This reverts commit 0fccb365dd.

Reason for revert: the current version does not have test coverage to assert the proxy is used so we should revert this and fix it before backporting

Change-Id: I51cf7da85e05131da72acdcf9be09121a326d414
This commit is contained in:
sean mooney
2025-01-14 17:11:59 +00:00
parent 0fccb365dd
commit a67ab85678
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
nova/virt/libvirt/host.py
View File

@@ -1647,9 +1647,7 @@ class Host(object):
:returns: a list of virNodeDevice instance
"""
try:
devs = [self._wrap_libvirt_proxy(dev)
for dev in self.get_connection().listDevices(cap, flags)]
return devs
return self.get_connection().listDevices(cap, flags)
except libvirt.libvirtError as ex:
error_code = ex.get_error_code()
if error_code == libvirt.VIR_ERR_NO_SUPPORT:
@@ -1669,10 +1667,7 @@ class Host(object):
:returns: a list of virNodeDevice instances.
"""
try:
alldevs = [
self._wrap_libvirt_proxy(dev)
for dev in self.get_connection().listAllDevices(flags)] or []
return alldevs
return self.get_connection().listAllDevices(flags) or []
except libvirt.libvirtError as ex:
LOG.warning(ex)
return []