openstack/nova
Code Issues Proposed changes

db: Remove unused DB methods

Browse Source 
The following methods were found in 'nova.db.api' but not implemented
'nova.db.sqlalchemy.api'.

- pcidevice_online_data_migration
- security_group_rule_count_by_group
- security_group_rule_create
- security_group_rule_destroy
- security_group_rule_get
- security_group_rule_get_by_instance
- security_group_rule_get_by_security_group

All the 'security_group_'-prefixed methods should have been removed in
change I6aba959eff1e50af4ac040148c7177f235a09a1f alongside their
implementations, while the 'pcidevice_online_data_migration' method
should have gone in change Idb033e9e52b149372308eabb19c5774e10c56156
alongside its implementation. Resolve this now.

Change-Id: I72a5ba0ea317bf74c70308ed6405638efef6e72d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane
2021-01-19 12:33:47 +00:00
parent 194df1fa62
commit d6cad899ca
1 changed files with 0 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
nova/db/api.py
View File

@@ -992,41 +992,6 @@ def security_group_destroy(context, security_group_id):
return IMPL.security_group_destroy(context, security_group_id)
####################
def security_group_rule_create(context, values):
"""Create a new security group."""
return IMPL.security_group_rule_create(context, values)
def security_group_rule_get_by_security_group(context, security_group_id,
columns_to_join=None):
"""Get all rules for a given security group."""
return IMPL.security_group_rule_get_by_security_group(
context, security_group_id, columns_to_join=columns_to_join)
def security_group_rule_get_by_instance(context, instance_uuid):
"""Get all rules for a given instance."""
return IMPL.security_group_rule_get_by_instance(context, instance_uuid)
def security_group_rule_destroy(context, security_group_rule_id):
"""Deletes a security group rule."""
return IMPL.security_group_rule_destroy(context, security_group_rule_id)
def security_group_rule_get(context, security_group_rule_id):
"""Gets a security group rule."""
return IMPL.security_group_rule_get(context, security_group_rule_id)
def security_group_rule_count_by_group(context, security_group_id):
"""Count rules in a given security group."""
return IMPL.security_group_rule_count_by_group(context, security_group_id)
###################
@@ -1313,10 +1278,6 @@ def archive_deleted_rows(context=None, max_rows=None, before=None):
before=before)
def pcidevice_online_data_migration(context, max_count):
return IMPL.pcidevice_online_data_migration(context, max_count)
####################