openstack/nova
Code Issues Proposed changes
OpenStack Compute (Nova)
43,973 Commits 10 Branches 92 Tags 1.6 GiB
Python 97.7%
Smarty 2.2%
Shell 0.1%
033d4d2689
Go to file
Hiroyuki Eguchi 033d4d2689 libvirt: Delete duplicate check when live-migrating 
A year ago a useless check was added: I7989128d

The above patch was aimed to enable live-migration when
instance is booted from volume and has not local disk
by adding a new check.

However, the same check has been already checked in
_is_shared_block_storage method.

The last part of the _is_shared_block_storage method does
the same that above patch does:
- check whether the instance is booted from volume
- check whether the instance has not a local disk

Also this check calls _is_booted_from_volume incorrectly.
Parameter disk_mapping of _is_booted_from_volume must be a dict, but
this check specifies a string instead.

And finally introduced _has_local_disk method is wrong, because
it does not take into accont disk.ephN names.

This change reverts I7989128d, improves and simplifies related tests.

Closes-Bug: 1598661
Related-Bug: 1469006
Co-Authored-By: Feodor Tersin <ftersin@hotmail.com>
Change-Id: Id59012547c3318d94b65ab9f7c37c33c3a08b0e0
2016-12-02 09:58:29 +03:00
api-guide/source docs: cleanup wording for 'SOFT_DELETED' in api-guide 2016-11-28 11:51:00 -05:00
api-ref/source Merge "Optional name in Update Server description in api-ref" 2016-12-01 03:37:59 +00:00
contrib Merge "changed quantum to neutron in vif-openstack" 2014-03-05 10:45:05 +00:00
devstack Add RC file for excluding tempest tests for LVM job 2016-05-17 10:25:45 -04:00
doc Merge "Mention API V2 should no longer be used" 2016-11-30 03:17:39 +00:00
etc/nova Remove the sample policy file 2016-09-29 14:41:39 -04:00
nova libvirt: Delete duplicate check when live-migrating 2016-12-02 09:58:29 +03:00
plugins/xenserver Add a hacking rule for string interpolation at logging 2016-10-11 08:39:48 +00:00
releasenotes Merge "Revert "Revert "Make n-net refuse to start unless using CellsV1""" 2016-12-01 16:18:34 +00:00
tools Merge "Add Apache 2.0 license to source file" 2016-10-10 12:38:13 +00:00
.coveragerc Remove nova/openstack/* from .coveragerc 2016-10-12 16:20:49 -04:00
.gitignore doc: Integrate oslo_policy.sphinxpolicygen 2016-10-20 10:31:01 +01:00
.gitreview Add .gitreview config file for gerrit. 2011-10-24 15:07:19 -04:00
.mailmap Add mailmap entry 2014-05-07 12:14:26 -07:00
.testr.conf [placement] Adjust the name of the gabbi tests 2016-09-20 19:14:44 +00:00
babel.cfg Get rid of distutils.extra. 2012-02-08 19:30:39 -08:00
bindep.txt List system dependencies for running common tests 2016-08-24 06:49:32 +02:00
CONTRIBUTING.rst Workflow documentation is now in infra-manual 2014-12-05 03:30:37 +00:00
HACKING.rst hacking: Use assertIs(Not), assert(True|False) 2016-10-12 11:14:33 +01:00
LICENSE initial commit 2010-05-27 23:05:26 -07:00
MAINTAINERS Add a maintainers file 2015-05-23 03:22:07 +10:00
README.rst Refresh README and its docs links 2016-08-08 10:26:08 +01:00
requirements.txt Remove redundant VersionedObject Fields 2016-11-22 15:47:53 -05:00
run_tests.sh Add description on how to run ./run_test.sh -8 2016-01-11 13:17:04 +00:00
setup.cfg Remove deprecated nova-all binary 2016-10-12 10:02:17 -07:00
setup.py Updated from global requirements 2015-09-17 16:41:48 +00:00
test-requirements.txt libvirt: Cleanup test_create_configdrive 2016-12-01 16:58:05 +00:00
tests-py3.txt Remove more tests from tests-py3.txt 2016-12-01 10:21:47 +08:00
tox.ini Remove bandit.yaml in favor of defaults 2016-10-20 18:09:54 +00:00

README.rst

OpenStack Nova

OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of compute technologies, including: libvirt (KVM, Xen, LXC and more), Hyper-V, VMware, XenServer and OpenStack Ironic.

OpenStack Nova is distributed under the terms of the Apache License, Version 2.0. The full terms and conditions of this license are detailed in the LICENSE file.

API

To learn how to use Nova's API, consult the documentation available online at:

http://developer.openstack.org/api-guide/compute/ http://developer.openstack.org/api-ref/compute/

For more information on OpenStack APIs, SDKs and CLIs, please see:

http://www.openstack.org/appdev/ http://developer.openstack.org/

Operators

To learn how to deploy and configure OpenStack Nova, consult the documentation available online at:

http://docs.openstack.org

For information about the different compute (hypervisor) drivers supported by Nova, please read:

http://docs.openstack.org/developer/nova/feature_classification.html

In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at:

http://bugs.launchpad.net/nova

Developers

For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst.

Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests.

Further developer focused documentation is available at:

http://docs.openstack.org/developer/nova/