nova/nova/tests/unit
Matthew Booth 1a320f2a0e libvirt: Don't delete disks on shared storage during evacuate
When evacuating an instance between compute hosts on shared storage,
during the rebuild operation we call spawn() on the destination
compute. spawn() currently assumes that it should cleanup all
resources on failure, which results in user data being deleted in the
evacuate case.

This change modifies spawn in the libvirt driver such that it only
cleans up resources it created.

Conflicts:
    nova/tests/unit/virt/libvirt/test_driver.py

NOTE(lyarwood): Conflicts due to I08cd4787ab4c9539574237e26ba5bf6d4246b32e
and I5a9e5532c46a5f7064441ae644125d21efe5fda1 not being present in
stable/train.

Co-Authored-By: Lee Yarwood <lyarwood@redhat.com>
Closes-Bug: #1550919
Change-Id: I764481966c96a67d993da6e902dc9fc3ad29ee36
(cherry picked from commit 497360b0ea)
(cherry picked from commit 8b48ca672d)
2020-06-10 00:43:31 +00:00
..
api Reject boot request for unsupported images 2020-04-16 11:53:02 +00:00
cmd Add FUP unit test for port heal allocations 2019-08-29 15:52:40 -04:00
compute Update scheduler instance info at confirm resize 2020-05-19 13:36:06 +00:00
conductor bug-fix: Reject live migration with vpmem 2020-03-25 05:25:01 +00:00
conf
console Mask the token used to allow access to consoles 2019-11-29 11:40:44 +00:00
db Don't delete compute node, when deleting service other than nova-compute 2019-11-20 13:37:19 +00:00
fake_loadables
image Add extra spec parameter and image property for memory encryption 2019-09-01 15:17:31 +01:00
keymgr
network Add config option for neutron client retries 2020-03-25 17:26:37 +00:00
notifications extend libvirt video model support 2019-06-21 16:53:37 +01:00
objects Fix instance.hidden migration and querying 2020-02-07 09:13:44 -08:00
pci Fix non-existent method of Mock 2019-08-15 21:20:08 +00:00
privsep Address nits from privsep series 2019-08-22 11:37:02 +01:00
scheduler Add support for translating CPU policy extra specs, image meta 2019-09-18 00:21:10 +01:00
servicegroup Fix deprecation warning for threadgroup.add_timer 2019-02-07 09:37:00 -05:00
ssl_cert
virt libvirt: Don't delete disks on shared storage during evacuate 2020-06-10 00:43:31 +00:00
volume Add retry to cinder API calls related to volume detach 2020-04-22 16:54:47 -04:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py hacking: Resolve W605 (invalid escape sequence) 2019-06-24 14:24:06 -05:00
fake_block_device.py
fake_build_request.py
fake_console_auth_token.py
fake_crypto.py
fake_diagnostics.py
fake_flavor.py
fake_hosts.py
fake_instance.py Claim resources in resource tracker 2019-09-13 08:50:35 +00:00
fake_ldap.py
fake_network.py
fake_network_cache_model.py
fake_notifier.py
fake_pci_device_pools.py
fake_policy.py Remove '/os-cells' REST APIs 2019-04-16 18:26:13 +01:00
fake_processutils.py
fake_request_spec.py Fix resetting non-persistent fields when saving obj 2019-02-26 09:26:52 +09:00
fake_requests.py
fake_server_actions.py
fake_volume.py
fake_xvp_console_proxy.py
image_fixtures.py
matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
policy_fixture.py Delete the placement code 2019-04-28 20:06:15 +00:00
test_api_validation.py Remove '/os-cells' REST APIs 2019-04-16 18:26:13 +01:00
test_availability_zones.py Always pass HostAPI to get_availability_zones 2019-04-26 15:30:48 -04:00
test_baserpc.py
test_block_device.py
test_cache.py
test_cinder.py
test_conf.py Delete the placement code 2019-04-28 20:06:15 +00:00
test_configdrive2.py
test_context.py Tests: autospecs all the mock.patch usages 2019-08-19 09:43:10 -05:00
test_crypto.py We no longer need rootwrap. 2019-02-27 05:06:31 +00:00
test_exception.py
test_fake_notifier.py
test_fixtures.py Fix SynchronousThreadPoolExecutorFixture mock of Future 2019-05-08 02:46:50 +00:00
test_flavors.py Remove deprecated 'default_flavor' config option 2019-04-30 13:01:40 +00:00
test_hacking.py Add a hacking rule for useless assertions 2019-08-21 14:42:53 +09:00
test_hooks.py
test_identity.py
test_instance_types_extra_specs.py
test_iptables_network.py hacking: Resolve W605 (invalid escape sequence) 2019-06-24 14:24:06 -05:00
test_ipv6.py
test_json_ref.py Tests: autospecs all the mock.patch usages 2019-08-19 09:43:10 -05:00
test_loadables.py
test_matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
test_metadata.py Tests: autospecs all the mock.patch usages 2019-08-19 09:43:10 -05:00
test_notifications.py Remove deprecated 'default_flavor' config option 2019-04-30 13:01:40 +00:00
test_notifier.py
test_policy.py Add server sub-resource topology API 2019-08-30 10:04:56 +08:00
test_profiler.py Remove nova-consoleauth 2019-07-05 15:04:47 +00:00
test_quota.py Move iptables rule fetching and setting to privsep. 2019-08-16 11:24:07 +01:00
test_rpc.py test_rpc: Stop f****** with global state 2019-04-26 12:21:16 +01:00
test_safeutils.py
test_service.py
test_service_auth.py
test_test.py Move selective patching of open() to nova.test for reuse 2019-05-25 02:49:40 +00:00
test_test_utils.py
test_utils.py DRY get_sdk_adapter tests 2019-08-29 10:11:18 -05:00
test_versions.py Move selective patching of open() to nova.test for reuse 2019-05-25 02:49:40 +00:00
test_weights.py
test_wsgi.py
utils.py Bump to hacking 1.1.0 2019-04-12 16:23:49 +01:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎