23d3b8fbc9
The virt driver FakeDriver used in both the functional and in the unit
test used a global state to configure the host and node names the driver
reports. This was hard to use when more then one compute service is started.
Also global state is dangerous.
It turned out that only a set of unit tests are using multiple nodes per
compute the rest of the tests can simply use host=<hostname>,
nodes=[<hostname>] setup.
So this removes the global state.
On stable/stein:
* Changes in functional/regressions/test_bug_1764556.py just removes the
usage of the global state as that test was backported before the patch
being backported was introduced
* Changes in functional/regressions/test_bug_1839560.py is a re-backport
of If822509e906d5094f13a8700b2b9ed3c40580431 adapted to the current
patch.
Related-Bug: #1859766
Change-Id: I2cf2fcbaebc706f897ce5dfbff47d32117064f9c
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| __init__.py | ||
| README.rst | ||
| test_bug_1404867.py | ||
| test_bug_1522536.py | ||
| test_bug_1541691.py | ||
| test_bug_1548980.py | ||
| test_bug_1552888.py | ||
| test_bug_1554631.py | ||
| test_bug_1558866.py | ||
| test_bug_1568208.py | ||
| test_bug_1595962.py | ||
| test_bug_1620248.py | ||
| test_bug_1669054.py | ||
| test_bug_1670627.py | ||
| test_bug_1671648.py | ||
| test_bug_1675570.py | ||
| test_bug_1678326.py | ||
| test_bug_1679750.py | ||
| test_bug_1682693.py | ||
| test_bug_1689692.py | ||
| test_bug_1702454.py | ||
| test_bug_1713783.py | ||
| test_bug_1718455.py | ||
| test_bug_1718512.py | ||
| test_bug_1719730.py | ||
| test_bug_1732947.py | ||
| test_bug_1735407.py | ||
| test_bug_1741125.py | ||
| test_bug_1741307.py | ||
| test_bug_1746483.py | ||
| test_bug_1746509.py | ||
| test_bug_1764556.py | ||
| test_bug_1764883.py | ||
| test_bug_1778305.py | ||
| test_bug_1780373.py | ||
| test_bug_1781710.py | ||
| test_bug_1784353.py | ||
| test_bug_1790204.py | ||
| test_bug_1794996.py | ||
| test_bug_1797580.py | ||
| test_bug_1806064.py | ||
| test_bug_1806515.py | ||
| test_bug_1815153.py | ||
| test_bug_1825020.py | ||
| test_bug_1825034.py | ||
| test_bug_1825537.py | ||
| test_bug_1830747.py | ||
| test_bug_1837955.py | ||
| test_bug_1839560.py | ||
| test_bug_1843090.py | ||
| test_bug_1849409.py | ||
Tests for Specific Regressions
When we have a bug reported by end users that we can write a full stack reproduce on, we should. And we should keep a regression test for that bug in our tree. It can be deleted at some future date if needed, but largely should not be changed.
Writing Regression Tests
- These should be full stack tests which inherit from nova.test.TestCase directly. (This is to prevent coupling with other tests).
- They should setup a full stack cloud in their setUp via fixtures
- They should each live in a file which is named test_bug######.py
Writing Tests Before the Bug is Fixed
TODO describe writing and landing tests before the bug is fixed as a reproduce.