nova/nova/tests/unit
Nikola Dipanov 2ffcf18d00 consoleauth: Store access_url on token authorization
Related-bug: 1409142

As part of the fix for the related bug - we've added protocol checking
to mitigate MITM attacks, however we base protocol checking on a config
option that is normally only intended for compute hosts.

This is quite user hostile, as it is now important that all nodes
running compute and proxy services have this option in sync.

We can do better than that - we can persist the URL the client is
expected to use, and once we get it back on token validation, we can
make sure that the request is using the intended protocol, mitigating
the MITM injected script attacks.

This patch makes sure that the access_url is persisted with the token -
the follow-up patch makes consoles use that info.

Change-Id: I02a377f54de46536ca35413b615d3298967afc33
2015-04-07 16:54:32 +01:00
..
api Add json-schema for v2.1 fixed-ips 2015-04-01 18:39:16 +08:00
cells Fix how the Cells API is returning ComputeNode objects 2015-04-02 14:26:34 -04:00
cert Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
cmd console: add unit tests for baseproxy 2015-02-23 10:24:44 -08:00
compute consoleauth: Store access_url on token authorization 2015-04-07 16:54:32 +01:00
conductor Merge "don't use oslo.messaging in mock" 2015-03-23 16:05:44 +00:00
console Expand Origin header check for serial console 2015-03-31 16:30:17 -04:00
consoleauth consoleauth: Store access_url on token authorization 2015-04-07 16:54:32 +01:00
db Merge "Fix PciDeviceDBApiTestCase with referential constraint checking" 2015-04-02 15:00:57 +00:00
fake_loadables
functional
image Use oslo.log 2015-02-22 07:56:40 -05:00
keymgr Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
monkey_patch_example Enable check for H238 rule 2015-01-20 18:05:47 +03:00
network Merge "Allow _exec_ebtables to parse stderr" 2015-04-06 22:20:06 +00:00
objects Update check before migrating flavor 2015-03-31 17:26:30 -04:00
pci Move ComputeNode creation at init stage in ResourceTracker 2015-03-25 19:12:43 +00:00
scheduler Respect CONF.scheduler_use_baremetal_filters 2015-04-03 08:23:40 -07:00
servicegroup Fix up join() and leave() methods of servicegroup 2015-03-11 23:22:11 +00:00
ssl_cert Update WSGI SSL IPv6 test and SSL certificates 2015-01-07 23:10:00 -06:00
virt Merge "libvirt: remove volume_drivers config param" 2015-04-06 23:44:12 +00:00
volume Make unit tests inherit from test.NoDBTestCase 2015-03-06 09:46:31 +02:00
README.rst
__init__.py move eventlet GREENDNS override to top level 2014-12-08 17:41:03 -05:00
cast_as_call.py Replace fanout to False for CastAsCall fixture 2015-03-02 15:46:22 +01:00
conf_fixture.py Test fixture for the api database 2015-03-18 10:06:03 -04:00
fake_block_device.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_crypto.py Adds cleanup on v2.2 keypair api and tests 2015-03-24 17:06:18 +02:00
fake_hosts.py Change queries for network services to use binary instead of topic 2015-03-04 10:32:45 -08:00
fake_instance.py Add vcpu_model to instance object 2015-02-12 22:22:24 -08:00
fake_ldap.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_network.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_network_cache_model.py Add ipv6 support to fake network models 2014-12-23 17:11:14 -08:00
fake_notifier.py Be more forgiving to empty context in notification 2015-03-31 00:00:46 +00:00
fake_pci_device_pools.py Add pci_device_pools to ComputeNode object 2014-12-17 14:34:44 +00:00
fake_policy.py Add policy check for consoles 2015-03-20 03:45:45 +08:00
fake_processutils.py Use oslo.log 2015-02-22 07:56:40 -05:00
fake_server_actions.py
fake_utils.py
fake_volume.py Fix wrong log output in nova/nova/tests/unit/fake_volume.py 2015-03-10 00:54:36 +00:00
image_fixtures.py
matchers.py Fix errors in string formatting operations 2015-01-21 22:41:28 -05:00
policy_fixture.py Avoid load real policy from policy.d when using fake policy fixture 2015-03-23 21:30:28 +08:00
test_api_validation.py Add json-schema for v2.1 fixed-ips 2015-04-01 18:39:16 +08:00
test_availability_zones.py Fixed test to work with random PYTHONHASHSEED 2015-03-26 09:52:38 +03:00
test_baserpc.py ensure DatabaseFixture removes db on cleanup 2015-03-12 16:55:55 -04:00
test_bdm.py
test_block_device.py Merge "libvirt: fix failure when attaching volume to iso instance" 2015-02-02 22:27:24 +00:00
test_cinder.py Use session in cinderclient 2014-11-18 09:46:25 +10:00
test_configdrive2.py Compute: update config drive settings on instance 2015-03-04 08:46:43 -08:00
test_context.py Better round trip for RequestContext<->Dict conversion 2015-03-05 18:37:45 +00:00
test_crypto.py CWD is incorrectly set if exceptions are thrown 2015-02-09 15:13:52 +08:00
test_exception.py
test_fixtures.py Add a fixture for the NovaObject indirection API 2015-03-23 18:46:11 +01:00
test_flavors.py Avoid KeyError Exception in extract_flavor() 2015-03-05 22:54:34 +14:00
test_hacking.py Use oslo.log 2015-02-22 07:56:40 -05:00
test_hooks.py Fix improper use of Stevedore 2015-02-05 09:15:45 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py Added hacking rule for assertTrue/False(A in B) 2015-01-07 12:25:53 +03:00
test_ipv6.py
test_linuxscsi.py Use oslo.log 2015-02-22 07:56:40 -05:00
test_loadables.py
test_matchers.py Expansion of matching XML strings logic 2015-01-15 17:04:10 +00:00
test_metadata.py Adds x509 certificate keypair support 2015-03-05 21:30:34 +02:00
test_notifications.py Be more forgiving to empty context in notification 2015-03-31 00:00:46 +00:00
test_nova_manage.py Store cells credentials in transport_url properly 2015-03-31 00:00:20 +00:00
test_objectstore.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_pipelib.py ensure DatabaseFixture removes db on cleanup 2015-03-12 16:55:55 -04:00
test_policy.py Performance: leverage dict comprehension in PEP-0274 2015-01-16 10:06:13 +08:00
test_quota.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_safeutils.py
test_service.py Remove usage of db.service_get_by_args 2015-03-06 11:00:22 +00:00
test_test.py Added assertJsonEqual method to TestCase class 2015-03-17 20:23:15 +03:00
test_test_utils.py
test_utils.py Fixed test to work with random PYTHONHASHSEED 2015-03-26 09:52:38 +03:00
test_versions.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_weights.py
test_wsgi.py Skip socket related unit tests on OSX 2015-03-26 18:33:42 -04:00
utils.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎