731c6b1d5d
Fixes the wait_for_not_running function in smoketests/base.py so that it short circuits when an instance ID is deleted rather than waits 60 seconds (the timeout). Previously this function had two problems: 1) It used Boto's instance.update() instead of instance.update(validate=True). Since update() returns returns quietly if no data about the instance was returned (aka the instance has been deleted) it effectively made this function almost always wait for the timeout (60 seconds). This makes the tests take about a minute longer than they need to unless #2 below occurs... 2) It also introduced a race condition in that... if hit just right the instance.state would get set to 'terminated'. Which would cause the loop to short circuit. This might seem correct at first glance but in fact causes intermittent failures in some of the netadmin tests because security groups can't be deleted if a running (or exiting) instance is still assigned to them. In fact wait_for_not_running was added to guard against just this in the first place! Also, renames the base.wait_for_not_running function to be called wait_for_deleted (that is what we are really doing here) Change-Id: I4486995a7d9028d876366e8d7a2c845520319b86 |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| base.py | ||
| flags.py | ||
| proxy.sh | ||
| public_network_smoketests.py | ||
| random.image | ||
| random.kernel | ||
| run_tests.py | ||
| test_netadmin.py | ||
| test_sysadmin.py | ||