nova/nova/tests/unit
Matt Riedemann 425518d198 Execute CrossCellMigrationTask from MigrationTask
This adds the code to check if a cross-cell move is
allowed by the RequestSpec, which is set in the API,
and if so, checks to see if the scheduler selected
a host in another cell. If so, then CrossCellMigrationTask
is executed.

Note the _restrict_request_spec_to_cell method gets
renamed and logging is adjusted since we may not be
restricting the scheduler to hosts in the same cell
if cross-cell moves are allowed.

Part of blueprint cross-cell-resize

Change-Id: Ibaa31fc8079c16e169472372c05dc48ff0602515
2019-11-05 14:16:03 -05:00
..
api Merge "Add new policy rule for viewing host status UNKNOWN" 2019-11-02 00:09:36 +00:00
cmd Add FUP unit test for port heal allocations 2019-08-29 15:52:40 -04:00
compute Add finish_snapshot_based_resize_at_dest compute method 2019-11-02 17:04:08 -04:00
conductor Execute CrossCellMigrationTask from MigrationTask 2019-11-05 14:16:03 -05:00
conf
console Reduce scope of 'path' query parameter to noVNC consoles 2019-09-27 13:50:52 +00:00
db Add reserved schema migrations for Ussuri 2019-10-03 08:47:36 -07:00
fake_loadables
image Add extra spec parameter and image property for memory encryption 2019-09-01 15:17:31 +01:00
keymgr
network Merge "Remove mox in unit/network/test_neutronv2.py (22)" 2019-09-27 12:47:37 +00:00
notifications Add Aggregate image caching progress notifications 2019-10-29 08:18:32 -07:00
objects Move Destination object tests to their own test class 2019-10-16 22:05:45 +00:00
pci Fix non-existent method of Mock 2019-08-15 21:20:08 +00:00
privsep Address nits from privsep series 2019-08-22 11:37:02 +01:00
scheduler Merge "Remove @safe_connect from _delete_provider" 2019-10-09 22:49:12 +00:00
servicegroup Fix deprecation warning for threadgroup.add_timer 2019-02-07 09:37:00 -05:00
ssl_cert
virt libvirt: Ignore volume exceptions during post_live_migration 2019-10-24 09:30:12 +01:00
volume Fix exception translation when creating volume 2019-10-10 02:38:33 +00:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py conf: Remove deprecated 'project_id_regex' opt 2019-09-27 18:59:02 +09:00
fake_block_device.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_build_request.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_console_auth_token.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_crypto.py
fake_diagnostics.py
fake_flavor.py
fake_hosts.py
fake_instance.py Claim resources in resource tracker 2019-09-13 08:50:35 +00:00
fake_ldap.py
fake_network.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_network_cache_model.py
fake_notifier.py Fix jsonutils.to_primitive UserWarning 2018-12-17 22:56:50 -05:00
fake_pci_device_pools.py
fake_policy.py Add new policy rule for viewing host status UNKNOWN 2019-10-28 15:40:08 +00:00
fake_processutils.py
fake_request_spec.py Fix resetting non-persistent fields when saving obj 2019-02-26 09:26:52 +09:00
fake_requests.py
fake_server_actions.py
fake_volume.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_xvp_console_proxy.py
image_fixtures.py Merge image_size extension response into image view builder 2018-10-18 01:59:34 +00:00
matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
policy_fixture.py Delete the placement code 2019-04-28 20:06:15 +00:00
test_api_validation.py Remove '/os-cells' REST APIs 2019-04-16 18:26:13 +01:00
test_availability_zones.py Always pass HostAPI to get_availability_zones 2019-04-26 15:30:48 -04:00
test_baserpc.py
test_block_device.py Add method to generate device names universally 2019-01-15 18:55:11 +00:00
test_cache.py
test_cinder.py Make [cinder]/catalog_info no longer require a service_name 2018-11-28 18:33:30 -05:00
test_conf.py Delete the placement code 2019-04-28 20:06:15 +00:00
test_configdrive2.py
test_context.py Revert "Log CellTimeout traceback in scatter_gather_cells" 2019-10-22 17:12:28 -04:00
test_crypto.py We no longer need rootwrap. 2019-02-27 05:06:31 +00:00
test_exception.py Convert exception messages to strings 2018-11-05 14:21:02 +02:00
test_fake_notifier.py Raise error on timeout in wait_for_versioned_notifications 2018-09-29 00:29:49 +01:00
test_fixtures.py Fix SynchronousThreadPoolExecutorFixture mock of Future 2019-05-08 02:46:50 +00:00
test_flavors.py Remove deprecated 'default_flavor' config option 2019-04-30 13:01:40 +00:00
test_hacking.py Add a hacking rule for useless assertions 2019-08-21 14:42:53 +09:00
test_hooks.py
test_identity.py
test_instance_types_extra_specs.py
test_iptables_network.py hacking: Resolve W605 (invalid escape sequence) 2019-06-24 14:24:06 -05:00
test_ipv6.py
test_json_ref.py Tests: autospecs all the mock.patch usages 2019-08-19 09:43:10 -05:00
test_loadables.py
test_matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
test_metadata.py Tests: autospecs all the mock.patch usages 2019-08-19 09:43:10 -05:00
test_notifications.py Remove deprecated 'default_flavor' config option 2019-04-30 13:01:40 +00:00
test_notifier.py
test_policy.py Add new policy rule for viewing host status UNKNOWN 2019-10-28 15:40:08 +00:00
test_profiler.py Remove nova-consoleauth 2019-07-05 15:04:47 +00:00
test_quota.py Move iptables rule fetching and setting to privsep. 2019-08-16 11:24:07 +01:00
test_rpc.py test_rpc: Stop f****** with global state 2019-04-26 12:21:16 +01:00
test_safeutils.py
test_service.py Move conductor wait_until_ready() delay before manager init 2018-08-31 12:50:10 -07:00
test_service_auth.py
test_test.py Move selective patching of open() to nova.test for reuse 2019-05-25 02:49:40 +00:00
test_test_utils.py
test_utils.py Remove workaround for bug #1709118 2019-10-07 16:33:20 +00:00
test_versions.py Move selective patching of open() to nova.test for reuse 2019-05-25 02:49:40 +00:00
test_weights.py Per aggregate scheduling weight 2019-01-21 11:48:44 +08:00
test_wsgi.py
utils.py Bump to hacking 1.1.0 2019-04-12 16:23:49 +01:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎