For some reason, only NotImplementedError in _error_out_instance_on_exception would use the $instance_state parameter which can be controlled by the caller of the context manager to determine the rollback vm_state. But in the case of InstanceFaultRollback, the caller may want to reset the vm_state back to something other than ACTIVE, like if the instance is actually STOPPED and something like prep_resize fails (you can resize a STOPPED instance). This change makes _error_out_instance_on_exception handle InstanceFaultRollback like NotImplementedError in that the instance_state parameter is used to reset the instance.vm_state. It also adds a docstring explaining how this context manager works along with some notes/questions about ways to improve it. Change-Id: Ie4f9177f4d54cbc7dbcf58bd107fd5f24c60d8bb Related-Bug: #1811235
Team and repository tags
OpenStack Nova
OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of compute technologies, including: libvirt (KVM, Xen, LXC and more), Hyper-V, VMware, XenServer, OpenStack Ironic and PowerVM.
Use the following resources to learn more.
API
To learn how to use Nova's API, consult the documentation available online at:
For more information on OpenStack APIs, SDKs and CLIs in general, refer to:
Operators
To learn how to deploy and configure OpenStack Nova, consult the documentation available online at:
In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at:
Developers
For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst.
Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests.
Further developer focused documentation is available at:
Other Information
During each Summit and Project Team Gathering, we agree on what the whole community wants to focus on for the upcoming release. The plans for nova can be found at: